Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9850] Re-implement events for attribute changes #3231

Closed
icinga-migration opened this issue Aug 6, 2015 · 7 comments
Closed
Labels
area/api REST API enhancement New feature or request
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9850

Created by mfriedrich on 2015-08-06 12:36:38 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-09-17 14:13:18 +00:00)
Target Version: 2.4.0
Last Update: 2015-09-21 07:41:08 +00:00 (in Redmine)

Backport?: No
Include in Changelog: 0

  • Cluster
  • DB IDO
  • CompatLogger

Parent Task: #9081

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-04 12:04:55 +00:00

  • Assigned to set to mfriedrich

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-04 12:05:06 +00:00

  • Status changed from New to Assigned

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-11 08:19:45 +00:00

This will require a global event (e.g. OnVersionChanged as implemented in the cluster object sync) to properly detect modified attribute changes and trigger updates. I've already implemented that for #9927 yesterday.

In terms of DB IDO, we'll certainly can't detect which attribute was changed exactly and should therefore update all columns stored inside the modified_attributes dictionary.

Plus we'll need to expose the objects version inside the external interfaces, next to the package name (?) to better reflect modified attributes.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-11 08:19:52 +00:00

  • Relates set to 9927

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-17 14:13:18 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

The events and updates work properly for DB IDO and the cluster. CompatLogger is not relevant as it uses the existing events we've already added. Exposing the version and/or modifying the GetModifiedAttributes pattern should be handled in #9851.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-17 14:13:27 +00:00

  • Relates set to 9851

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-21 07:41:08 +00:00

  • Backport? changed from TBD to No

@icinga-migration icinga-migration added enhancement New feature or request area/api REST API labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.4.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api REST API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant