Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #9409] Add sources for jquery-ui and install minified versions only #1555

Closed
icinga-migration opened this issue Jun 14, 2015 · 10 comments

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9409

Created by formorer on 2015-06-14 17:11:59 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-08-04 18:55:29 +00:00)
Target Version: 1.14
Last Update: 2015-08-04 19:08:09 +00:00 (in Redmine)

Icinga Version: 1.13.2
OS Version: Source

Hi,

its me again. Icinga 1.13 has again several sources missing.
I ignored it for that uploads which gave me debian bug:
#788723.

So please, please fix that problem for all times. Please don't ever add any compressed js sources, but do compress them
on build time.

Sources missing:
html/jquery-ui/ui/jquery.ui.widget.js
html/jquery-ui/ui/jquery.ui.slider.js
html/jquery-ui/ui/jquery.ui.position.js
html/jquery-ui/ui/jquery.ui.mouse.js
html/jquery-ui/ui/jquery.ui.menu.js
html/jquery-ui/ui/jquery.ui.effect.js
html/jquery-ui/ui/jquery.ui.effect-blind.js
html/jquery-ui/ui/jquery.ui.datepicker.js
html/jquery-ui/ui/jquery.ui.core.js
html/jquery-ui/ui/jquery.ui.button.js
html/jquery-ui/ui/jquery.ui.autocomplete.js

Changesets

2015-08-04 18:54:19 +00:00 by mfriedrich fb5e3c8

Add sources for jquery-ui and install minified versions only

This basically adds the entire jquery-ui source but makes it
easier to ship everything required whilst only installing
the files Classic UI actually needs.

fixes #9409

2015-10-23 21:32:00 +00:00 by ricardo 8aa7a9b

Fixes last commit on jquery-ui minified version 9409

The link to the jquery-ui libs was broken. Now it
works again.

fixes #9409

Relations:

@icinga-migration
Copy link
Author

Updated by ricardo on 2015-06-14 17:37:50 +00:00

Hi,

So if we add the sources and keep the compressed ones eould solve this issue for you?

Cheers
Ricardo

@icinga-migration
Copy link
Author

Updated by formorer@formorer.de on 2015-06-14 18:00:03 +00:00

On Sun, 14 Jun 2015, development@icinga.org wrote:

Issue #9409 has been updated by ricardo.

Hi,

So if we add the sources and keep the compressed ones eould solve this issue for you?
Sure, as it always does.

But I would prefer a real solution.

Alex

@icinga-migration
Copy link
Author

Updated by ricardo on 2015-08-04 18:45:27 +00:00

I'll have a look at it right now

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-08-04 18:47:06 +00:00

I already have a 90% solution on my disk. I'm just adding the entire jquery-ui tarball and selectively installing the minified sources.

@icinga-migration
Copy link
Author

Updated by ricardo on 2015-08-04 18:48:19 +00:00

OK, just would have exchanged the files with proper source files.

Thanks and sorry for slacking off.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-08-04 18:49:14 +00:00

  • Status changed from New to Assigned
  • Assigned to changed from ricardo to mfriedrich
  • Target Version set to 1.14

No worries. Get your hands dirty with Icinga Web 2 :-)

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-08-04 18:53:54 +00:00

  • Subject changed from Sources missing to Add sources for jquery-ui and install minified versions only

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-08-04 18:55:29 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset fb5e3c8.

@icinga-migration
Copy link
Author

Updated by ricardo on 2015-08-04 19:08:09 +00:00

wow, ok.

@icinga-migration
Copy link
Author

Updated by mfrosch on 2015-12-30 12:07:48 +00:00

  • Relates set to 10919

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant