Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9346] Potential active rows not deselected when navigating by browser history #1686

Closed
icinga-migration opened this issue Jun 1, 2015 · 5 comments
Labels
area/javascript Affects the javascript framework bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9346

Created by elippmann on 2015-06-01 15:36:18 +00:00

Assignee: mjentsch
Status: Resolved (closed on 2015-06-30 12:15:05 +00:00)
Target Version: 2.0.0
Last Update: 2015-07-17 09:48:54 +00:00 (in Redmine)


Steps to reproduce

Single Select

  • List services
  • Select a service
  • Navigate back
  • Notice that the previous selected row is not automatically deselected

Multi Select

  • List services
  • Select 5 services
  • Navigate back until the detail tab disappears
  • Notice that 5 rows are selected

Changesets

2015-06-29 16:48:42 +00:00 by mjentsch aec59d9

Use current filter to highlight active rows instead of storing active rows in JS

Clean up selection code and move it into separate behavior and parse filter query to fetch selectable rows.

refs #9054
refs #9346

2015-06-29 16:51:32 +00:00 by mjentsch 96677fb

Fix selection when clicking on regular links

refs #9054
refs #9346

2015-06-30 09:53:38 +00:00 by mjentsch e0d588c

Fix look and feel of row selection

Always refresh all tables on render and click events, to display or remove active rows without any delay.

refs #9054
refs #9346

2015-06-30 12:08:19 +00:00 by mjentsch aecfb2e

Merge branch 'bugfix/multiselection-not-visible-9054'

fixes #9054
fixes #9346

Relations:

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-06-04 22:52:57 +00:00

  • Target Version changed from Backlog to 261

@icinga-migration
Copy link
Author

Updated by mjentsch on 2015-06-24 16:51:02 +00:00

  • Assigned to set to mjentsch

@icinga-migration
Copy link
Author

Updated by mjentsch on 2015-06-30 12:15:05 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset aecfb2e.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-17 09:48:54 +00:00

  • Target Version changed from 261 to 2.0.0

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-17 13:10:24 +00:00

  • Relates set to 9040

@icinga-migration icinga-migration added bug Something isn't working area/javascript Affects the javascript framework labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/javascript Affects the javascript framework bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant