Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9339] Take notes into account when searching for host and service names #1685

Closed
icinga-migration opened this issue May 29, 2015 · 7 comments
Assignees
Labels
area/monitoring Affects the monitoring module enhancement New feature or improvement wontfix Deprecated, not supported or not worth any effort

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9339

Created by arcade on 2015-05-29 15:12:43 +00:00

Assignee: elippmann
Status: New
Target Version: (none)
Last Update: 2016-06-06 21:19:01 +00:00 (in Redmine)


I'd like to extend https://dev.icinga.org/issues/8241 with host/service notes.

We've a lot of information in this notes and for quick access it would be nice to search for them too. Sometimes you just know some keywords in this notes and not the actual service/host name and so users can't find their stuff.

Attachments


Parent Task: #9479

@icinga-migration
Copy link
Author

Updated by arcade on 2015-06-05 09:41:12 +00:00

  • File added 0001-Take-notes-into-account.patch

I checked the changes in #8241 and modified a few lines as you can see in the patch. I'am now able to search for host/service notes. But i'm not sure if this is everything. Would be nice if someone could quick check that patch.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-16 08:00:31 +00:00

  • Category set to Monitoring
  • Status changed from New to Feedback
  • Assigned to set to tgelf

Hi,

Thanks for the report. I'm not quite sure whether it is a good idea to always include notes when searching because it's a text field and not indexed. Since we've never tested this, I have no idea whether we run into performance issues in big environments.

@tom: Can you please share your ideas on that one? We could add a feature for adding search columns when searching:

Search: +notes a note

Cheers,
Eric

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-07-16 09:01:07 +00:00

Hi Eric!

lippser wrote:

@tom: Can you please share your ideas on that one?

While I'm not a friend of additional configuration options this might be one af the cases where it could make sense to me. Btw, I'm currently sitting in front of an environment with about 7000 hosts and 50000 services. Search performance is IMO not acceptable, adding a "text" column would definitively not help to improve this :-(

Therefore when introducing such configuration options please also think about allowing one to disable "last comments" and "service summary" sub-joins in the host list, that improves performance dramatically. Also changing default sort orders might be useful, as weird decisions related to display_name/Icinga2 really hurt us too.

Cheers,
Thomas

NB: If you want to share further thoughts before implementing something like this please do not hesitate to do so ;-)

NBB: Please also try to reflect on whether it could make sense to configure searchlets like dashlets...

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-07-16 09:02:16 +00:00

  • Assigned to changed from tgelf to elippmann

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-11-09 10:29:53 +00:00

  • Status changed from Feedback to New
  • Parent Id set to 9479

@icinga-migration
Copy link
Author

Updated by arcade on 2016-06-06 21:19:02 +00:00

Was there any progress in this one? In earlier versions i could easy do it by just adding the host/service notes definition as attached in the patch that doesn't seem to work anymore. Is there an easy way to enable it again?

@icinga-migration icinga-migration added enhancement New feature or improvement area/monitoring Affects the monitoring module labels Jan 17, 2017
@lippserd
Copy link
Member

No progress has been made here. I'll close this issue because it's very old and we have no plans to work on it in the near future. If you're interested in this topic, please open a new issue. PR with the patch plus a configuration option is welcome.

@lippserd lippserd added the wontfix Deprecated, not supported or not worth any effort label Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Affects the monitoring module enhancement New feature or improvement wontfix Deprecated, not supported or not worth any effort
Projects
None yet
Development

No branches or pull requests

2 participants