[dev.icinga.com #9303] Missing 'snmp_is_cisco' in Manubulon snmp-memory command definition

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9303

Created by TomG on 2015-05-22 07:19:48 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-06-17 13:20:02 +00:00)
Target Version: 2.3.6
Last Update: 2015-06-18 12:04:18 +00:00 (in Redmine)

Icinga Version: 2.3.4
Backport?: Already backported
Include in Changelog: 1

---

Hi,

the predefined check for snmp-memory on Cisco switches failed, because of the missing cisco option "-I". Here is a possible diff:

---    command-plugins-manubulon.conf.orig  2015-04-20 11:44:00.000000000 +0200
+++ command-plugins-manubulon.conf.new  2015-05-22 09:11:38.412654982 +0200
@@ -110,6 +110,9 @@
        "-f" = {
            set_if = "$snmp_perf$"
        }
+       "-I" = {
+           set_if = "$snmp_is_cisco$"
+       }
    }

--
Tom

Attachments

• 0001-Fix-missing-variable-in-command-plugins-manubulon.co.patch TomG - 2015-05-22 10:03:01 +00:00

Changesets

2015-06-17 13:13:38 +00:00 by TomG 8d383c6

Add 'snmp_is_cisco' to Manubulon snmp-memory command definition

The new var 'snmp_is_cisco' was added to snmp-memory check
for use the correct OID with cisco switches. The default
is 'false'.

fixes #9303

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2015-06-17 13:28:50 +00:00 by (unknown) 0763f4e

Update AUTHORS

refs #9416
refs #9303

2015-06-18 12:03:43 +00:00 by TomG 528b6f9

Add 'snmp_is_cisco' to Manubulon snmp-memory command definition

The new var 'snmp_is_cisco' was added to snmp-memory check
for use the correct OID with cisco switches. The default
is 'false'.

fixes #9303

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2015-06-18 12:03:52 +00:00 by (unknown) a2ed9f7

Update AUTHORS

refs #9303

[icinga-migration]

Updated by mfriedrich on 2015-05-22 08:47:18 +00:00

• Category changed from Plugins to ITL
• Status changed from New to Feedback
• Assigned to set to TomG

Could you please put that diff including a documentation update into a properly formatted git patch? Thanks.

[icinga-migration]

Updated by TomG on 2015-05-22 10:03:31 +00:00

• File added 0001-Fix-missing-variable-in-command-plugins-manubulon.co.patch

Here you are. :-)

[icinga-migration]

Updated by mfriedrich on 2015-06-17 13:15:55 +00:00

• Subject changed from Missing var for snmp-memory in command-plugins-manubulon.conf to Missing 'snmp_is_cisco' in Manubulon snmp-memory command definition
• Status changed from Feedback to Assigned
• Assigned to changed from TomG to mfriedrich
• Target Version set to 2.4.0
• Estimated Hours set to 0.5

Thanks. What I meant - you should also update the documentation inside doc/7-....
I've done that now for you once, check the referenced git commit. I've also added a description field below set_if extracted from check_snmp_mem.pl's help.

[icinga-migration]

Updated by TomG on 2015-06-17 13:20:02 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 8d383c6.

[icinga-migration]

Updated by gbeutner on 2015-06-18 12:04:18 +00:00

• Target Version changed from 2.4.0 to 2.3.6
• Backport? changed from TBD to Yes