Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9207] Show icinga program version in Monitoring Health #1632

Closed
icinga-migration opened this issue Apr 30, 2015 · 11 comments
Closed
Labels
area/monitoring Affects the monitoring module enhancement New feature or improvement
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9207

Created by mfriedrich on 2015-04-30 14:33:47 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-05-05 15:08:10 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-05-05 15:08:10 +00:00 (in Redmine)


Currently I only know that icinga is not running, but what if there are multiple backends not running?

It would be nice to know which instance & program_version is involved.

The database query could look like this:

MariaDB [icinga]> select program_version, status_update_time from icinga_programstatus ps;
+--------------------+---------------------+
| program_version    | status_update_time  |
+--------------------+---------------------+
| 1.11.8             | 2014-10-17 18:13:35 |
| v2.3.3-63-gbb59065 | 2015-04-29 12:53:31 |
+--------------------+---------------------+
2 rows in set (0,00 sec)

Auswahl_160.png

Attachments

Changesets

2015-05-01 14:00:55 +00:00 by mfriedrich 8f8e8f2

Show icinga program version in Monitoring Health

refs #9207

2015-05-01 14:09:14 +00:00 by mfriedrich 84654ed

Show icinga program version in Monitoring Health

Fallback for older versions is missing.

refs #9207

2015-05-05 15:02:45 +00:00 by mfriedrich defda53

Show icinga program version in Monitoring Health

Also emphasize on the backends used.

fixes #9207

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-04-30 14:34:48 +00:00

  • Relates set to 4139

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-04-30 15:56:35 +00:00

  • Relates set to 9208

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-04-30 15:58:32 +00:00

Better: Add the instance_name too.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-05-01 13:48:30 +00:00

Only go for the program_version column.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-05-01 14:12:22 +00:00

  • Status changed from New to Feedback
  • Assigned to set to tgelf

I've pushed a basic version into the linked feature branch.

One problem comes to the mind - the fallback for mapping non-existing columns is currently done in joinBaseTables in Statusquery.php. This does not work for Programstatusquery.php as there is no table join to be done. Though there's no more virtual function being called by the main class allowing to modify the columnMap hash.

@tom
Any ideas? Thanks :)

@icinga-migration
Copy link
Author

Updated by jmeyer on 2015-05-05 11:27:55 +00:00

  • Relates deleted 9208

@icinga-migration
Copy link
Author

Updated by jmeyer on 2015-05-05 11:27:58 +00:00

  • Blocks set to 9213

@icinga-migration
Copy link
Author

Updated by jmeyer on 2015-05-05 11:33:44 +00:00

If I may interrupt this ;P

What about ProgramstatusQuery::init() ?

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-05-05 14:32:35 +00:00

  • Status changed from Feedback to Assigned
  • Assigned to changed from tgelf to mfriedrich
  • Target Version set to 2.0.0-rc1

Doesn't really help as the children's init() function is never called, thanks though. Alex did come up with a different solution in #9223 so I will rebase my git branch against his fix and merge to master then.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-05-05 14:33:03 +00:00

  • Relates set to 9223

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-05-05 15:08:10 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset defda53.

@icinga-migration icinga-migration added enhancement New feature or improvement area/monitoring Affects the monitoring module labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.0-rc1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Affects the monitoring module enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant