Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #8623] Selected row lost after auto-refresh in every overview except for hosts and services #1435

Closed
icinga-migration opened this issue Mar 6, 2015 · 13 comments
Labels
area/ui Affects the user interface bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/8623

Created by elippmann on 2015-03-06 12:18:44 +00:00

Assignee: mjentsch
Status: Resolved (closed on 2015-07-29 15:35:05 +00:00)
Target Version: 2.0.0
Last Update: 2015-08-03 14:31:16 +00:00 (in Redmine)


When selecting a host or service in one of our overviews the selected row becomes highlighted and the detail view opens or gets updated. After auto-refreshing the overview, the selection is lost.

This used to work some time ago.

Changesets

2015-07-27 08:34:17 +00:00 by mjentsch f2d253f

Assure that rows are refreshed correctly on reload

Assure that all links are initialized when the selection is applied after a request. Move action table code into the actiontable behavior.

refs #8623

2015-07-28 13:21:02 +00:00 by mjentsch 8dbd671

Conform to coding guidelines, update docstrings and cleanup unused code

refs #8623

2015-07-28 13:30:32 +00:00 by mjentsch 40d31d0

Merge branch 'bugfix/selected-row-lost-after-autorefresh-8623'

fixes #8623

2015-07-29 09:41:17 +00:00 by mjentsch 2e8b742

Make servicegroup table an action table

refs #8623

2015-07-29 09:41:53 +00:00 by mjentsch ecdc03a

Fix selection lost after pushing refresh

Remove old row action code that interfered with action table behavior.

refs #8623

2015-07-29 12:32:26 +00:00 by mjentsch 3a85dc7

Display the table on single-selection rows as active without any delay

refs #8623

2015-07-29 13:10:32 +00:00 by mjentsch 9c27911

Display the table on single-selection rows as active without any delay

refs #8623

2015-07-29 13:21:29 +00:00 by mjentsch 6db79a7

Display the rows in the auth backend configuration as active without any delay

refs #8623

2015-07-29 15:18:52 +00:00 by mjentsch 3e7cc29

Fix issue that caused the refresh button to remove side bar

Do not apply base target globally for all toolbar elements, but specifically for those that should remove side-bars.

refs #8623
refs #6436

2015-07-29 15:30:45 +00:00 by mjentsch 20aa17c

Merge branch 'bugfix/selected-row-lost-after-autorefresh-8623'

fixes #8623

Relations:

@icinga-migration
Copy link
Author

Updated by jmeyer on 2015-03-06 12:29:50 +00:00

  • Status changed from New to Feedback
  • Assigned to set to elippmann

Hi Eric,

lippser wrote:

This used to work some time ago.

It does. Which view(s) are you referring to exactly?

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-06 12:38:13 +00:00

  • Subject changed from Selected row lost after auto-refresh to Selected row lost after auto-refresh in every overview except for hosts and services

All overviews except those for hosts and services are affected. The hostgroups and servicegroups overviews do not even select the row.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-11 19:53:14 +00:00

  • Status changed from Feedback to New
  • Assigned to deleted elippmann

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-13 02:43:42 +00:00

  • Target Version changed from 2.0.0-beta3 to 2.0.0-rc1

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-06-03 16:43:27 +00:00

  • Target Version changed from 2.0.0-rc1 to 261

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-17 09:48:09 +00:00

  • Target Version changed from 261 to 2.0.0

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-17 12:13:37 +00:00

  • Estimated Hours set to 16

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-17 13:10:33 +00:00

  • Relates set to 9040

@icinga-migration
Copy link
Author

Updated by mjentsch on 2015-07-21 12:00:55 +00:00

  • Assigned to set to mjentsch

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-07-28 13:34:25 +00:00

Build !#896 triggered by the commits 40d31d0, cbb9ef1, 8dbd671, f2d253f passed successfully.

Branch: origin/master
Author: Matthias Jentsch

@icinga-migration
Copy link
Author

Updated by mjentsch on 2015-07-28 13:35:05 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 40d31d0.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-07-28 14:33:44 +00:00

  • Status changed from Resolved to Assigned
  • Done % changed from 100 to 0

lippser wrote:

The hostgroups and servicegroups overviews do not even select the row.

In addition the downtime overview loses selection when refreshing the container manually.

Before marking this issue as fixed again please test:

  • Whether all list views use selection CSS
  • Whether a browser page refresh keeps selection
  • Whether a manual refresh of the container keeps selection

@icinga-migration
Copy link
Author

Updated by mjentsch on 2015-07-29 15:35:05 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 20aa17c.

@icinga-migration icinga-migration added bug Something isn't working area/ui Affects the user interface labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Affects the user interface bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant