[dev.icinga.com #8543] Misconfigured instances throw exceptions without a message

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/8543

Created by ulf.kosack on 2015-02-25 19:19:07 +00:00

Assignee: elippmann
Status: Resolved (closed on 2015-03-13 02:45:03 +00:00)
Target Version: 2.0.0-beta3
Last Update: 2015-03-13 02:45:03 +00:00 (in Redmine)

---

Version: 8d67437

Hi,

When i select multiple services and doing an action (eg. setting a downtime or ack), i get an error. However, the action is applied to one of the selected services.

Request URL: http://host.example/icingaweb/monitoring/services/schedule-downtime?((service=lx-ntp&host=hostname)|(service=lx-procs%20all&host=hostname))
Request Method:POST
Status Code:500 Internal Server Error

Response:


Server error: 


  


#0 /var/www/icingaweb2/modules/monitoring/library/Monitoring/Command/Transport/CommandTransport.php(109): Icinga\Module\Monitoring\Command\Transport\CommandTransport::fromConfig(Object(Icinga\Data\ConfigObject))

#1 /var/www/icingaweb2/modules/monitoring/application/forms/Command/CommandForm.php(70): Icinga\Module\Monitoring\Command\Transport\CommandTransport::first()
#2 /var/www/icingaweb2/modules/monitoring/application/forms/Command/Object/ScheduleServiceDowntimeCommandForm.php(199): Icinga\Module\Monitoring\Forms\Command\CommandForm->getTransport(Object(Icinga\Web\Request))
#3 /var/www/icingaweb2/modules/monitoring/application/forms/Command/Object/ScheduleServiceDowntimeCommandForm.php(212): Icinga\Module\Monitoring\Forms\Command\Object\ScheduleServiceDowntimeCommandForm->scheduleDowntime(Object(Icinga\Module\Monitoring\Command\Object\ScheduleServiceDowntimeCommand), Object(Icinga\Web\Request))
#4 /var/www/icingaweb2/library/Icinga/Web/Form.php(610): Icinga\Module\Monitoring\Forms\Command\Object\ScheduleServiceDowntimeCommandForm->onSuccess()
#5 /var/www/icingaweb2/modules/monitoring/application/controllers/ServicesController.php(38): Icinga\Web\Form->handleRequest()
#6 /var/www/icingaweb2/modules/monitoring/application/controllers/ServicesController.php(182): Monitoring_ServicesController->handleCommandForm(Object(Icinga\Module\Monitoring\Forms\Command\Object\ScheduleServiceDowntimeCommandForm))
#7 /var/www/icingaweb2/library/vendor/Zend/Controller/Action.php(507): Monitoring_ServicesController->scheduleDowntimeAction()
#8 /var/www/icingaweb2/library/vendor/Zend/Controller/Dispatcher/Standard.php(303): Zend_Controller_Action->dispatch('scheduleDowntim...')
#9 /var/www/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Zend_Controller_Dispatcher_Standard->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#10 /var/www/icingaweb2/library/Icinga/Application/Web.php(159): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#11 /var/www/icingaweb2/library/Icinga/Application/webrouter.php(112): Icinga\Application\Web->dispatch()
#12 /var/www/icingaweb2/public/index.php(5): require_once('/var/www/icinga...')
#13 {main}

Error is in still alive in v2.0.0-beta2 URL: http://webserver/icingaweb2/monitoring/services/schedule-downtime?%28%28service=apt&host=server005.domain.tld%29|%28service=apt&host=server007.domain.tld%29|%28service=apt&host=server004.domain.tld%29|%28service=apt&host=server009.domain.tld%29%29

#0 /usr/share/icingaweb2/modules/monitoring/library/Monitoring/Command/Transport/CommandTransport.php(108): Icinga\Module\Monitoring\Command\Transport\CommandTransport::fromConfig(Object(Icinga\Data\ConfigObject))
#1 /usr/share/icingaweb2/modules/monitoring/application/forms/Command/CommandForm.php(69): Icinga\Module\Monitoring\Command\Transport\CommandTransport::first()
#2 /usr/share/icingaweb2/modules/monitoring/application/forms/Command/Object/ScheduleServiceDowntimeCommandForm.php(194): Icinga\Module\Monitoring\Forms\Command\CommandForm->getTransport(Object(Icinga\Web\Request))
#3 /usr/share/icingaweb2/modules/monitoring/application/forms/Command/Object/ScheduleServiceDowntimeCommandForm.php(207): Icinga\Module\Monitoring\Forms\Command\Object\ScheduleServiceDowntimeCommandForm->scheduleDowntime(Object(Icinga\Module\Monitoring\Command\Object\ScheduleServiceDowntimeCommand), Object(Icinga\Web\Request))
#4 /usr/share/icingaweb2/library/Icinga/Web/Form.php(627): Icinga\Module\Monitoring\Forms\Command\Object\ScheduleServiceDowntimeCommandForm->onSuccess()
#5 /usr/share/icingaweb2/modules/monitoring/application/controllers/ServicesController.php(49): Icinga\Web\Form->handleRequest()
#6 /usr/share/icingaweb2/modules/monitoring/application/controllers/ServicesController.php(246): Monitoring_ServicesController->handleCommandForm(Object(Icinga\Module\Monitoring\Forms\Command\Object\ScheduleServiceDowntimeCommandForm))
#7 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action.php(507): Monitoring_ServicesController->scheduleDowntimeAction()
#8 /usr/share/icingaweb2/library/vendor/Zend/Controller/Dispatcher/Standard.php(303): Zend_Controller_Action->dispatch('scheduleDowntim...')
#9 /usr/share/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Zend_Controller_Dispatcher_Standard->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#10 /usr/share/icingaweb2/library/Icinga/Application/Web.php(158): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#11 /usr/share/icingaweb2/library/Icinga/Application/webrouter.php(111): Icinga\Application\Web->dispatch()
#12 /usr/share/icingaweb2/public/index.php(4): require_once('/usr/share/icin...')
#13 {main}

Changesets

2015-03-06 11:31:34 +00:00 by mjentsch 7153436

Implement new layout for host multi-view

refs #8543

2015-03-13 02:41:33 +00:00 by elippmann 32487e4

Ignore settings from instances.ini that don't have a setter on the transport class used

fixes #8543

---

Relations:

• relates #8543
• relates #8348
• copied_to #8543

[icinga-migration]

Updated by ulf.kosack on 2015-02-25 19:19:08 +00:00

• Copied From set to 7734

[icinga-migration]

Updated by tgelf on 2015-03-02 09:21:17 +00:00

• Relates set to 8565

[icinga-migration]

Updated by tgelf on 2015-03-02 11:25:26 +00:00

• Relates set to 8348

[icinga-migration]

Updated by elippmann on 2015-03-13 02:40:42 +00:00

• Subject changed from Action on multiple services generates an error to Misconfigured instances throw exceptions without a message
• Category set to Monitoring
• Status changed from New to Assigned
• Assigned to set to elippmann
• Target Version set to 2.0.0-beta3

Hi,

I think your instances.ini is invalid as it contains settings the code does not expect and thus throws an exception. This is of course stupid because we don't tell you what's wrong. I'll remove the exception throwing and just swallow any setting found in the instances.ini that is not reflected by our code. If any setting is missing an exception with proper details should be thrown.

Cheers,
Eric

[icinga-migration]

Updated by icinga-kanban on 2015-03-13 02:44:32 +00:00

Build !#644 triggered by commit 32487e4 passed successfully.

Branch: origin/master
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2015-03-13 02:45:03 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 32487e4.