Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #7998] Navigating to the Services-Tab in the Service-Detail-View displays only the selected service #1257

Closed
icinga-migration opened this issue Dec 4, 2014 · 16 comments
Labels
area/monitoring Affects the monitoring module bug Something isn't working queue/important Blocks a release or needs immediate attention
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/7998

Created by jmeyer on 2014-12-04 15:16:27 +00:00

Assignee: jmeyer
Status: Resolved (closed on 2015-06-16 15:49:28 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-06-16 18:10:40 +00:00 (in Redmine)


Steps to reproduce:

  • Open any service in the Detail-View
  • Navigate to the Services-Tab
  • You should see only the service you've selected previously even though there are way more services counted in the badges above

Attachments

Changesets

2015-05-28 10:22:57 +00:00 by elippmann 646cffd

monitoring: Remove the services tab when showing host or service details

refs #7998

2015-05-28 10:24:00 +00:00 by elippmann b3e0851

monitoring: Remove the services tab when showing an object's history

refs #7998

2015-05-28 10:25:31 +00:00 by elippmann 8dbb215

monitoring: Remove services action from the ShowController

refs #7998

2015-05-28 10:26:22 +00:00 by elippmann e0fe644

monitoring: Show host's services in the next container

refs #7998

2015-06-01 15:21:11 +00:00 by elippmann fa1a5c6

monitoring: Open links of a host's service summary in the next container

refs #7998

2015-06-02 08:06:54 +00:00 by elippmann 0ce2227

monitoring: Don't add class active to followed links of a host's service summary

The links now open in the next container. Managing active state of followed links is not yet possible.

refs #7998

2015-06-02 08:07:13 +00:00 by elippmann c01512d

monitoring: Fix link to unhandled services of a host

refs #7998

2015-06-02 08:07:43 +00:00 by elippmann 2da45d2

monitoring: Fix link to a host's services in the service grid

refs #7998

2015-06-05 13:28:39 +00:00 by elippmann 3e29046

Merge branch 'bugfix/monitoring-remove-services-tab-7998'

fixes #7998

Relations:

@icinga-migration
Copy link
Author

Updated by jmeyer on 2014-12-09 14:48:13 +00:00

  • Duplicated set to 8036

@icinga-migration
Copy link
Author

Updated by jmeyer on 2014-12-11 16:22:02 +00:00

  • Relates set to 7997

@icinga-migration
Copy link
Author

Updated by jmeyer on 2014-12-11 16:32:48 +00:00

This is directly related to #7997. The way how we generate our tabs in the detail view causes these issues to occur. Fixing this issue pretty straightforward by adjusting the URL parameters causes a similar issue to occur as described in #7997.

I suspect we need some way to "remember" where we were previously (without interfering with filters) when a user is navigating using these tabs.

The only valid solution that i can think of is to pass a `from' or `origin' parameter to each tab that does not require a specific service (Host, Services). This way we know that the history should refer to a service and that a "Service"-Tab is required, after the user clicked on the "Host" or "Service"-Tab.

Does someone has a better solution?

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-02-03 16:05:36 +00:00

  • Target Version changed from 2.0.0-beta2 to Backlog

We'll fix this asap after releasing Beta 2.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-03-04 06:53:32 +00:00

Is there any news on this? :)

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 10:21:09 +00:00

  • Target Version changed from Backlog to 2.0.0-rc1

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-31 07:33:41 +00:00

  • Relates set to 6156

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-06-02 07:40:55 +00:00

  • Duplicated set to 9304

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-06-02 07:45:48 +00:00

  • Duplicated set to 9282

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-06-02 08:09:13 +00:00

Build !#710 triggered by commit 2da45d2 passed successfully.

Branch: origin/bugfix/monitoring-remove-services-tab-7998
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-06-05 13:29:56 +00:00

Build !#734 triggered by the commits 11a0066, 5dd3950, 1a0d170, 916a265, dd7cbf4, e7a875d, ab129d0, 1988342, 1e8151b, ff01ee4, 8e35bb4, 5f898a3, a5c3782, 28a28a8, 06fb6ff, 267e71f, 7213379, 00c31ff, cd0c418, 5d50eab, ae30a62, 2490d0a, 8875ce7, 9bd5d41, cf96e66, 3fffd90, a558f28, 46e2393, cf95994, 9b4f3c9, 34edf87, 4496826, 7b9983d, 6661d49, 4c6a2b4, 17e7f1e, 66fd7df, 49bb09d, 1901f0a, c7ce149, 80e4e41, e936c76, 1385295, 62fff94, beb5bd7, 4bd36bc, 89311f9, 601b720, 29cc92a, d1a5321, 7127d5e, d097f7f, ea959c2, 04835db, cb4d6f0, c8e8a39, cc77902, b82d7d7, 3959dc2, a88037f, bb285db, 60ce78c, c94e6a3, 9fcebb0, b123afe, 5e0ae64, 068bfc0, 9f155ea, 2c9af2f, ad6b401, 385042e, 70d98f3, a4a1a29, 1a51368, 8309ab3, c7261bd, a298197, 32b99be, eb5c48a, 3b601de, 2572842, 60e5608, 1c6ded9, a669491, 1950ddc, 37f58e5, fd931e4, d7bdc59, 08f8fe6, 119b2fd, 58d78f5, 5326ce6, 647dd9d, 5fdaa2c, 1bfbce9, 31400ea, 124173f, 8b07a0e, c2d7f05, a304645, bd5d6e9, 903b02a, 701fd81, 6c44f6a, cba36ec, cbf37bf, 23b7ab0, e55d434, 8713f59, d157dec, 1517c72, 0c9bac0, b58cd47, fd2ecf3, e31c99b, 0e37aad, 01b790c, 88ba718, 2cbea55, 32c1a84, 170379b, 45fd1b7, adc2d33, 676d209, e0f0fbf, 02afa9f, a75c74e, 6e382bd, 237b50f, 899a00e, 86146b8, 75c5aa2, e2c250c, 2164fcf, a4f38f2, 20f0b46, ec556ed, 54354b1, f3124ff, 18e413d, 88f5bb8, e5819ef, 5c6d5f5, 705bb66, 030db8c, 4f0b4e5, 59ff422, 2657254, 0686bc1, fac2ebc, 4833ff1, 10b158a, 4d79731, ba31be9, 9278d70, 6369643, ed166d6, 94cd4b9, 2cec4a6, 9891dc4, 9fdcada, 4a48997, 66611d4, f86a05e, fecf7a5, 539b824, 9c6a889, 0dda19d, bd07f78, 605ae3d, 32d1569, 8ea3cd0, 7dff1ca, 71fa736, 0938576, a3d5cfc, fb07f0b, f305a33, cf989a0, a1276fd, 7b6ca08, 9af25ac, 0e0341f, 742dfca, be36809, 3f25cf5, d39c697, 7a6837d, 524c449, 130fea3, 9eaa231, 07a5473, 5db6fc9, 8927121, e9fee2d, 0a38757, f93c2de, 223ecab, 47dfcf5, 7d98206, d5d0c67, 104c1c6, 7d08dd2, aa466ae, a9f0fd0, 2e0a444, c91d3e5, 053c9cd, 399bbf0, 44bbd93, b3957c5, ca166b0, 3aaa6d3, 30bc1db, f1c82fc, 59ec11f, 6ef4bbe, 8690056, 2c1fac9, 84f20ec, 12ff708, 938da80, 5ace0a0, 1e1b954, f383ddd, f83d16a, eac5e39, 99be358, ba4330d, 4d83b2f, 16a7b01, 4044e56, 108f551, cfa9176, 7b2ed3b, f2ad283, d63381c, 9c799dc, b1cbc14, f1f1710, e228404, 8902930, 5cc7f26, de68d78, 37e47f0, 1682b0e, 58233b0, b1454c1, 7b2fc1b, 8cf0c29, bd136d3, d71df6a, 271e350, d171dd2, d0a353c, 3e8ef5c, f9089c3, 842b043, b86a002, 9163fb0, 100d475, 437090d, c441117, e74194c, 99ac0b7, 7b41fc0, 1824eb9, 68657c0, 870e75c, fa1906e, 3b93b84, 7b7a7c9, 6612e4c, 6640175, 5baa059, 9921343, 7178026, ecd059d, e7789ed, ca5ef2d, d09ea28, 3da144f, adae7b3, 7960e91, a2cd5d6, a1d8ed6, c9dcddb, 847c02e, 33628cb, b45e576, 97caeb2, 319ca36, 60a8654, 11f522d, a7af546, 6ca68f4, 39473e8, b51ce9c, 8058eb0 passed successfully.

Branch: origin/bugfix/monitoring-remove-services-tab-7998
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-06-05 13:30:03 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 3e29046.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-06-15 14:30:21 +00:00

  • File added Auswahl_215.png
  • File added Auswahl_217.png

Removing the services tab for fixing that problem seems wrong to me. It introduces a usability problem as well.

Consider the old version, where you've opened a host inside the detail view. You'll navigate from the host detail to all services for this host. Everything happens inside the "tabs" and you'll know your "click ways" when navigating (I guess it is the same with accessibility).

Auswahl_215.png

Looking at the most recent change in removing the services tab, you'll know have to know that you may click inside the host's detail on "X configured services" to navigate into a new "virtual" services tab inside the detail view.

Auswahl_217.png

From my point of view this complicates the "flow" how details and tabs work together, and removes a fairly used and common feature from inside the detail view. Please consider reverting this removal and implement a different fix for the initial filtering/history problem. Thanks.

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-06-15 22:08:26 +00:00

  • Status changed from Resolved to Feedback
  • Priority changed from Normal to High

A lot of existing web2 users got confused by this, we should re-evaluate this change.

Cheers,
Thomas

@icinga-migration
Copy link
Author

Updated by jmeyer on 2015-06-16 15:49:28 +00:00

  • Status changed from Feedback to Resolved
  • Assigned to set to jmeyer

I've restored the "Services" tab but kept how the service summary's links are being opened (in the next column) and fixed the issue that only one service is displayed when coming from a service and clicking on the "Services" tab. This works because the "Services" tab is not filterable (anymore).

Fixed in the current master.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-06-16 18:10:40 +00:00

  • File added Auswahl_052.png

Yay, my hero, thank you! :-)

Auswahl_052.png

@icinga-migration icinga-migration added queue/important Blocks a release or needs immediate attention bug Something isn't working area/monitoring Affects the monitoring module labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.0-rc1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Affects the monitoring module bug Something isn't working queue/important Blocks a release or needs immediate attention
Projects
None yet
Development

No branches or pull requests

1 participant