[dev.icinga.com #7209] ITL: Interfacetable

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/7209

Created by dgoetz on 2014-09-15 13:39:14 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2015-02-18 14:44:35 +00:00)
Target Version: 2.3.0
Last Update: 2015-02-18 14:44:35 +00:00 (in Redmine)

---

Attached find a conf file to include in ITL and the corresponding md file for the docs for interfacetable_v3t (http://www.tontonitch.com/tiki/tiki-index.php?page=Nagios+plugins+-+interfacetable\_v3t).

Will send a note to the plugin developer, too.

Attachments

• interfacetable.conf dgoetz - 2014-09-15 13:34:54 +00:00 - Configuration-File to include
• interfacetable.md dgoetz - 2014-09-15 13:35:12 +00:00 - Markdown for docs
• 0001-Adds-contributed-command-definitions.patch dgoetz - 2015-02-09 13:34:16 +00:00
• 0001-Adds-contributed-command-definitions.patch dgoetz - 2015-02-09 14:04:13 +00:00
• 0001-Adds-contributed-command-definitions.patch dgoetz - 2015-02-18 12:32:02 +00:00
• 0001-Adds-contributed-command-definitions.patch dgoetz - 2015-02-18 14:35:46 +00:00

Changesets

2015-02-18 14:43:27 +00:00 by dgoetz 7f368c0

Add contributed command definitions

fixes #7209
fixes #7292
fixes #7294

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>

2015-02-21 09:51:58 +00:00 by mfriedrich aef2513

Doc: Fix html anchors for contrib plugins

refs #7209
refs #7292
refs #7294

2015-02-24 15:36:05 +00:00 by (unknown) 2a076e8

Remove leading slash and extra blank line in constants.conf.cmake

refs #7209

---

Relations:

• relates #7294
• relates #7292

[icinga-migration]

Updated by mfriedrich on 2015-02-09 09:54:58 +00:00

• Assigned to set to dgoetz

[icinga-migration]

Updated by dgoetz on 2015-02-09 13:34:41 +00:00

• File added 0001-Adds-contributed-command-definitions.patch

After discussing this offline we decide to create an own contribution tree for these plugins. Path adds also the other plugins I have already filed feature requests.

I hope I have included all necessary documentation.

[icinga-migration]

Updated by dgoetz on 2015-02-09 14:05:01 +00:00

• File added 0001-Adds-contributed-command-definitions.patch

Shortend the name to plugins-contrib and PluginsContribDir.

[icinga-migration]

Updated by gbeutner on 2015-02-10 15:41:14 +00:00

• Status changed from New to Assigned

Hi,

I've reviewed the patch. There are still a few minor problems:

a) We're using tabs to indent the ITL files.
b) Some of the ITL files are missing the license header.

[icinga-migration]

Updated by gbeutner on 2015-02-13 09:59:46 +00:00

• Assigned to changed from dgoetz to gbeutner
• Target Version set to 2.3.0
• Estimated Hours set to 2

[icinga-migration]

Updated by gbeutner on 2015-02-13 09:59:58 +00:00

• Relates set to 7294

[icinga-migration]

Updated by gbeutner on 2015-02-13 10:00:09 +00:00

• Relates set to 7292

[icinga-migration]

Updated by dgoetz on 2015-02-18 12:33:38 +00:00

• File added 0001-Adds-contributed-command-definitions.patch

Can you have a look if now everything is fine?

I changed on your and Michaels feedback:

• Changed indent to tab
• Added the license header to the files in plugins-contrib.d
• Fixed CMakeLists.txt

[icinga-migration]

Updated by gbeutner on 2015-02-18 14:29:27 +00:00

The patch doesn't apply against the current master:

acheron:icinga2 gunnar$ git am ~/Downloads/0001-Adds-contributed-command-definitions.patch
Applying: Adds contributed command definitions
/Users/gunnar/icinga2/.git/rebase-apply/patch:29: trailing whitespace.
The Plugins contrib collects various contributed command definitions. 
/Users/gunnar/icinga2/.git/rebase-apply/patch:71: trailing whitespace.
interfacetable_maxrepetitions       | **Optional.** Increasing this value may enhance snmp query performances by gathering more results at one time. 
/Users/gunnar/icinga2/.git/rebase-apply/patch:120: trailing whitespace.
mem_cache    | **Optional.** If set to true plugin will count cache as free memory. Defaults to "false". 
error: doc/6-icinga-template-library.md: does not exist in index
/Users/gunnar/icinga2/.git/rebase-apply/patch:551: new blank line at EOF.
+
/Users/gunnar/icinga2/.git/rebase-apply/patch:609: new blank line at EOF.
+
Patch failed at 0001 Adds contributed command definitions
The copy of the patch that failed is found in:
   /Users/gunnar/icinga2/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
acheron:icinga2 gunnar$ 

[icinga-migration]

Updated by dgoetz on 2015-02-18 14:36:39 +00:00

• File added 0001-Adds-contributed-command-definitions.patch

Rebased for doc changed from 6-icinga-template-library.md to 7-icinga-template-library.md

[icinga-migration]

Updated by gbeutner on 2015-02-18 14:41:20 +00:00

Ok, a few more things I did before merging the patch:

1. Fixed whitespace errors.
2. Replaced "true"/"false" with true/false (no quotes).

[icinga-migration]

Updated by dgoetz on 2015-02-18 14:44:35 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 7f368c0.