[dev.icinga.com #7044] icinga2 init-script terminates with exit code 0 if $DAEMON is not in place or not executable

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/7044

Created by mhoyer on 2014-09-01 13:16:27 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2014-09-02 11:45:03 +00:00)
Target Version: 2.1.1
Last Update: 2014-09-02 11:45:03 +00:00 (in Redmine)

Icinga Version: 2.0.2

---

The icinga2 init-script checks if the binary ($DAEMON) is in place and executable, following an exit 0 if it is not. This seems bad as if it doesn't follow LSB rules for non-status init-script actions. It should terminate with exit-code 1 or something more specific. See http://fedoraproject.org/wiki/Packaging:SysVInitScript#Exit\_Codes\_for\_non-Status\_Actions for details.

/etc/init.d/icinga2
line 27: test -x $DAEMON || exit 0

Changesets

2014-09-02 11:40:33 +00:00 by gbeutner dde00a3

Use LSB-compliant exit codes for the init script

fixes #7044

[icinga-migration]

Updated by gbeutner on 2014-09-02 11:42:08 +00:00

• Assigned to set to gbeutner
• Target Version set to 2.1.1
• Estimated Hours set to 0.2

[icinga-migration]

Updated by gbeutner on 2014-09-02 11:45:03 +00:00

• Status changed from New to Resolved
• Done % changed from 0 to 100

Applied in changeset dde00a3.