[dev.icinga.com #6933] Logging config tab changes

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6933

Created by tgelf on 2014-08-15 13:25:56 +00:00

Assignee: elippmann
Status: Resolved (closed on 2014-10-16 14:16:09 +00:00)
Target Version: 2.0-15
Last Update: 2014-10-16 14:16:09 +00:00 (in Redmine)

---

We already removed a couple of config settings. I'd suggest to move logging config to "application", that's one tab less. And if we add a "none" log level we could drop "enabled". We might think about adding a umask setting for file-based logging.

Cheers,
Thomas

Changesets

2014-08-22 09:05:20 +00:00 by jmeyer bc05d2e

Merge LoggingForm into GeneralForm

fixes #6933

2014-08-22 10:34:33 +00:00 by jmeyer 403f745

Remove obsolete loggingAction

refs #6933

2014-10-17 11:05:56 +00:00 by jmeyer 24b6274

Fix logging configuration installation

refs #7163
refs #6933

[icinga-migration]

Updated by jmeyer on 2014-08-22 07:34:29 +00:00

• Category set to 146
• Status changed from New to Assigned
• Assigned to set to jmeyer
• Target Version set to 2.0-12

[icinga-migration]

Updated by jmeyer on 2014-08-22 10:31:08 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset bc05d2e.

[icinga-migration]

Updated by elippmann on 2014-09-01 12:37:46 +00:00

• Status changed from Resolved to Feedback
• Assigned to changed from jmeyer to tgelf

Hi Tom,

tgelf wrote:

We already removed a couple of config settings. I'd suggest to move logging config to "application", that's one tab less. And if we add a "none" log level we could drop "enabled". We might think about adding a umask setting for file-based logging.

Cheers,
Thomas

I reopen this bug because adding a "none" log level makes no sense. At least it makes no sense how it's implemented right now: If I want to disable logging, I must chose between file or syslog before being able to disable logging. For the file part, I must additionally configure a valid file path before being able to disable logging. Of course we can check the log level first and add a "NullWriter" in case it's "none". But since having a setting "disabled" is easier to document and does not require us to implement a "NullWriter", I opt for reverting this particular change and rename the "enable" setting to "disabled". Thoughts?

Cheers,
Eric

[icinga-migration]

Updated by elippmann on 2014-09-15 07:41:32 +00:00

• Target Version changed from 2.0-12 to 2.0-15

[icinga-migration]

Updated by elippmann on 2014-10-16 14:16:10 +00:00

• Status changed from Feedback to Resolved
• Assigned to changed from tgelf to elippmann

I renamed 'type' to 'log' and added support for defining 'none' here.