New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #6842] Deduplicate Puppet code #888
Comments
Updated by mfriedrich on 2014-08-04 11:35:33 +00:00 You may use existing classes from the icinga-vagrant repository, especially icinga2x and icinga2x-cluster. Those puppet modules and manifests still require some cleanup, but they may serve as refactoring example/help. |
Updated by mfriedrich on 2014-08-13 15:53:44 +00:00 Please revert 7286245 - that's just overwriting the existing git history and doesn't help much. |
Updated by icinga-kanban on 2014-08-14 13:16:15 +00:00 Build !#1757 triggered by the commits 699f4e3, 7286245, 392e725, 05afbee, a110b25, 73a29ab, 2e1afd7, 920a784, 538088d, ee71167, 9a50cb8, ccbc1f5, e42f400, fe11ca4, 82fa6e6, 8f23f61, 261a5dd, 8806583 failed. Branch: origin/master |
Updated by icinga-kanban on 2014-08-18 10:08:40 +00:00 Build !#1762 triggered by the commits 67efe52, 0677105, 2245989, 26205a7, f2ed813, 4ddc0e7, dc8181c, 666591b, b5d6481, 57db6e4, 9dabc6d, 7958a81, 143db97, d813bad, 9692548, 8f729bf, 51484eb, 3e4944c, 56a2935, e2c761a, 294728a, 0b1aee8, 64954e9, 8f85a66, d05e3bf, 8b9d446 failed. Branch: origin/feature/deduplicate-puppet-code-6842 |
Updated by elippmann on 2014-08-22 10:58:33 +00:00
|
Updated by elippmann on 2014-08-22 10:58:51 +00:00
|
Updated by icinga-kanban on 2014-10-21 10:29:22 +00:00 Build !#129 triggered by the commits e27724c, a4c4f50, 8222606, c2a3770, 81d49db, 3c10d47, 1bb3a58, 424cee6, 2b67683, aa56f30, d170cf0, d1228de, 79ade94, cee261b, 53608c8, a2e1663 passed successfully. Branch: origin/feature/deduplicate-puppet-code-6842 |
Updated by icinga-kanban on 2014-10-29 16:44:11 +00:00 Build !#157 triggered by the commits f3b4ec0, 39729c9, 2698516, eb9fe09, d9194c2, 5fc1f85, 8ee52f8, 319c5e7, e7ef182, 1cc1521, 6973492, 71e25f2, d04ecea, 99b00b7, 12cadb5, 38220af, f44b052, f68c591, ba12d7b passed successfully. Branch: origin/feature/deduplicate-puppet-code-6842 |
Updated by elippmann on 2014-11-20 09:46:58 +00:00
|
Updated by icinga-kanban on 2014-11-26 13:08:22 +00:00 Build !#321 triggered by the commits fb6b2a7, 003567f, a3fa31c, ca1dafe, d25a3a1, e82cc35, ff19696, 1502b48, 3c16db3, 9aa2f6f, bc339e9, d226126, 381b3b9, 0a1668a, 2f02ac2, e5d8fc7, 974357c, f0ece3d, df42eba, d41602a, a288535 failed. Branch: origin/feature/deduplicate-puppet-code-6842 |
Updated by icinga-kanban on 2014-12-15 11:39:40 +00:00 Build !#343 triggered by the commits 575b677, 60b8529, 57fdee3, 11111b0, 02044d6, 3a3c573, 6cb6054, 44d662c, ca24699, 2e8f30d, 5cc5122, d835fe6, 50e23a3, 00d3110, e1c35c4, ada0b8c, c54ab12, 3d54087, dcbf8c5, 37ad4f7, f8c4685, b58607c, fb32fba, efe7044, 088455a, cfe2242, e786a7a, ec06239, 6974b18, 33e25fd, 15d2414, 4ea178e, efa7909, b7c555a, 099fefd, cdbb7e2, cee5fb5, 581e009, 023b3c5, 275976c, 9b6c90b, 4e8595f, 89c4bb4, a087bc8, cccab1d, bf68ecf, 513fbe6, 9446117, 06fe3bc, 83b1cde, 8b59276, aea29fb, 9d7f3bd, 196b6a4, b214ed5, de0653e, 550bb7d, f94646e, 571df0a, f0b4708, b099c28, 09e59ba, cddb68b, 8d8b654, 8150cd7, f3df8db, a2a9753, eab5422, ec6850a, bb0073e, 2a3d7b8, b6ee903, ebf908b, 2b14dba, 7a243a0, 2b2b289, 625fa4d, ecc49d3, 0b3e306, badad1d failed. Branch: origin/feature/deduplicate-puppet-code-6842 |
Updated by icinga-kanban on 2014-12-15 12:42:46 +00:00 Build !#344 triggered by the commits 37b9aa3, 31a05c9, b307fe2, 1721936, 7987fb3, 87664ff, e63252c, 3a2fb03, cee6887, abfef2c, ddc121d, 60feed5, 8779e80, 73f9328, dc0f396, e0bec56, 429b16b failed. Branch: origin/feature/deduplicate-puppet-code-6842 |
Updated by elippmann on 2014-12-15 17:10:03 +00:00
Applied in changeset 08473ff. |
Updated by elippmann on 2015-03-30 09:23:10 +00:00
Backlog must not contain closed issues. |
This issue has been migrated from Redmine: https://dev.icinga.com/issues/6842
Created by aklimov on 2014-08-04 11:30:37 +00:00
Assignee: aklimov
Status: Resolved (closed on 2014-12-15 17:10:03 +00:00)
Target Version: (none)
Last Update: 2015-03-30 09:23:10 +00:00 (in Redmine)
Currently (
a4b7204e2397fcb66ac262f608b0dfa22be48cda
).vagrant-puppet/manifests/default.pp
has almost 800 lines of code.That's quite a lot and there's a lot of duplicated code.
It makes sense to outsource some parts into resource types and deduplicate the code that way.
Changesets
2014-08-04 11:40:11 +00:00 by aklimov 8806583
2014-08-05 12:42:01 +00:00 by aklimov e42f400
2014-08-05 13:15:01 +00:00 by aklimov ccbc1f5
2014-08-05 13:15:46 +00:00 by aklimov 9a50cb8
2014-08-05 13:20:43 +00:00 by aklimov ee71167
2014-08-05 13:43:23 +00:00 by aklimov 920a784
2014-08-05 14:12:47 +00:00 by aklimov 2e1afd7
2014-08-05 14:16:05 +00:00 by aklimov 73a29ab
2014-08-05 14:29:02 +00:00 by aklimov a110b25
2014-08-05 14:29:44 +00:00 by aklimov 05afbee
2014-08-06 11:27:16 +00:00 by aklimov 392e725
2014-08-15 09:10:47 +00:00 by aklimov 26205a7
2014-08-15 11:10:38 +00:00 by aklimov 0677105
2014-08-22 11:37:27 +00:00 by aklimov 5a6995f
2014-08-22 11:45:47 +00:00 by aklimov aa03011
2014-08-22 13:45:44 +00:00 by aklimov ee9f87b
2014-08-22 15:32:34 +00:00 by aklimov 9913382
2014-08-28 10:37:06 +00:00 by aklimov 42a564d
2014-08-28 10:38:52 +00:00 by aklimov 75ea243
2014-08-28 11:08:42 +00:00 by aklimov f6a9c67
2014-08-28 11:33:47 +00:00 by aklimov e963479
2014-08-28 11:49:50 +00:00 by aklimov 5c0f998
2014-08-28 12:16:21 +00:00 by aklimov 5f97732
2014-08-28 12:24:18 +00:00 by aklimov 4dc1541
2014-08-28 12:35:06 +00:00 by aklimov 146f315
2014-08-28 12:54:22 +00:00 by aklimov f2fd9f1
2014-08-28 13:13:47 +00:00 by aklimov 3e5a0af
2014-08-28 14:17:54 +00:00 by aklimov 3d75d2e
2014-08-28 14:56:10 +00:00 by aklimov cc4907b
2014-08-29 08:25:36 +00:00 by aklimov f1d18c1
2014-08-29 09:43:09 +00:00 by aklimov 6c52b52
2014-08-29 09:46:15 +00:00 by aklimov c745b78
2014-09-01 12:24:29 +00:00 by aklimov d8c052c
2014-09-01 12:26:13 +00:00 by aklimov f7e6a0f
2014-09-01 12:35:45 +00:00 by aklimov d7f4d22
2014-09-01 12:53:58 +00:00 by aklimov 9ebf011
2014-09-01 13:07:08 +00:00 by aklimov 58c854d
2014-09-01 13:10:17 +00:00 by aklimov 4114e73
2014-09-01 13:13:18 +00:00 by aklimov 26132c4
2014-09-01 14:27:46 +00:00 by aklimov bec1b65
2014-09-02 10:11:36 +00:00 by aklimov 809b714
2014-09-02 10:17:39 +00:00 by aklimov e8dfbe6
2014-09-02 10:42:27 +00:00 by aklimov f3d2347
2014-09-02 10:49:29 +00:00 by aklimov 1b3c42f
2014-09-02 10:54:03 +00:00 by aklimov e31e6a8
2014-09-02 11:12:41 +00:00 by aklimov 62def40
2014-09-02 11:29:43 +00:00 by aklimov d602f82
2014-09-02 12:56:27 +00:00 by aklimov b2c3408
2014-09-02 13:08:21 +00:00 by aklimov 2de3af2
2014-09-02 13:30:51 +00:00 by aklimov b9fc261
2014-09-02 13:47:18 +00:00 by aklimov d3d64e3
2014-09-02 13:51:30 +00:00 by aklimov 96e98c8
2014-09-02 14:18:06 +00:00 by aklimov 65f3051
2014-09-02 14:19:33 +00:00 by aklimov 7b45e5c
2014-09-02 14:41:16 +00:00 by aklimov 4d32685
2014-09-08 10:24:28 +00:00 by aklimov 2c0d71a
2014-09-09 10:30:35 +00:00 by aklimov 4484a31
2014-09-09 10:32:21 +00:00 by aklimov be7bae8
2014-09-09 11:19:12 +00:00 by aklimov 77719be
2014-09-09 11:40:16 +00:00 by aklimov 6aa2dcd
2014-09-09 12:45:04 +00:00 by aklimov 7e4feb7
2014-09-09 12:48:55 +00:00 by aklimov 1e511a0
2014-09-09 13:15:53 +00:00 by aklimov 74b631e
2014-09-09 14:18:09 +00:00 by aklimov 858e7c2
2014-09-09 14:27:26 +00:00 by aklimov 0fbe072
2014-09-09 15:39:20 +00:00 by aklimov 8157339
2014-09-09 15:46:00 +00:00 by aklimov 07c4591
2014-09-09 16:00:26 +00:00 by aklimov 924a511
2014-09-10 08:04:27 +00:00 by aklimov 01807c2
2014-09-10 08:06:42 +00:00 by aklimov b076d9a
2014-09-10 08:09:40 +00:00 by aklimov d8eb253
2014-09-10 08:20:22 +00:00 by aklimov 645a2ec
2014-09-10 08:23:32 +00:00 by aklimov 9bb68c4
2014-09-10 09:01:49 +00:00 by aklimov be6c913
2014-09-10 09:05:13 +00:00 by aklimov 406f3ba
2014-09-10 09:14:55 +00:00 by aklimov 930416b
2014-09-10 09:24:15 +00:00 by aklimov 260ec95
2014-09-10 09:27:28 +00:00 by aklimov a33042b
2014-09-10 09:38:10 +00:00 by aklimov 5e3f60d
2014-09-10 09:45:57 +00:00 by aklimov d61e883
2014-09-10 09:48:14 +00:00 by aklimov 65a65ae
2014-09-10 10:04:16 +00:00 by aklimov a7378bd
2014-09-10 10:48:22 +00:00 by aklimov 2576a3b
2014-09-10 11:57:37 +00:00 by aklimov 203dddb
2014-09-10 12:10:30 +00:00 by aklimov a99dbab
2014-09-10 12:38:18 +00:00 by aklimov e124a42
2014-09-10 12:59:44 +00:00 by aklimov 4008b86
2014-09-10 13:14:14 +00:00 by aklimov a5b3601
2014-09-10 13:36:42 +00:00 by aklimov 4a2259a
2014-09-10 14:58:06 +00:00 by aklimov a82bafc
2014-09-10 15:02:36 +00:00 by aklimov 9f1d69b
2014-09-10 15:19:43 +00:00 by aklimov de4380e
2014-09-10 15:49:17 +00:00 by aklimov 4136342
2014-09-10 16:02:00 +00:00 by aklimov 03100d0
2014-09-10 16:14:32 +00:00 by aklimov d5bfb3d
2014-09-10 16:27:27 +00:00 by aklimov e5ca8eb
2014-09-10 16:41:49 +00:00 by aklimov 0b1f318
2014-09-11 08:28:05 +00:00 by aklimov d22e251
2014-09-11 08:30:06 +00:00 by aklimov a4384b6
2014-09-11 08:47:01 +00:00 by aklimov 6b03f58
2014-09-11 09:17:51 +00:00 by aklimov cad539a
2014-09-11 09:30:24 +00:00 by aklimov 6b8c477
2014-09-11 09:53:20 +00:00 by aklimov 97f88fb
2014-09-11 10:10:18 +00:00 by aklimov 8ad9c7f
2014-09-11 13:59:00 +00:00 by aklimov b0b18d0
2014-09-11 14:00:46 +00:00 by aklimov e7fad2c
2014-09-11 14:45:10 +00:00 by aklimov a6c7fe2
2014-09-11 14:47:04 +00:00 by aklimov ab71049
2014-09-11 15:12:20 +00:00 by aklimov 8d001da
2014-09-11 15:12:20 +00:00 by aklimov 00b878f
2014-09-11 15:12:21 +00:00 by aklimov 5dd3e48
2014-09-11 15:21:08 +00:00 by aklimov 24613a0
2014-09-11 15:40:18 +00:00 by aklimov de7e9d6
2014-09-11 16:02:30 +00:00 by aklimov 6639b7b
2014-09-11 16:20:19 +00:00 by aklimov 549ea1e
2014-09-11 16:20:19 +00:00 by aklimov 58aa7e7
2014-09-11 16:20:20 +00:00 by aklimov 292c22d
2014-09-11 16:20:20 +00:00 by aklimov 31a3040
2014-09-11 16:20:21 +00:00 by aklimov 8850aa2
2014-09-11 16:26:32 +00:00 by aklimov 22d155b
2014-09-11 16:26:32 +00:00 by aklimov 8c00c6d
2014-09-11 16:26:33 +00:00 by aklimov 6db2e4e
2014-09-11 16:26:34 +00:00 by aklimov 0a2fbf4
2014-09-11 16:26:34 +00:00 by aklimov bb716e8
2014-09-11 16:26:54 +00:00 by aklimov eea9ee8
2014-09-11 17:12:02 +00:00 by aklimov c29eb0d
2014-09-12 08:55:12 +00:00 by aklimov fa85840
2014-09-12 09:42:09 +00:00 by aklimov 4a5acce
2014-09-12 09:51:10 +00:00 by aklimov 24c3a30
2014-09-12 11:23:44 +00:00 by aklimov 17db985
2014-09-12 16:59:20 +00:00 by aklimov ec9c174
2014-09-12 17:03:17 +00:00 by aklimov 1f547aa
2014-09-12 17:08:01 +00:00 by aklimov f5a232f
2014-09-15 09:16:47 +00:00 by aklimov d09e65b
2014-09-15 10:03:54 +00:00 by aklimov c573123
2014-09-15 10:03:54 +00:00 by aklimov 99f2abe
2014-09-15 10:03:55 +00:00 by aklimov 6a2dfb4
2014-09-15 10:12:21 +00:00 by aklimov d45f729
2014-09-15 11:09:44 +00:00 by aklimov b6671c8
2014-09-15 11:09:44 +00:00 by aklimov d7a0be7
2014-09-15 11:09:45 +00:00 by aklimov b6de74b
2014-09-15 11:35:14 +00:00 by aklimov 8fd3b94
2014-09-15 12:00:24 +00:00 by aklimov fbdeb77
2014-09-15 12:20:13 +00:00 by aklimov 5b1377e
2014-09-15 12:35:28 +00:00 by aklimov 616a955
2014-09-15 12:56:56 +00:00 by aklimov 72d74c1
2014-09-15 14:18:31 +00:00 by aklimov 8135cca
2014-09-15 14:19:07 +00:00 by aklimov eef13ea
2014-09-30 09:17:02 +00:00 by aklimov d87058c
2014-09-30 10:04:48 +00:00 by aklimov 7c6672f
2014-10-20 13:56:00 +00:00 by aklimov 3c10d47
2014-10-20 14:12:14 +00:00 by aklimov 81d49db
2014-10-21 10:19:32 +00:00 by aklimov 8222606
2014-10-21 10:22:17 +00:00 by aklimov a4c4f50
2014-10-30 11:56:30 +00:00 by aklimov b7691c6
2014-10-30 13:02:48 +00:00 by aklimov ba368f0
2014-10-30 15:57:17 +00:00 by aklimov 9471ced
2014-10-30 16:03:09 +00:00 by aklimov 38c9758
2014-10-30 16:25:41 +00:00 by aklimov 64445ae
2014-11-24 13:42:07 +00:00 by aklimov 30ee6c9
2014-11-24 13:44:17 +00:00 by aklimov 607b0fc
2014-12-10 09:33:48 +00:00 by elippmann aea29fb
2014-12-15 08:58:45 +00:00 by elippmann 275976c
2014-12-15 08:58:49 +00:00 by elippmann 023b3c5
2014-12-15 08:59:21 +00:00 by elippmann 581e009
2014-12-15 09:04:29 +00:00 by elippmann cee5fb5
2014-12-15 09:10:19 +00:00 by elippmann cdbb7e2
2014-12-15 09:11:00 +00:00 by elippmann 099fefd
2014-12-15 09:26:40 +00:00 by elippmann b7c555a
2014-12-15 09:51:21 +00:00 by elippmann efa7909
2014-12-15 09:51:59 +00:00 by elippmann 4ea178e
2014-12-15 09:52:36 +00:00 by elippmann 15d2414
2014-12-15 09:53:11 +00:00 by elippmann 33e25fd
2014-12-15 09:54:56 +00:00 by elippmann 6974b18
2014-12-15 09:55:17 +00:00 by elippmann ec06239
2014-12-15 09:57:46 +00:00 by elippmann e786a7a
2014-12-15 10:18:39 +00:00 by elippmann cfe2242
2014-12-15 10:31:34 +00:00 by elippmann 088455a
2014-12-15 10:32:02 +00:00 by elippmann efe7044
2014-12-15 10:33:36 +00:00 by elippmann fb32fba
2014-12-15 10:43:33 +00:00 by elippmann b58607c
2014-12-15 10:44:19 +00:00 by elippmann f8c4685
2014-12-15 11:11:41 +00:00 by elippmann 37ad4f7
2014-12-15 11:12:35 +00:00 by elippmann dcbf8c5
2014-12-15 11:13:26 +00:00 by elippmann 3d54087
2014-12-15 11:13:58 +00:00 by elippmann c54ab12
2014-12-15 11:14:30 +00:00 by elippmann ada0b8c
2014-12-15 11:16:17 +00:00 by elippmann e1c35c4
2014-12-15 11:16:36 +00:00 by elippmann 00d3110
2014-12-15 11:18:11 +00:00 by elippmann 50e23a3
2014-12-15 11:18:30 +00:00 by elippmann d835fe6
2014-12-15 11:18:48 +00:00 by elippmann 5cc5122
2014-12-15 11:19:11 +00:00 by elippmann 2e8f30d
2014-12-15 11:19:31 +00:00 by elippmann ca24699
2014-12-15 11:19:49 +00:00 by elippmann 44d662c
2014-12-15 11:20:15 +00:00 by elippmann 6cb6054
2014-12-15 11:20:43 +00:00 by elippmann 3a3c573
2014-12-15 11:22:27 +00:00 by elippmann 02044d6
2014-12-15 11:22:43 +00:00 by elippmann 11111b0
2014-12-15 11:23:00 +00:00 by elippmann 57fdee3
2014-12-15 11:25:11 +00:00 by elippmann 575b677
2014-12-15 12:40:33 +00:00 by elippmann 37b9aa3
2014-12-15 12:44:32 +00:00 by elippmann ea69b3f
2014-12-15 13:50:40 +00:00 by elippmann 379da5e
2014-12-15 17:00:01 +00:00 by elippmann 8dc61fc
2014-12-15 17:02:13 +00:00 by elippmann 56830cb
2014-12-15 17:03:10 +00:00 by elippmann 594d4d5
2014-12-15 17:03:51 +00:00 by elippmann 08473ff
Subtasks:
Relations:
The text was updated successfully, but these errors were encountered: