[dev.icinga.com #6709] Support for arrays in macros

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6709

Created by Frankstar on 2014-07-11 19:13:23 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2014-11-27 12:25:02 +00:00)
Target Version: 2.2.1
Last Update: 2014-11-27 12:25:02 +00:00 (in Redmine)

---

• Implement support for arrays in macros.
• Add option to repeat the argument key before each value

  vars.nrpe_command_args = [ "a1", "a2", "a3" ]

  arguments = {
    "-a" = "$nrpe_command_args$"
  }

  vars.disk_partitions = [ "/", "/var", "/tmp" ]

  arguments = {
    "-p" = {
      value = "$disk_partitions$"
      repeat_key = true //default false?
    }
  }

Changesets

2014-11-27 12:24:07 +00:00 by (unknown) 9dfa3d2

Implement support for arrays in command arguments

fixes #6709

2014-11-27 12:25:55 +00:00 by (unknown) 21dc94b

Implement support for arrays in command arguments

fixes #6709

---

Relations:

• relates #6225
• relates #6709
• relates #6709
• duplicates #6709
• duplicates #6709
• duplicates #6709

[icinga-migration]

Updated by Frankstar on 2014-07-11 19:16:12 +00:00

• Tracker changed from Bug to Feature

not a bug - more a feature

[icinga-migration]

Updated by mfriedrich on 2014-07-11 19:36:14 +00:00

• Subject changed from check_nrpe -a / nrpe_arguments Option deprecated to nrpe check command parameter "-a" missing

It's not deprecated because we don't own the nrpe project and therefore cannot do it. It just does not work properly with command arguments and shell escaping and has therefore been removed from the sample configuration (we don't ship broken commands).

And I wouldn't add it as for told reasons, Debian packages natively disable command arguments at compile time, and so do others removing that security hole.

[icinga-migration]

Updated by mfriedrich on 2014-07-12 15:19:10 +00:00

• Subject changed from nrpe check command parameter "-a" missing to Plugin Check Commands: nrpe parameter "-a" missing

[icinga-migration]

Updated by gbeutner on 2014-07-23 08:52:18 +00:00

The fact that the -a argument is missing right now has more to do with the fact that we just haven't had the time to add all arguments. Quite a few of the other commands are also missing some arguments.

Whether we should add the -a argument is another matter really and I'm not entirely sure about it.

[icinga-migration]

Updated by mfriedrich on 2014-08-12 14:36:06 +00:00

• Duplicated set to 6895

[icinga-migration]

Updated by mfriedrich on 2014-09-15 17:13:03 +00:00

http://www.monitoring-portal.org/wbb/index.php?page=Thread&postID=208479#post208479

[icinga-migration]

Updated by mfriedrich on 2014-09-16 09:12:54 +00:00

• Project changed from 37 to Icinga 2
• Category set to Plugins

[icinga-migration]

Updated by mfriedrich on 2014-11-25 09:17:07 +00:00

• Category changed from Plugins to libicinga
• Target Version set to 2.3.0

[icinga-migration]

Updated by mfriedrich on 2014-11-25 09:27:01 +00:00

• Subject changed from Plugin Check Commands: nrpe parameter "-a" missing to Support for arrays in macros
• Description updated

[icinga-migration]

Updated by mfriedrich on 2014-11-25 09:28:24 +00:00

• Duplicated set to 6781

[icinga-migration]

Updated by mfriedrich on 2014-11-25 09:29:14 +00:00

• Duplicated set to 6616

[icinga-migration]

Updated by mfriedrich on 2014-11-27 09:54:12 +00:00

• Relates set to 7867

[icinga-migration]

Updated by mfriedrich on 2014-11-27 09:54:37 +00:00

• Status changed from New to Assigned
• Assigned to set to gbeutner
• Target Version changed from 2.3.0 to 2.2.1

[icinga-migration]

Updated by mfriedrich on 2014-11-27 11:34:24 +00:00

Affected monitoring plugins:

repeat_key = true
-----------------
check_disk
-p [disk_partition]
-X (exclude) [disk_partition_excluded]

check_dns
-a (expected answers) [dns_expected_answer]

check_by_ssh
-C (multiple for passive mode. ) [by_ssh_command]

 To use passive mode, provide multiple '-C' options, and provide
 all of -O, -s, and -n options (servicelist order must match '-C'options)

repeat_key = false
------------------

check_nt
-l (params)  [nscp_params]

check_nrpe
-a (arg list) [nrpe_arguments]

 [arglist]  = Optional arguments that should be passed to the command.  Multiple
              arguments should be separated by a space.  If provided, this must be
              the last option supplied on the command line.

NEW

check_icmp
-H (host list) [icmp_hosts]

Usage:
 check_icmp [options] [-H] host1 host2 hostN

Options:
 -h, --help
    Print detailed help screen
 -V, --version
    Print version information
 --extra-opts=[section][@file]
    Read options from an ini file. See http://nagiosplugins.org/extra-opts
    for usage and examples.
 -H
    specify a target
 -w
    warning threshold (currently 200,000ms,40%)
 -c
    critical threshold (currently 500,000ms,80%)
 -s
    specify a source IP address or device name
 -n
    number of packets to send (currently 5)
 -i
    max packet interval (currently 80,000ms)
 -I
    max target interval (currently 0,000ms)
 -m
    number of alive hosts required for success
 -l
    TTL on outgoing packets (currently 0)
 -t
    timeout value (seconds, currently  10)
 -b
    Number of icmp data bytes to send
    Packet size will be data bytes + icmp header (currently 68 + 8)
 -v
    verbose

Notes:
 The -H switch is optional. Naming a host (or several) to check is not.

 Threshold format for -w and -c is 200.25,60% for 200.25 msec RTA and 60%
 packet loss.  The default values should work well for most users.
 You can specify different RTA factors using the standardized abbreviations
 us (microseconds), ms (milliseconds, default) or just plain s for seconds.

 The -v switch can be specified several times for increased verbosity.

[icinga-migration]

Updated by Anonymous on 2014-11-27 12:25:02 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 9dfa3d2.

[icinga-migration]

Updated by mfriedrich on 2014-11-27 12:29:18 +00:00

• Relates set to 7873