[dev.icinga.com #5818] SUSE packages #1338

icinga-migration · 2014-03-20T20:31:02Z

This issue has been migrated from Redmine: https://dev.icinga.com/issues/5818

Created by mfriedrich on 2014-03-20 20:31:02 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2014-07-30 12:30:05 +00:00)
Target Version: 2.0.2
Last Update: 2014-08-01 07:05:18 +00:00 (in Redmine)

Changesets

2014-07-11 07:07:00 +00:00 by theh 1b18479

Use modern GPL license tag

refs #5818

2014-07-11 07:08:44 +00:00 by theh 4bd9a50

Logrotate.conf doesn't need execution rights

refs #5818

2014-07-11 07:08:51 +00:00 by theh 7330e54

Add log directory to icinga2-common

RPMLint complains if logrotate is used without including the log directory in the package.

refs #5818

2014-07-11 07:08:58 +00:00 by theh cc27203

Don't copy INSTALL documentation to system docs

The INSTALL documentation is not relevant after installation, especially
if packages are used.

This does prevent a rpmlint warning.

refs #5818

2014-07-11 07:09:13 +00:00 by theh b4c61fc

Recommend logrotate in icinga2-common

Since we install a logrotate configuration file it does make sense to
at least recommend the installation of logrotate.
This addition is restricted to SUSE distributions since "Recommends"
is not supported elsewhere.

refs #5818

2014-07-11 07:09:19 +00:00 by theh 1e421cb

Description should be longer than the summary

This fixes a rpmlint warning.

refs #5818

2014-07-11 07:09:25 +00:00 by theh a640692

Remove .gitignore files from package

This commit can be reversed as soon as there are upgrade files in the
schema upgrade directories.

refs #5818

2014-07-11 07:09:32 +00:00 by theh 41c7160

Remove redundant requirements for SUSE distributions

refs #5818

2014-07-11 07:09:40 +00:00 by theh 89b2f21

Activate systemd on SUSE distributions

refs #5818

2014-07-11 07:09:45 +00:00 by theh e30a735

Reduce redunancies in spec file

Remove redundant differences between SUSE and RHEL distributions.

refs #5818

2014-07-11 07:09:52 +00:00 by theh e1289ca

Remove redundant mysql requirement

The mysql dependencies are recognized automatically during building.

refs #5818

2014-07-11 07:09:57 +00:00 by theh ce6b999

Remove obsolete pgsqllib require on SUSE distributions

refs #5818

2014-07-11 07:10:03 +00:00 by theh 7aeeaf3

Use root as default user and group to prevent issues

refs #5818

2014-07-11 07:10:08 +00:00 by theh 02ae8c9

Use permission verfication scripts on SUSE distributions

refs #5818

2014-07-11 07:10:14 +00:00 by theh 5490be7

Prevent empty icinga2 package by adding COPYING

Empty packages are not allowed on SLES11 and also produce a warning in
newer openSUSE releases.

So we just work around the issue by adding the COPYING file.

refs #5818

2014-07-11 07:11:34 +00:00 by theh c34d5bc

Use Github url as tarball source

This allows the automatic download of new versions.

refs #5818

2014-07-30 11:02:10 +00:00 by theh 0e4e237

Use modern GPL license tag

refs #5818

2014-07-30 11:02:10 +00:00 by theh c3a9251

Logrotate.conf doesn't need execution rights

refs #5818

2014-07-30 11:02:10 +00:00 by theh a090eb0

Add log directory to icinga2-common

RPMLint complains if logrotate is used without including the log directory in the package.

refs #5818

2014-07-30 11:02:10 +00:00 by theh f51a98e

Don't copy INSTALL documentation to system docs

The INSTALL documentation is not relevant after installation, especially
if packages are used.

This does prevent a rpmlint warning.

refs #5818

2014-07-30 11:02:10 +00:00 by theh 24363e4

Recommend logrotate in icinga2-common

Since we install a logrotate configuration file it does make sense to
at least recommend the installation of logrotate.
This addition is restricted to SUSE distributions since "Recommends"
is not supported elsewhere.

refs #5818

2014-07-30 11:02:10 +00:00 by theh 0d72f54

Description should be longer than the summary

This fixes a rpmlint warning.

refs #5818

2014-07-30 11:02:10 +00:00 by theh 5a98379

Remove .gitignore files from package

This commit can be reversed as soon as there are upgrade files in the
schema upgrade directories.

refs #5818

2014-07-30 11:32:32 +00:00 by theh 3b50356

Activate systemd on SUSE distributions

refs #5818

2014-07-30 11:32:34 +00:00 by theh a329505

Reduce redunancies in spec file

Remove redundant differences between SUSE and RHEL distributions.

refs #5818

2014-07-30 11:32:34 +00:00 by theh 5a4c12a

Remove redundant mysql requirement

The mysql dependencies are recognized automatically during building.

refs #5818

2014-07-30 11:32:34 +00:00 by theh 02cf329

Remove obsolete pgsqllib require on SUSE distributions

refs #5818

2014-07-30 11:32:34 +00:00 by theh 2732e4a

Use root as default user and group to prevent issues

refs #5818

2014-07-30 11:32:34 +00:00 by theh 2c6567e

Use permission verfication scripts on SUSE distributions

refs #5818

2014-07-30 11:32:34 +00:00 by theh e82d6cb

Prevent empty icinga2 package by adding COPYING

Empty packages are not allowed on SLES11 and also produce a warning in
newer openSUSE releases.

So we just work around the issue by adding the COPYING file.

refs #5818

2014-07-30 11:32:34 +00:00 by theh ce37cad

Use Github url as tarball source

This allows the automatic download of new versions.

refs #5818

2014-07-30 11:42:01 +00:00 by theh 1fcf746

Activate systemd on SUSE distributions

refs #5818

2014-07-30 11:42:06 +00:00 by theh e7d3500

Reduce redunancies in spec file

Remove redundant differences between SUSE and RHEL distributions.

refs #5818

2014-07-30 11:42:07 +00:00 by theh 1618e15

Remove redundant mysql requirement

The mysql dependencies are recognized automatically during building.

refs #5818

2014-07-30 11:42:07 +00:00 by theh f57884e

Remove obsolete pgsqllib require on SUSE distributions

refs #5818

2014-07-30 11:42:07 +00:00 by theh c8db76a

Use root as default user and group to prevent issues

refs #5818

2014-07-30 11:42:07 +00:00 by theh 074521b

Use permission verfication scripts on SUSE distributions

refs #5818

2014-07-30 11:42:07 +00:00 by theh 98aaff4

Prevent empty icinga2 package by adding COPYING

Empty packages are not allowed on SLES11 and also produce a warning in
newer openSUSE releases.

So we just work around the issue by adding the COPYING file.

refs #5818

2014-07-30 11:42:07 +00:00 by theh 8bbbab5

Use Github url as tarball source

This allows the automatic download of new versions.

refs #5818

2014-07-30 11:42:07 +00:00 by gbeutner 2174fbe

Remove redundant RPM Requires

refs #5818

2014-07-30 11:43:44 +00:00 by gbeutner 3b8a43f

Remove redundant RPM Requires

refs #5818

2014-07-30 11:58:09 +00:00 by gbeutner 3eae4f0

Remove redundant RPM Requires

refs #5818

2014-07-30 12:17:22 +00:00 by gbeutner 2f594f7

Remove redundant RPM Requires

refs #5818

2014-07-30 12:24:35 +00:00 by gbeutner 6d16d47

Merge branch 'fix/gnb-adapt-spec-for-suse-5818'

fixes #5818

2014-07-30 13:26:41 +00:00 by gbeutner 7547e17

Remove RPM Requires for mysql

refs #5818

Parent Task: #5796

The text was updated successfully, but these errors were encountered:

icinga-migration · 2014-05-13T08:21:16Z

Updated by mfriedrich on 2014-05-13 08:21:16 +00:00

Priority changed from Normal to High

icinga-migration · 2014-05-21T12:56:52Z

Updated by mfriedrich on 2014-05-21 12:56:52 +00:00

Target Version changed from 2.0 Beta 1 to 2.0 Beta 2

icinga-migration · 2014-06-05T09:13:26Z

Updated by mfriedrich on 2014-06-05 09:13:26 +00:00

Target Version changed from 2.0 Beta 2 to 2.0.0

icinga-migration · 2014-06-13T23:51:55Z

Updated by mfriedrich on 2014-06-13 23:51:55 +00:00

Any status on this? :)

icinga-migration · 2014-06-15T15:08:22Z

Updated by mfriedrich on 2014-06-15 15:08:22 +00:00

Target Version changed from 2.0.0 to 2.x Packages

Packages may require some love after the first final tarball is release. Therefore dedicated milestone for you all :-)

icinga-migration · 2014-07-03T17:12:49Z

Updated by theh on 2014-07-03 17:12:49 +00:00

Done % changed from 0 to 70

I finally found some time to work on the packages. They are available under https://build.opensuse.org/package/show/server:monitoring/icinga2 .

I have used your spec but changed some things mostly related to rpmlint warnings. I will provide a pull request soon, just want to clean up a little more.

icinga-migration · 2014-07-03T17:16:53Z

Updated by theh on 2014-07-03 17:16:53 +00:00

A fix for the issue https://dev.icinga.org/issues/6627 is needed to build a packages for the current openSUSE development version.

icinga-migration · 2014-07-05T08:11:41Z

Updated by theh on 2014-07-05 08:11:41 +00:00

Done % changed from 70 to 80

So I have created a pr for most of my changes: #5

Some of the SUSE changes, like special package names, I didn't include in this pr since I don't think they are relevant.

But besides them we mostly use your spec, so thank you for your great work.

SLES 11 SP3 packages are available in a separate repository because they require a new boost library: https://build.opensuse.org/project/show/server:monitoring:icinga2/icinga2

icinga-migration · 2014-07-06T19:36:15Z

Updated by mfriedrich on 2014-07-06 19:36:15 +00:00

Thanks for the pr patches. There's something to remark though (did you test them with opensuse 12.3 too?)

https://github.com/thardeck/icinga2/commit/a54afd877f2af82cd5362b206ad7654bb11db0a1 removes all requirements on versioned boost packages on suse. We cannot remove that upstream for automated builds on packages.icinga.org as we ship our own boost rpms for sles11 as well as use versioned boost packages for opensuse.

One thing that's more important than that - you cannot only depend on boost-devel. You'll need to depend on the boost libraries at runtime, otherwise Icinga 2 will fail to run.

So that patch cannot be applied for those 2 reasons.

https://github.com/thardeck/icinga2/commit/fcad08fa498fa9eace5e3019ff9b23546d7a4457 removes a dependency resolve helper required for obs build scripts (some opensuse revisions do not resolve these dependencies correctly). Should not be applied.

https://github.com/thardeck/icinga2/commit/fffc1a1f2c9897ea2152bfbd56a2e2b1b8ca6b81 is at least required on 12.3

https://github.com/thardeck/icinga2/commit/5579dfe144f562d8367f7e749c6086a12fd32a06 is a suse upstream specific issue with /usr/lib for the cgis. icinga-core.git spec file uses native %{_libdir}

I've looked into your modifications at https://build.opensuse.org/package/view\_file/server:monitoring/icinga2/icinga2.spec?expand=1

icinga2-bin does not provide 'icinga-idoutils' (copy paste error?)

icinga2 as package can co-exist with nagios/icinga and should not provide them. Their configuration syntax is also different, so there is not direct upgrade path available.

boost libs are not required natively. did you run install & run tests on a fresh system without boost libs installed? i bet that breaks.

rest looks fine so far. need to test that in the next few days.

icinga-migration · 2014-07-07T07:27:53Z

Updated by theh on 2014-07-07 07:27:53 +00:00

Thx for the review

dnsmichi wrote:

Thanks for the pr patches. There's something to remark though (did you test them with opensuse 12.3 too?)
I haven't tested them with 12.3 but the package did build without issue. I only tested them with 13.1 and SLES 11 SP3. I will now also test with 12.3

* https://github.com/thardeck/icinga2/commit/a54afd877f2af82cd5362b206ad7654bb11db0a1 removes all requirements on versioned boost packages on suse. We cannot remove that upstream for automated builds on packages.icinga.org as we ship our own boost rpms for sles11 as well as use versioned boost packages for opensuse.

One thing that's more important than that - you cannot only depend on boost-devel. You'll need to depend on the boost libraries at runtime, otherwise Icinga 2 will fail to run.

RPMLint complained about redundant requirements:
[ 465s] icinga2-bin.x86_64: W: explicit-lib-dependency libboost_thread1_49_0
[ 465s] You must let rpm find the library dependencies by itself. Do not put unneeded
[ 465s] explicit Requires: tags.

And if I run the following command the dependencies are there:
rpm -qpR icinga2-bin-2.0.0-8.1.x86_64.rpm
[...]
libboost_program_options.so.1.53.0()(64bit)
libboost_regex.so.1.53.0()(64bit)
libboost_system.so.1.53.0()(64bit)
libboost_thread.so.1.53.0()(64bit)
[...]

Nevertheless I will try to install icinga2 on a minimal system.

So that patch cannot be applied for those 2 reasons.

* https://github.com/thardeck/icinga2/commit/fcad08fa498fa9eace5e3019ff9b23546d7a4457 removes a dependency resolve helper required for obs build scripts (some opensuse revisions do not resolve these dependencies correctly). Should not be applied.
I have checked the packages for 13.1, 12.3 and SLES11SP3 and all have the dependency. Which openSUSE revisions are not able to resolve them?
rpm -qpR ~/Downloads/icinga2-ido-mysql-2.0.0-9.2.x86_64.rpm
[...]
libmysqlclient.so.15()(64bit)
libmysqlclient.so.15(libmysqlclient_15)(64bit)
[...]

* https://github.com/thardeck/icinga2/commit/fffc1a1f2c9897ea2152bfbd56a2e2b1b8ca6b81 is at least required on 12.3
It does build fine here in the open Build Service on 12.3. Btw. it seems that I accidentally squashed another commit in this, I am going to fix it.

* https://github.com/thardeck/icinga2/commit/5579dfe144f562d8367f7e749c6086a12fd32a06 is a suse upstream specific issue with /usr/lib for the cgis. icinga-core.git spec file uses native %{_libdir}
So your packages do have /usr/lib64? Ok, so I probably need to use a patch again.

I've looked into your modifications at https://build.opensuse.org/package/view\_file/server:monitoring/icinga2/icinga2.spec?expand=1

* icinga2-bin does not provide 'icinga-idoutils' (copy paste error?)
It is there to allow the icinga-web package be installed alongside with icinga2 but it should be part of the ido packages.

* icinga2 as package can co-exist with nagios/icinga and should not provide them. Their configuration syntax is also different, so there is not direct upgrade path available.
I didn't use obsolete, but you are right that it might result in issues for some packages. I am going to remove them for now.

* boost libs are not required natively. did you run install & run tests on a fresh system without boost libs installed? i bet that breaks.
Rpm shows that the dependencies are there but I will test this manually on a minimal system.

icinga-migration · 2014-07-07T07:39:00Z

Updated by theh on 2014-07-07 07:39:00 +00:00

So I have removed all libboost and mysql packages on 12.3 and installed icinga2 and icinga-www from the server monitoring repository and it did work fine. I have also installed icinga2-ido-mysql and the libmysqlclient18 package was installed as a requirement.

So I think these parts should be fine, but I will fix the others.

icinga-migration · 2014-07-10T08:23:07Z

Updated by mfriedrich on 2014-07-10 08:23:07 +00:00

Ok. Then we'll test/merge that for 2.0.2 then.

icinga-migration · 2014-07-30T09:26:24Z

Updated by mfriedrich on 2014-07-30 09:26:24 +00:00

Assigned to changed from theh to mfriedrich
Priority changed from High to Normal
Target Version changed from 2.x Packages to 2.0.2
Estimated Hours set to 2

icinga-migration · 2014-07-30T11:09:00Z

Updated by gbeutner on 2014-07-30 11:09:00 +00:00

This patch is no longer relevant because I've removed the .gitignore files:

    Remove .gitignore files from package

    This commit can be reversed as soon as there are upgrade files in the
    schema upgrade directories.

    refs #5818

icinga-migration · 2014-07-30T12:30:05Z

Updated by gbeutner on 2014-07-30 12:30:05 +00:00

Status changed from Assigned to Resolved
Done % changed from 80 to 100

Applied in changeset 6d16d47.

icinga-migration · 2014-07-30T12:59:02Z

Updated by gbeutner on 2014-07-30 12:59:02 +00:00

I've merged the patches - with some modifications. Please recheck if that's what you had in mind.

icinga-migration · 2014-08-01T07:05:18Z

Updated by gbeutner on 2014-08-01 07:05:18 +00:00

Assigned to changed from mfriedrich to gbeutner

icinga-migration closed this as completed Jul 30, 2014

icinga-migration added enhancement New feature or request area/setup Installation, systemd, sample files labels Jan 17, 2017

icinga-migration added this to the 2.0.2 milestone Jan 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dev.icinga.com #5818] SUSE packages #1338

[dev.icinga.com #5818] SUSE packages #1338

icinga-migration commented Mar 20, 2014

icinga-migration commented May 13, 2014

icinga-migration commented May 21, 2014

icinga-migration commented Jun 5, 2014

icinga-migration commented Jun 13, 2014

icinga-migration commented Jun 15, 2014

icinga-migration commented Jul 3, 2014

icinga-migration commented Jul 3, 2014

icinga-migration commented Jul 5, 2014

icinga-migration commented Jul 6, 2014

icinga-migration commented Jul 7, 2014

icinga-migration commented Jul 7, 2014

icinga-migration commented Jul 10, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Aug 1, 2014

[dev.icinga.com #5818] SUSE packages #1338

[dev.icinga.com #5818] SUSE packages #1338

Comments

icinga-migration commented Mar 20, 2014

icinga-migration commented May 13, 2014

icinga-migration commented May 21, 2014

icinga-migration commented Jun 5, 2014

icinga-migration commented Jun 13, 2014

icinga-migration commented Jun 15, 2014

icinga-migration commented Jul 3, 2014

icinga-migration commented Jul 3, 2014

icinga-migration commented Jul 5, 2014

icinga-migration commented Jul 6, 2014

icinga-migration commented Jul 7, 2014

icinga-migration commented Jul 7, 2014

icinga-migration commented Jul 10, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Jul 30, 2014

icinga-migration commented Aug 1, 2014