[dev.icinga.com #4544] comments(history) UK misses object_id, not allowing the same comment on host AND service

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/4544

Created by mfriedrich on 2013-08-12 08:12:06 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2013-09-14 15:21:30 +00:00)
Target Version: 1.10
Last Update: 2014-12-08 14:36:00 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

---

given that you may assign a comment id to a host AND a service the following unique constraint will trigger

  UNIQUE KEY instance_id (instance_id,comment_time,internal_comment_id)

which is obviously incorrect as the column "comment_type" is not taken into account (nor the object_id).

for the scheduleddowntime table this seems correct

  UNIQUE KEY instance_id (instance_id,object_id,entry_time,internal_downtime_id)

as the object_id is different for the host and the service then.

it does not affect 1.x as there are no shared comment ids but it hurts future designs like icinga2 compat.

Changesets

2013-09-14 15:20:49 +00:00 by (unknown) ce91b9d

idoutils: fix comments(history) UK misses object_id, not allowing the same comment on host AND service

fixes #4544

---

Relations:

• relates #4544

[icinga-migration]

Updated by mfriedrich on 2013-09-14 14:46:53 +00:00

• Priority changed from Normal to High

[icinga-migration]

Updated by mfriedrich on 2013-09-14 15:19:33 +00:00

• Subject changed from comments UK misses object_id, not allowing the same comment on host AND service to comments(history) UK misses object_id, not allowing the same comment on host AND service

[icinga-migration]

Updated by mfriedrich on 2013-09-14 15:20:00 +00:00

affects postgresql and oracle too, upgrade script queries created and tested.

[icinga-migration]

Updated by Anonymous on 2013-09-14 15:21:30 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset icinga-core:ce91b9d590cd68cd6f735dfc43b738d255dcba38.

[icinga-migration]

Updated by mfriedrich on 2014-12-08 14:36:00 +00:00

• Project changed from 18 to Core, Classic UI, IDOUtils
• Category changed from 24 to IDOUtils
• Icinga Version changed from 1 to 1
• OS Version set to any