[dev.icinga.com #4519] add support for gzip compressed logs #1326
Comments
Updated by formorer on 2013-08-06 13:21:18 +00:00
|
Updated by ricardo on 2013-09-11 21:24:53 +00:00
hi formorer, I thought about this as well. But I fear it will take muuuch longer to view logs if the searched time span gets bigger. Especially in big environments. And then the users would start to complain again, that all cgis using historical data are too slow. Or how do you see it? |
Updated by tk on 2013-09-13 06:28:13 +00:00 I would highly appreciate if the cgi would be able to read compressed logs. Maybe it would make sense to add a check like "the next log file is compressed, so make the 'Latest Archive'/'Earlier Archive'/'More Recent Archive' arrow yellow instead of green, and if the user moves the mouse over it, display a warning 'Archive is compressed, reading may be slow'". |
Updated by mfriedrich on 2013-09-14 18:04:10 +00:00 i fear the performance impact too on large log files (imagine external commands / passive check results being logged) and a large timespan. and the code making this happen isn't elasticsearch, or comparable. imho one could hack a prototype and testdrive that longterm in larger environments. but not for 1.10 where feature freeze happens in ~2 weeks. |
Updated by tk on 2013-09-16 07:02:16 +00:00 dnsmichi wrote:
Why not let the user decide whether he can live with the performance loss?
Not having had a look at the source code so far my understanding may be wrong, but isn't the difference "instead of open(filename, ...), just use 'if (-f filename) {open(...)} else { /* add .gz suffix to filename, then use zlib's gzopen(...) */ }'"? Might still be too much work to do it before the feature freeze because of other priorities though. |
Updated by mfriedrich on 2013-09-16 08:28:58 +00:00 tk wrote:
been there, done that. reverts/additional config options are the result of that. trust me, new features are fun. until they generate bugs and issues. so keeping the contra in the first place on the discussion is my part of the story. feel free to convince me ;-)
Sure, why not. If you got a patch, send it for prototyping. I am just saying that feature freeze happens soon, and our quality assurance guidelines don't allow us to add experimental features afterwards (unless they remain on seperated feature/* branches for the next release, i.e. 1.11). |
Updated by ricardo on 2013-10-04 09:43:13 +00:00
will add a cgi.cfg option with a warning on the performance impact. Then the users can't say they didn't know about it. |
Updated by formorer on 2013-10-04 09:45:49 +00:00 Perfect! Thanks |
Updated by tk on 2013-10-11 09:08:24 +00:00 Cool! Thanks from me as well! |
Updated by ricardo on 2013-12-26 01:30:34 +00:00
in current "feature/support-compressed-logs-4519" please test everyone!! |
Updated by ricardo on 2014-01-03 23:02:40 +00:00 testers? any testers? |
Updated by tk on 2014-01-24 15:36:41 +00:00 Well, back from "killing backlog after vacation". I'd like to test, but I think I'll need some assistance / pointers. |
Updated by mfriedrich on 2014-01-24 15:39:31 +00:00 https://github.com/Icinga/icinga-core/tree/feature/support-compressed-logs-4519 |
Updated by tk on 2014-02-01 19:16:53 +00:00 OK, it took a few days, but now I'm back from testing.
So thanks for implementing this :-) |
Updated by ricardo on 2014-02-18 22:51:42 +00:00
Thanks you and Carl for testing. Merged it to next branch. |
Updated by ricardo on 2014-02-19 12:05:10 +00:00
Applied in changeset icinga-core:991e84c2e47dc3dede7506ffcf946b012c10971a. |
Updated by mfriedrich on 2014-12-08 09:15:31 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/4519
Created by formorer on 2013-08-06 13:21:04 +00:00
Assignee: ricardo
Status: Resolved (closed on 2014-02-19 12:05:10 +00:00)
Target Version: 1.11
Last Update: 2014-12-08 09:15:31 +00:00 (in Redmine)
It would be nice if icinga cgi would be able to read compressed logs.
That whould save me/us some space on disk.
Changesets
2013-12-26 01:23:11 +00:00 by ricardo cf5f403
2013-12-26 10:16:27 +00:00 by ricardo d6698cf
2014-01-03 22:17:28 +00:00 by ricardo bb2b0b3
2014-02-18 22:46:07 +00:00 by ricardo 991e84c
The text was updated successfully, but these errors were encountered: