[dev.icinga.com #3919] Fix Cronk caching feature introduced by 1.8.2

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3919

Created by mfrosch on 2013-04-03 13:34:17 +00:00

Assignee: mfrosch
Status: Resolved (closed on 2013-04-17 15:42:14 +00:00)
Target Version: 1.9
Last Update: 2013-04-17 15:42:14 +00:00 (in Redmine)

Icinga Version: 1.8.4
Icinga Web Version: 1.8.3
IDO Version: 1.8.4
OS Version: Debian/wheezy
DB Type: UNKNOWN
DB Version: all
Browser Version: all

---

The Cronk caching feature which came with 1.8.2 saves a cache of the users cronks in the session.

This leads to major confusion when changing or installing Cronks, because the user needs to re-login to see the Cronks.

Maybe we should remove that feature, I don't think it really helps that much on performance.

Thoughts?

Changesets

2013-04-17 15:34:58 +00:00 by mfrosch 2fadaca

Fix CronksDataModel caching feature

We now add a timestamp to the cached data, to be able to determine if the cache
is still valid.

The timestamp is compared against the filemtime of the XML cache on disk
(cronks.xml cache).

In addition the handling of the param ($all) has been disabled in the
getXmlCronks function, it is handled in the function combinedData
(since 5da9fae0). This will avoid having only a partial cache.

fixes #3919

---

Relations:

• relates #3919

[icinga-migration]

Updated by mfriedrich on 2013-04-08 22:29:39 +00:00

it's comfortable having everything saved in the cache, but may hinder development if you do not know about such changes. since updates normally happen in regular scheduled windows, users should be notified by the sysadmin of such changes, if any. so i would leave it like it is for now, and focus on the 1.9 stuff.

[icinga-migration]

Updated by juergenkreis on 2013-04-09 10:38:43 +00:00

I just fell for this „trap“ :)

I had an older installation of the BusinessProcess AddOn for Icinga-Web, there it worked just fine.

Now on a new system I also tried to install the BusinessProcess AddOn for Icinga-Web. Diddn’t know about this change. So I tried several days several solutions for an issue which now seems to be a feature :). I deleted every Cache and I saw some changes in the “category editor” but not the category itself in icinga-web.

I was logged in by default and thought it would be enough to restart Icinga, Apache and clear the caches.
I would like to have some information about this change maybe in the “clear the Agavi-Cache” Section.

[icinga-migration]

Updated by mfrosch on 2013-04-12 14:51:09 +00:00

• Status changed from New to Assigned
• Target Version changed from 1.8.4 to 1.9

Evaluating this for 1.9

Especially performance comparsion

[icinga-migration]

Updated by mfrosch on 2013-04-17 15:34:50 +00:00

• Subject changed from Remove Cronk caching feature introduced by 1.8.2 to Fix Cronk caching feature introduced by 1.8.2

Instead of removing the cache, I changed it so the cache gets invalid when the XML cache on disk is newer.

Cronks from the database are not handled with the CronkDataModel.

[icinga-migration]

Updated by mfrosch on 2013-04-17 15:42:14 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 2fadaca.