Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #3507] CGIs generating invalid html code/ json when throwing error #1189

Closed
icinga-migration opened this issue Dec 18, 2012 · 8 comments
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3507

Created by ricardo on 2012-12-18 17:10:23 +00:00

Assignee: ricardo
Status: Resolved (closed on 2013-04-06 21:57:07 +00:00)
Target Version: 1.9
Last Update: 2014-12-08 09:27:56 +00:00 (in Redmine)

Icinga Version: 1.8.2
OS Version: any

Currently the CGIs don't create valid html code / JSON when throwing an error.

Alos tac_header doesn't display the error properly.

Changesets

2012-12-20 23:36:51 +00:00 by ricardo ea510be

classic-ui: fixed CGIs generating invalid html code/ json when throwing error #3507

refs: #3507

* generating valid JSON on error
* removed ERROR_CGI_RESOURCE_CFG and icinga_resource_file_error because it
isn't used anywhere
* removed ERROR_CGI_ID because it isn't' used either
* now tac header shows a nice formatted error messages

Relations:

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-12-20 21:17:13 +00:00

  • Subject changed from Generate valid JSON when throwing error to Generate valid html code/ json when throwing error
  • Status changed from New to Assigned
  • Done % changed from 0 to 80

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-12-20 23:48:59 +00:00

  • Subject changed from Generate valid html code/ json when throwing error to CGIs generating invalid html code/ json when throwing error

fixed in current "dev/cgis".

please test.

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-12-20 23:49:10 +00:00

  • Status changed from Assigned to 7

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-12-21 08:33:02 +00:00

if you want this for r1.8 - cherry-pick is not clean.

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-12-21 11:47:04 +00:00

I think we should leave it for 1.9. As It changes some designs (tac header) this isn't for a bug fix release.

And all works fine in 1.8.3.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-03-13 23:16:18 +00:00

tac header looks indeed nice, as i now see the issue for the change.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2013-04-06 21:57:07 +00:00

  • Status changed from 7 to Resolved
  • Done % changed from 80 to 100

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-12-08 09:27:56 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • OS Version set to any

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant