[dev.icinga.com #3259] optimisation of images #1126
Comments
Updated by calestyo on 2012-10-08 01:26:07 +00:00
Gnah... stupid version/browser/OS fields.... |
Updated by calestyo on 2012-10-08 01:49:43 +00:00 Reported an analogous bug for Icinga-Web: bug #3260 |
Updated by mfriedrich on 2012-10-08 07:42:04 +00:00 those fields aren't stupid but help a lot identifying a lot of bugs in the first place. that's why they exist. |
Updated by mfriedrich on 2012-10-08 07:44:22 +00:00
the rest is more or less cosmetical, so consider it for 1.9 while we focus on 1.8 testdriving. |
Updated by calestyo on 2012-10-08 19:56:57 +00:00 The reason I was annoyed was, because "any" as version string wasn’t accepted, but it told me so only after it uploaded the large patches ;) Fine with targeting this for 1.9 :) Cheers, |
Updated by ricardo on 2012-10-15 21:33:08 +00:00
should be solved with current "next" |
Updated by mfriedrich on 2012-10-16 11:18:27 +00:00
|
Updated by mfriedrich on 2014-12-08 09:27:43 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/3259
Created by calestyo on 2012-10-08 01:23:54 +00:00
Assignee: ricardo
Status: Resolved (closed on 2012-10-16 11:18:27 +00:00)
Target Version: 1.8
Last Update: 2014-12-08 09:27:43 +00:00 (in Redmine)
Hi.
This is from:
https://github.com/dnsmichi/icinga/pull/1
https://github.com/dnsmichi/icinga/pull/2
https://github.com/dnsmichi/icinga/pull/3
One can save quite some amount of bandwidth when all images are optimised (losslessly).
a) When there is a "best practices" document (or something like that) for your Icinga developers, than please add that they should process PNGs and JPEGs with:
jpegoptim
optipng -o 7
in the future.
b) For the current PNGs/JPGs I've already did this.
Attached are three patches. One is split (with split(1)) into pieces (because of the 5 MB limit).
Please cat it together before use:
cat 0001-optimise-all-PNGs-with-optipng.patch_aa 0001-optimise-all-PNGs-with-optipng.patch_ab 0001-optimise-all-PNGs-with-optipng.patch_ac > 0001-optimise-all-PNGs-with-optipng.patch
Ricardo has already merged this for the JPEGs: https://git.icinga.org/?p=icinga-core.git;a=commitdiff;h=f6582801b75c89a5d51960b05f72176e371705da
so 0001-optimise-all-JPEGs-with-optimjepg.patch should be obsolete.
Thanks,
Chris.
Attachments
The text was updated successfully, but these errors were encountered: