Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #3259] optimisation of images #1126

Closed
icinga-migration opened this issue Oct 8, 2012 · 8 comments
Closed

[dev.icinga.com #3259] optimisation of images #1126

icinga-migration opened this issue Oct 8, 2012 · 8 comments

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/3259

Created by calestyo on 2012-10-08 01:23:54 +00:00

Assignee: ricardo
Status: Resolved (closed on 2012-10-16 11:18:27 +00:00)
Target Version: 1.8
Last Update: 2014-12-08 09:27:43 +00:00 (in Redmine)

Icinga Version: 1.7.1
OS Version: any

Hi.

This is from:
https://github.com/dnsmichi/icinga/pull/1
https://github.com/dnsmichi/icinga/pull/2
https://github.com/dnsmichi/icinga/pull/3

One can save quite some amount of bandwidth when all images are optimised (losslessly).

a) When there is a "best practices" document (or something like that) for your Icinga developers, than please add that they should process PNGs and JPEGs with:
jpegoptim
optipng -o 7
in the future.

b) For the current PNGs/JPGs I've already did this.

Attached are three patches. One is split (with split(1)) into pieces (because of the 5 MB limit).
Please cat it together before use:
cat 0001-optimise-all-PNGs-with-optipng.patch_aa 0001-optimise-all-PNGs-with-optipng.patch_ab 0001-optimise-all-PNGs-with-optipng.patch_ac > 0001-optimise-all-PNGs-with-optipng.patch

Ricardo has already merged this for the JPEGs: https://git.icinga.org/?p=icinga-core.git;a=commitdiff;h=f6582801b75c89a5d51960b05f72176e371705da
so 0001-optimise-all-JPEGs-with-optimjepg.patch should be obsolete.

Thanks,
Chris.

Attachments

@icinga-migration
Copy link
Author

Updated by calestyo on 2012-10-08 01:26:07 +00:00

  • File added 0001-optimise-all-JPEGs-with-optimjepg.patch
  • File added 0001-optimise-all-jquery-PNGs-with-optipng.patch
  • File added 0001-optimise-all-PNGs-with-optipng.patch_aa
  • File added 0001-optimise-all-PNGs-with-optipng.patch_ab
  • File added 0001-optimise-all-PNGs-with-optipng.patch_ac

Gnah... stupid version/browser/OS fields....

@icinga-migration
Copy link
Author

Updated by calestyo on 2012-10-08 01:49:43 +00:00

Reported an analogous bug for Icinga-Web: bug #3260

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-10-08 07:42:04 +00:00

those fields aren't stupid but help a lot identifying a lot of bugs in the first place. that's why they exist.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-10-08 07:44:22 +00:00

  • Target Version set to 1.9

the rest is more or less cosmetical, so consider it for 1.9 while we focus on 1.8 testdriving.

@icinga-migration
Copy link
Author

Updated by calestyo on 2012-10-08 19:56:57 +00:00

The reason I was annoyed was, because "any" as version string wasn’t accepted, but it told me so only after it uploaded the large patches ;)

Fine with targeting this for 1.9 :)

Cheers,
Chris.

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-10-15 21:33:08 +00:00

  • Status changed from New to 7
  • Assigned to set to ricardo
  • Target Version changed from 1.9 to 1.8

should be solved with current "next"

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-10-16 11:18:27 +00:00

  • Status changed from 7 to Resolved
  • Done % changed from 0 to 100

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-12-08 09:27:43 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • OS Version set to any

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant