You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Assignee: (none)
Status: Rejected (closed on 2013-04-11 08:13:19 +00:00)
Target Version: (none)
Last Update: 2013-04-11 08:13:19 +00:00 (in Redmine)
With the patch of the core #2650 for V1.8, the long plugin output for hosts/services will be store correctly in the table icinga_statehistory.
We need now a possibility to see this data in icinga-web when we click on a host/service history link.
Idea:
a new column, but it could be large
a special infobox icon on each line as by the hosts/services which will contains at least the output and the long output. In other words a reduce version of the info box of the cronk HostStatus/ServiceStatus.
For us is an implementation for services very interessant. For hosts not so more, but i think the code should be similar.
Revert "LongPluginOutput: Fix missing support of multi line in html"
This reverts commit 14fdf6323dde83ba51d61d29f7ff3ee4b23614f4.
The fix actually fixes nothing for the following reasons:
1) The "Long plugin output" field of a host's or service's detail window already has `\n' replaced with the HTML break tag.
This is because the information is gathered via Icinga Web's API which calls `Api_Result_OutputRewriteModel::rewritePluginOutput()'
in the controller `ApiSearchAction'.
Note that the carriage return `\r' is not taken into accout, but that's not a problem here.
2) Grids do not benefit from `Api_Result_OutputRewriteModel::rewritePluginOutput()' as its not being called. The `nl2br()' should've
helped here. According to http://www.ietf.org/rfc/rfc4627.txt the JSON representation of strings must escape control characters which includes the line feed `\n'
and the carriage return `\r'. So '\n', '\r' and '\r\n' become '\\n', '\\r' and '\\r\\n' respectively making them a textual representation of the control characters.
The `nl2br()' implementation however only replaces the unescaped line feed and carriage return which does of course replace nothing in the above case.
3) Introducing `String::nl2br()' while ExtJS provides `Ext.util.Format.nl2br()' is superfluous.
refs #2653
Hi dnsmichi, what do you mean with a Patch? That i write someone. I don't have enough Knowledge to Write a Patch for icinga-Web. I would like but i cannot at the moment.
Updated by mfriedrich on 2012-11-21 14:23:50 +00:00
Status changed from New to Feedback
question arises - does icinga web actually read the statehistory table for that grid view, or would that add another join overhead to the data backend query?
This issue has been migrated from Redmine: https://dev.icinga.com/issues/2653
Created by ossmon on 2012-05-31 12:51:43 +00:00
Assignee: (none)
Status: Rejected (closed on 2013-04-11 08:13:19 +00:00)
Target Version: (none)
Last Update: 2013-04-11 08:13:19 +00:00 (in Redmine)
With the patch of the core #2650 for V1.8, the long plugin output for hosts/services will be store correctly in the table icinga_statehistory.
We need now a possibility to see this data in icinga-web when we click on a host/service history link.
Idea:
For us is an implementation for services very interessant. For hosts not so more, but i think the code should be similar.
Changesets
2014-06-20 11:41:10 +00:00 by mhein 14fdf63
2014-06-26 13:37:43 +00:00 by elippmann 97bf45e
2014-06-26 14:30:11 +00:00 by elippmann 232b5c0
Relations:
The text was updated successfully, but these errors were encountered: