Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

[dev.icinga.com #2373] Commit commands with more then 500 multiple pairs of hosts and services #895

Closed
icinga-migration opened this issue Feb 27, 2012 · 6 comments
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/2373

Created by morgajel on 2012-02-27 14:23:43 +00:00

Assignee: ricardo
Status: Resolved (closed on 2012-04-13 19:09:29 +00:00)
Target Version: 1.7
Last Update: 2014-12-08 09:42:32 +00:00 (in Redmine)

Icinga Version: 1.10.0
OS Version: any

Problem: while trying to acknowledge ~500 service checks from the unhandled critical checks page, acknowledgement fails with "Comment data was not entered", regardless of the contents of the comment box and regardless of the state of enforce_comments_on_actions, whether a end time is set, or if persistent comment is set.

I'm not sure what data will be useful, so I've included the post data from firebug

btnSubmit Commit
cmd_mod 2
cmd_typ 34
com_author Morgan, Jesse
com_data This comment is not working?
end_time 02-28-2012 08:25:44
host animals-as03.qa
host area1.dev
[incredibly long list of services]
host auth-as01.dev
host worldscholar-as02.qa
persistent on
send_notification on
service SSHD
service SSHD
[incredibly long list of services]
service SSHD
sticky_ack on

I did notice in the source of the post request, firebug displays the following:
"... Firebug request size limit has been reached by Firebug. ..."

and here's the tail of the firebug post source:

host=tg-qxsyb4&service=SSHD&host=tg-qxthink3&service=SSHD&host=tg-qxthink4&service=SSHD&host=tg-qxusage01&service=Basic+MySQL+check&host=tg-qxusage01&service=SSHD&host=tg-qxzprox3&service=SSHD&host=tinyurl-as01.dev&service=SSHD&host=tinyurl-as01.qa&service=SSHD&host=tinyurl-as02.qa&service=SSHD&host=worldscholar-as01.qa&service=SSHD&host=worldscholar-as02.qa&service=SSHD&com_author=Morgan%2C+Jesse&com_data=This+comment+is+not+working%3F&persistent=on&end_time=02-28-2012+08%3A25%3A44&sticky_ack=on&send_notification=on&btnSubmit=Commit

Since this is pretty the reason we're replacing nagios with icinga, I'd really like to get to the bottom of this.

And if you're wondering why I'm acknowledging 500 checks at once (of our 20k), it was because we had a firewall rule block access to 200+ servers accidentally. Ideally a parent relationship would simplify this, but alas it wasn't available.

This was using the rpmforge package icinga-1.6.1-1.el6.rf.x86_64.

Changesets

2012-02-27 21:36:58 +00:00 by ricardo 18b9896

classic ui: fixed Commit commands with more then 500 multiple pairs of hosts and services #2373

refs: #2373

* now it's possible to submit ~990 commands at the same time

2012-04-13 18:48:07 +00:00 by ricardo 7b9ec5b

classic-ui: updated Changelog CHANGES section

refs: #1524
refs: #1981
refs: #2018
refs: #2117
refs: #2119
refs: #2145
refs: #2198
refs: #2343
refs: #2359
refs: #2373
refs: #2421

hope the "changes" section for classic ui isn't tooo long
@icinga-migration
Copy link
Author

Updated by ricardo on 2012-02-27 16:03:05 +00:00

  • Assigned to set to ricardo
  • Target Version changed from 1.6.1 to 1.7

Hi,

found the problem:

currently are only 1000 value pairs (host=xy) used.

On first submit "hostservice=hostxy^servicexy" is used. So you have roughly 507 with some extra pairs. But on second submit (actually sending data to icinga) it gets transmitted like this "host=hostxy&service=hostxy". The amount of value pairs for hosts and services doubles.

This is an Error and can be fixed relatively easily in 1.7.0

Cheers Ricardo

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-02-27 21:41:39 +00:00

  • Subject changed from Cannot Multi-acknowledge checks. to Commit commands with more then 500 multiple pairs of hosts and services
  • Status changed from New to Feedback

sorry for the trouble again, should now work with up to 990 commands at the same time.

in current 'rbartels/cgi'

@icinga-migration
Copy link
Author

Updated by morgajel on 2012-03-01 23:19:56 +00:00

You may want to make the error message more clear if you go above the threshold; I can see this biting other people as well.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2012-04-03 13:56:28 +00:00

@ricardo

add an entry to the CHANGES section in Changelog remarking this limitation change.

though i think this limit could be too low for some ppl.

@icinga-migration
Copy link
Author

Updated by ricardo on 2012-04-13 19:09:29 +00:00

  • Status changed from Feedback to Resolved

Added note to changes in Changelog

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-12-08 09:42:32 +00:00

  • Project changed from 19 to Core, Classic UI, IDOUtils
  • Category set to Classic UI
  • Icinga Version set to 1
  • OS Version set to any

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant