[dev.icinga.com #13605] cannot edit contacts

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13605

Created by tdpw on 2016-12-15 09:58:25 +00:00

Assignee: tgelf
Status: Resolved (closed on 2016-12-15 10:50:03 +00:00)
Target Version: 1.3.0
Last Update: 2016-12-15 10:50:03 +00:00 (in Redmine)

---

Hello,

I pulled newest master this morning. Afterwards I cannot edit existings contacts and get this error. I applied the schema update to the database. If I can give you further assistence please let me know.

Warning: Exception caught by form: strlen() expects parameter 1 to be string, object given Stack Trace: #0 [internal function]: Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}(2, 'strlen() expect...', '/usr/share/icin...', 24, Array) #1 [internal function]: strlen(Object(stdClass)) #2 /usr/share/icingaweb2/modules/director/library/Director/Web/Form/Element/ExtensibleSet.php(24): array_filter(Array, 'strlen') #3 /usr/share/php/Zend/Form/Decorator/ViewHelper.php(206): Icinga\Module\Director\Web\Form\Element\ExtensibleSet->getValue() #4 /usr/share/php/Zend/Form/Decorator/ViewHelper.php(236): Zend_Form_Decorator_ViewHelper->getValue(Object(Icinga\Module\Director\Web\Form\Element\ExtensibleSet)) #5 /usr/share/php/Zend/Form/Element.php(2071): Zend_Form_Decorator_ViewHelper->render('') #6 /usr/share/php/Zend/Form/Decorator/FormElements.php(116): Zend_Form_Element->render() #7 /usr/share/php/Zend/Form/DisplayGroup.php(920): Zend_Form_Decorator_FormElements->render('') #8 /usr/share/php/Zend/Form/Decorato in /usr/share/php/Zend/Form.php on line 3015

Attachments

• gnome-shell-screenshot-YQ9HSY.png tdpw - 2016-12-15 09:56:56 +00:00

Changesets

2016-12-15 10:43:56 +00:00 by tgelf 65181ca

ExtensibleSet: be strict on values...

...and provide a meaningful Exception in case something fails

refs #13605

2016-12-15 10:44:52 +00:00 by tgelf 3d8ccf2

DirectorObjectForm: skip empty related sets...

...provides as objects

fixes #13605

[icinga-migration]

Updated by tdpw on 2016-12-15 09:59:55 +00:00

Please see screenshot for better view of the error message

[icinga-migration]

Updated by tdpw on 2016-12-15 10:16:28 +00:00

same error when adding a notification template

[icinga-migration]

Updated by tgelf on 2016-12-15 10:34:52 +00:00

• Status changed from New to Assigned
• Assigned to set to tgelf
• Target Version set to 1.3.0

A recent fix brought more transparency, unfortunately the form now gets features like this one:

https://github.com/Icinga/icingaweb2-module-director/blob/master/test/php/library/Director/IcingaConfig/StateFilterTest.php#L97-L99

The unit test shows that state filters allow for += and . Something that works since a long time but is not available in our forms yet. A change committed yesterday had the side-effect that those raw values are now able to reach the form, and the form doesn't know how to handle them.

Give me some minute, I'll fix this. As you already figured out, it affects users and notifications. Could not find related code elsewhere.

[icinga-migration]

Updated by tgelf on 2016-12-15 10:50:03 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 3d8ccf2.