[dev.icinga.com #13469] Command escape is broken for Windows

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13469

Created by jflach on 2016-12-08 10:11:02 +00:00

Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-12-08 10:11:02 +00:00 (in Redmine)

Icinga Version: 2.6.0
Backport?: Not yet backported
Include in Changelog: 1

---

Windows has special needs when it comes to escaping:

For a Programm to receive "foo bar" (with ") the correct shell escaped string would be ^"foo bar^", yet icinga creates the string "\"foo bar\"".

[Al2Klimov]

Note:

I asked @LordHepipud to evaluate what's the right escaping algo.

My guess: Put a ^ before every character.

[Al2Klimov]

Note:

CreateProcess() seems not to parse the command line string, but to call the exe with that string and let it parse it by itself.

See http://www.daviddeley.com/autohotkey/parameters/parameters.htm

[Al2Klimov]

And here's how the exe parses the string: https://docs.microsoft.com/de-de/cpp/cpp/parsing-cpp-command-line-arguments?view=vs-2019