[dev.icinga.com #13421] API max_check_attempts validation

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/13421

Created by andyb2000 on 2016-12-06 10:39:03 +00:00

Assignee: (none)
Status: New
Target Version: (none)
Last Update: 2016-12-06 10:39:03 +00:00 (in Redmine)

Icinga Version: r2.5.4-1
Backport?: Not yet backported
Include in Changelog: 1

---

I believe this could do with input validation when creating a service via the API.
Creating it using the command:

/usr/bin/curl -k -s -u myuser:mypass -H 'Accept: application/json' -X  PUT  "https://localhost:5665/v1/objects/services/HOSTNAME!SVC-ID1234" -d '{ "templates" : [ "linux-nonessential-server" ] ,  "attrs" : { "check_command" : "dummy" , "display_name" : "$in_service", "enable_active_checks" : "0", "max_check_attempts" : "0" }}'

Is accepted by the API and doesn't cause any issues on icingaweb2, etc, however for any classic interfaces (those that use /var/cache/icinga2/objects.cache) the value of 0 for max_check_attempts appears invalid and causes them to fail to load.
Changing this posted value to 1 solves this issue, however I believe the service shouldn't be created/should be rejected with an invalid value error.

See discussion at: https://monitoring-portal.org/index.php?thread/39184-dynamic-service-creation-api-and-classicui-json-errors/

Thank you