[dev.icinga.com #12940] SIGALRM handling may be affected by recent commit

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12940

Created by jyoung15 on 2016-10-18 14:17:47 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2016-10-24 06:50:05 +00:00)
Target Version: 2.6.0
Last Update: 2016-10-24 23:53:23 +00:00 (in Redmine)

Icinga Version: v2.5.4-160-g08460e7
Backport?: Not yet backported
Include in Changelog: 1

---

a7b0cb5 introduced a signal mask in ProcessHandler (source:lib/base/process.cpp#L229) to be applied before calling external plugins. It appears all signals are now masked in plugins, including SIGALRM which may be used in certain cases for internal timeouts.

Attached is a basic c plugin to test this. With the old behavior, the signal handler is called as expected.

With the new behavior, the signal handler is not called.

If this behavior change is intentional, it should probably be documented.

Attachments

• check_sigmask.c jyoung15 - 2016-10-18 14:09:47 +00:00
• pre_commit_a7b0cb5f.png jyoung15 - 2016-10-18 14:11:40 +00:00
• commit_a7b0cb5f.png jyoung15 - 2016-10-18 14:11:48 +00:00

Changesets

2016-10-24 06:42:40 +00:00 by gbeutner c0bc156

Don't mask all signals in the subprocess handler

fixes #12940

---

Relations:

• relates #12940

[icinga-migration]

Updated by gbeutner on 2016-10-24 06:35:19 +00:00

• Category changed from Cluster to libbase
• Status changed from New to Assigned
• Assigned to set to gbeutner
• Target Version set to 2.6.0

[icinga-migration]

Updated by gbeutner on 2016-10-24 06:43:54 +00:00

Thanks for the detailed analysis. Quite frankly I can't remember the rationale for masking signals in the sub-process handler. Can you try the patch I'm about to commit in a few minutes?

[icinga-migration]

Updated by gbeutner on 2016-10-24 06:50:05 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset c0bc156.

[icinga-migration]

Updated by jyoung15 on 2016-10-24 23:53:23 +00:00

Confirmed the issue is resolved. Thank You!

[icinga-migration]

Updated by mfriedrich on 2016-11-21 15:12:08 +00:00

• Relates set to 13269