Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12747] Problem passing arguments to nscp-local CheckCommand objects #4677

Closed
icinga-migration opened this issue Sep 19, 2016 · 5 comments
Labels
area/itl Template Library CheckCommands bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12747

Created by Marax on 2016-09-19 12:06:10 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2016-09-21 11:40:04 +00:00)
Target Version: 2.6.0
Last Update: 2016-11-18 14:23:50 +00:00 (in Redmine)

Icinga Version: 2.5.4
Backport?: Not yet backported
Include in Changelog: 1

Since update on 2.5.x passing arguments to the NSClient do not work like expected. You have to add "-a" to every argument.

vars.nscp_services.nscp_service_arguments = [
"-a", "exclude=sppsvc", "-a", "exclude=ShellHWDetection" ]

apply Service "Services" {
Import "generic-service"
check_command = "nscp-local-service"
vars += host.vars.sevices
}

Attachments

Changesets

2016-09-21 08:23:20 +00:00 by Marax 483b8a5

ITL: Fix problem with passing arguments to NSClient++

There was a problem with passing arguments to the NSClient++
which is fixed by changing the skip_key staement by the repeat_key
statement in the "-a" key of the dictionary. Further details can be
found in issue #12747 ITL - Problems passing arguments/parameters to
NSClient++

fixes #12747

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2016-09-21 08:23:44 +00:00 by mfriedrich df8a408

Update AUTHORS

refs #12747
@icinga-migration
Copy link
Author

Updated by Marax on 2016-09-19 12:19:52 +00:00

  • File added 0001-Fixed-problem-with-passing-arguments-to-NSClient.patch

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-09-19 13:36:53 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mfriedrich
  • Target Version set to 2.6.0

Thanks, I'll look into that. I didn't see the repeat_key vs skip_key problem, and am investigating on some NSClient** upgrades already.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-09-20 15:56:46 +00:00

Tests were good, I now get the real issue. Still fiddling with some other NSClient** stuff I want to push (0.5.0). Hopefully finished by tomorrow.

@icinga-migration
Copy link
Author

Updated by Marax on 2016-09-21 11:40:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 483b8a5.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-11-18 14:23:50 +00:00

  • Subject changed from ITL - Problems passing arguments/parameters to NSClient++ to Problem passing arguments to nscp-local CheckCommand objects

@icinga-migration icinga-migration added bug Something isn't working area/itl Template Library CheckCommands labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.6.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/itl Template Library CheckCommands bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant