Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #12094] custom field with "-" in name must be possible #338

Closed
icinga-migration opened this issue Jul 5, 2016 · 6 comments
Labels
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12094

Created by Tuxdiver on 2016-07-05 09:21:49 +00:00

Assignee: tgelf
Status: Resolved (closed on 2016-11-08 01:05:03 +00:00)
Target Version: 1.3.0
Last Update: 2016-11-08 01:05:03 +00:00 (in Redmine)


It is possible to create a custom field with a "" in its name. The "" is replaced later, but the director frontend does not work correctly, if you try to set the field on a host object. Using this "feature" with a boolean field type gives very strange results (var contains the charater "y" or "n" after assigning it on a host object, but form does not show it)

Solution: check the field name for "-" characters and deny the submit of the form

Changesets

2016-11-08 01:00:38 +00:00 by tgelf 63bf607

IcingaObjectFieldLoader: allow exotic var names

fixes #12094
fixes #12962

Relations:

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-07-26 12:18:59 +00:00

They should IMO absolutely be possible. To me the fact that they currently fail is a bug. I implemented rendering them a few days ago with 4e083d7, still have to fix a problem with the handling of related form fields.

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-10-24 04:41:49 +00:00

  • Target Version set to 1.2.0

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-11-02 10:17:48 +00:00

  • Relates set to 13002

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-11-03 12:39:18 +00:00

  • Target Version changed from 1.2.0 to 1.3.0

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-11-08 00:47:13 +00:00

  • Subject changed from custom field with "-" in name must not be possible to custom field with "-" in name must be possible
  • Status changed from New to Assigned
  • Assigned to set to tgelf

@icinga-migration
Copy link
Author

Updated by tgelf on 2016-11-08 01:05:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 63bf607.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant