[dev.icinga.com #12061] Add check command definition for db2_health

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/12061

Created by cark on 2016-06-28 10:26:48 +00:00

Assignee: cark
Status: Resolved (closed on 2016-08-09 12:25:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-08-22 11:53:44 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

---

apply for default

Attachments

• db2_health.conf cark - 2016-06-28 10:26:44 +00:00
• 7-icinga-template-library.md.patch cark - 2016-07-19 13:16:36 +00:00
• databases.conf.patch cark - 2016-07-19 13:16:36 +00:00

Changesets

2016-08-09 12:20:08 +00:00 by cark f0dbcab

ITL: Add db2_health CheckCommand definition

fixes #12061

2016-08-09 12:20:23 +00:00 by mfriedrich 1e9adc0

Update AUTHORS

refs #12061

[icinga-migration]

Updated by gbeutner on 2016-07-06 06:13:10 +00:00

• Status changed from New to Assigned
• Assigned to set to cark

Can you please attach a patch in the format that's used by "git format-patch" to this ticket? Also, your patch is missing documentation.

[icinga-migration]

Updated by cark on 2016-07-19 13:17:14 +00:00

• File added databases.conf.patch
• File added 7-icinga-template-library.md.patch

Hopefully i did everything correct, here are the patches.

[icinga-migration]

Updated by mfriedrich on 2016-08-09 12:19:55 +00:00

• Target Version set to 2.5.0

Thanks for the patch. I'd prefer a git formatted patch (git commit ... and git format-patch -1 or if you prefer github, a pull request) next time.

A few remarks on the patch itself:

• db2_home -> that doesn't follow the guidelines to use the check name as prefix for custom attributes. since these are specific env variables for that plugin, I've chosen to go for "db2_health_env_" as prefix plus the lower case env variable name. Might sound overly complicated but still allows you to determine the variable's target on a host level.
• docs use DB2_ instead of db2_ in the attribute definitions
• Environment macros are not needed since you specifically set them using custom attributes. Modified the table to just add these two additional parameters.

Thanks for the initial patch, I liked it a lot therefore collecting it into 2.5 with my own fixes applied but using your name as author.

[icinga-migration]

Updated by cark on 2016-08-09 12:25:04 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset f0dbcab.

[icinga-migration]

Updated by gbeutner on 2016-08-22 11:53:44 +00:00

• Subject changed from db2_health command configuration to Add check command definition for db2_health