Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #10937] High CPU usage with self-referenced parent zone config #3820

Closed
icinga-migration opened this issue Jan 6, 2016 · 10 comments
Labels
area/configuration DSL, parser, compiler, error handling bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10937

Created by nmm on 2016-01-06 14:02:13 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2016-03-23 08:05:04 +00:00)
Target Version: 2.5.0
Last Update: 2016-06-22 12:07:35 +00:00 (in Redmine)

Icinga Version: 2.4.1
Backport?: Not yet backported
Include in Changelog: 1

Dear Developers,

When one introduces a bad configuration on zones.conf and sets 'master' with the information of the client (instead of master) the icinga2 process produces incredibly high CPU usage. In my case I introduced a bad configuration and defined 'master' as the 'client' and the icinga2 process took 100% on all 16 cpu's on the server.

Would it be possible during 'icinga2 daemon --validate' that icinga could validate zones.conf for configuration issues like this one?

Kindest regards,
NMM

FYI:
[root@etmon eurotux]# rpm -qi icinga2
Name : icinga2
Version : 2.4.1
Release : 1.el7.centos
Architecture: x86_64
Install Date: Fri 11 Dec 2015 10:19:09 AM WET
Group : Applications/System
Size : 17986
License : GPL-2.0+
Signature : DSA/SHA1, Thu 26 Nov 2015 12:38:57 PM WET, Key ID c6e319c334410682
Source RPM : icinga2-2.4.1-1.el7.centos.src.rpm
Build Date : Thu 26 Nov 2015 12:38:46 PM WET
Build Host : jenkins-build-5c74b3d4-1984
Relocations : (not relocatable)
URL : https://www.icinga.org/
Summary : Network monitoring application
Description :
Meta package for Icinga 2 Core, DB IDO and Web.

Changesets

2016-03-23 08:03:53 +00:00 by (unknown) b621b00

Detect infinite recursion in the zone hierarchy graph

fixes #10937

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-01-11 10:06:25 +00:00

  • Status changed from New to Feedback
  • Assigned to set to nmm

How exactly does that configuration look like?

@icinga-migration
Copy link
Author

Updated by nmm on 2016-01-11 11:51:37 +00:00

dnsmichi wrote:

How exactly does that configuration look like?

This should be the correct configuration (no issues):
object Endpoint "foo.bar" {
host = "172.16.1.100"
}

object Zone "foo.bar" {
endpoints = [ "foo.bar" ]
parent = "master"
}

Wrong configuration that bursts down CPU:
object Endpoint "foo.bar" {
host = "172.16.1.100"
}

object Zone "foo.bar" {
endpoints = [ "foo.bar" ]
parent = "foo.bar"
}

Basically, setting parent to host will increase CPU to top.

Best Regards,
NMM

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-01-11 12:46:16 +00:00

  • Relates set to 9491

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-01-11 12:46:25 +00:00

  • Relates set to 7155

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-01-11 12:47:04 +00:00

  • Status changed from Feedback to New
  • Assigned to deleted nmm

Self-import or reference of objects is currently not properly implemented, I've linked the other issues.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-01-29 09:51:49 +00:00

  • Subject changed from High CPU usage with wrong 'master' configuration on zones.conf to High CPU usage with self-referenced parent zone config
  • Target Version set to Backlog

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-03-18 14:52:39 +00:00

  • Status changed from New to Assigned
  • Assigned to set to gbeutner

Hi Gunnar,

can you please have a look and also include the other two linked issues?

Thanks,
Michael

@icinga-migration
Copy link
Author

Updated by gbeutner on 2016-03-23 08:04:42 +00:00

  • Relates deleted 7155

@icinga-migration
Copy link
Author

Updated by Anonymous on 2016-03-23 08:05:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset b621b00.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-06-22 12:07:35 +00:00

  • Target Version changed from Backlog to 2.5.0

@icinga-migration icinga-migration added bug Something isn't working area/configuration DSL, parser, compiler, error handling labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.5.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration DSL, parser, compiler, error handling bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant