[dev.icinga.com #10777] Add check_iostat to ITL

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10777

Created by twidhalm on 2015-12-05 19:43:47 +00:00

Assignee: jflach
Status: Resolved (closed on 2016-02-19 11:19:11 +00:00)
Target Version: 2.4.2
Last Update: 2016-02-23 10:24:37 +00:00 (in Redmine)

Backport?: Already backported
Include in Changelog: 1

---

Hi,

I'd like to see the check_iostat version patched by dnsmichi as part of the ITL. Attached is a patch to add it.

Please be nice, since this is my first contribution - I'm willing to improve if you tell me if I'm doing something wrong.

Cheers,
Thomas

Attachments

• check_iostat.patch twidhalm - 2015-12-05 19:42:54 +00:00
• 0001-Add-check_iostat-to-ITL.patch twidhalm - 2015-12-07 10:27:51 +00:00

Changesets

2016-02-19 11:18:33 +00:00 by twidhalm b7d55fc

Add check_iostat to ITL

fixes #10777

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>

2016-02-22 07:05:23 +00:00 by (unknown) 781c34f

Update AUTHORS

refs #10777
refs #11132

2016-02-23 08:45:34 +00:00 by (unknown) ed9a7bb

Update AUTHORS

refs #10777
refs #11132

2016-02-23 08:47:28 +00:00 by twidhalm fd0aa4a

Add check_iostat to ITL

fixes #10777

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>

[icinga-migration]

Updated by gbeutner on 2015-12-07 07:05:18 +00:00

• Status changed from New to Assigned
• Assigned to set to twidhalm

1. Your patch adds a new, unrelated file:

   diff --git a/0001-Add-check_iostat-to-ITL.patch b/0001-Add-check_iostat-to-ITL.patch
   new file mode 100644
   index 0000000..fbc3a29
   --- /dev/null
   +++ b/0001-Add-check_iostat-to-ITL.patch

2. The documentation should mention the default values (if there are any).

3. We're using tabs in the ITL files.

4. It is unnecessary to put quotes around numbers.

5. contrib plugins should use the PluginContribDir constant

6. Wording: "The plugin ... is a plugin" seems kinda redundant (in the documentation)

[icinga-migration]

Updated by twidhalm on 2015-12-07 10:28:00 +00:00

• File added 0001-Add-check_iostat-to-ITL.patch

Here you are.

[icinga-migration]

Updated by gbeutner on 2016-01-11 10:20:28 +00:00

• Assigned to changed from twidhalm to jflach

[icinga-migration]

Updated by twidhalm on 2016-02-19 11:19:11 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset b7d55fc.

[icinga-migration]

Updated by jflach on 2016-02-19 11:19:35 +00:00

• Target Version set to 2.5.0

[icinga-migration]

Updated by gbeutner on 2016-02-23 09:58:21 +00:00

• Backport? changed from Not yet backported to Already backported

[icinga-migration]

Updated by gbeutner on 2016-02-23 10:24:37 +00:00

• Target Version changed from 2.5.0 to 2.4.2