[dev.icinga.com #10683] lib/CLI command web serve: rename variable basedir to something meaningful

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/10683

Created by aklimov on 2015-11-19 17:47:29 +00:00

Assignee: (none)
Status: Resolved (closed on 2015-11-20 17:45:04 +00:00)
Target Version: 2.1.1
Last Update: 2015-12-10 12:26:12 +00:00 (in Redmine)

---

As a user I have no idea what a "basedir" is. I could think it's the source root dir (/vagrant) or similar.
My suggestion: wwwroot

Changesets

2015-11-20 17:05:42 +00:00 by aklimov 1515430

WebCommand::serveAction(): rename parameter $basedir to $documentRoot

resolves #10683

[icinga-migration]

Updated by elippmann on 2015-11-20 08:50:31 +00:00

• Assigned to deleted tgelf
• Target Version set to Backlog

Just for the records. we're using --root or --document-root in the config command.

[icinga-migration]

Updated by elippmann on 2015-11-20 08:51:24 +00:00

• Tracker changed from Bug to Feature

[icinga-migration]

Updated by aklimov on 2015-11-20 17:45:04 +00:00

• Status changed from New to Resolved
• Done % changed from 0 to 100

Applied in changeset 1515430.

[icinga-migration]

Updated by elippmann on 2015-11-23 08:26:55 +00:00

• Subject changed from CLI command web serve: rename parameter basedir to something meaningful to CLI command web serve: rename variable basedir to something meaningful
• Target Version changed from Backlog to 273

[icinga-migration]

Updated by elippmann on 2015-12-10 12:26:12 +00:00

• Tracker changed from Feature to Bug
• Subject changed from CLI command web serve: rename variable basedir to something meaningful to lib/CLI command web serve: rename variable basedir to something meaningful
• Target Version changed from 273 to 2.1.1