Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9972] Icinga2 - too many open files - Exception #3305

Closed
icinga-migration opened this issue Aug 21, 2015 · 7 comments
Closed
Labels
area/configuration DSL, parser, compiler, error handling bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9972

Created by elabedzki on 2015-08-21 07:18:44 +00:00

Assignee: gbeutner
Status: Resolved (closed on 2015-08-24 09:08:22 +00:00)
Target Version: 2.3.9
Last Update: 2015-08-26 06:25:37 +00:00 (in Redmine)

Icinga Version: v2.3.8
Backport?: Already backported
Include in Changelog: 1

Hi guys,

we have a problem with loading the config fragments exported through lconf ( 1.5.1 ), which produces to many config fragments, so that the icinga2 core can not deal with.

We have tried something like increasing the OS limits "open files" which has currently a value of 500000 for the nagios/icinga user, but it doesn't help.

We need a patch either for icinga2 core ( so he can handle it ) or for lconf ( so he can maybe merge that config fragments to one file ).

Kind regards
Enrico

Changesets

2015-08-24 09:04:26 +00:00 by (unknown) 6a8f890

Remove the FutureExpression class

fixes #9972

2015-08-26 04:57:24 +00:00 by (unknown) 1f63bcb

Remove unused argument 'async'

refs #9972

2015-08-26 05:10:34 +00:00 by (unknown) 73ed46f

Remove the FutureExpression class

fixes #9972

Relations:

@icinga-migration
Copy link
Author

Updated by mfrosch on 2015-08-24 07:46:15 +00:00

  • Description updated
  • Is Private changed from 1 to 0

The actual error is:

information/ConfigCompiler: Compiling config file: /usr/local/LConf/tmp/lconfexport.tmp/test/Commands/vcc-server/check_win_service_vcc_datastore.conf
information/ConfigCompiler: Compiling config file: /usr/local/LConf/tmp/lconfexport.tmp/test/Commands/vcc-server/check_win_service_vcc_erm_service_ncc.conf
critical/config: Error: Function call 'std::ifstream::open' for file '/usr/local/LConf/tmp/lconfexport.tmp/test/Commands/vcc-server/check_win_service_vcc_ivr.conf' failed with error code 24, 'Too many open files'
information/ConfigCompiler: Compiling config file: /usr/share/icinga2/include/command-plugins.conf
Icinga 2 config verification failed. Aborting...

@icinga-migration
Copy link
Author

Updated by mfrosch on 2015-08-24 07:48:09 +00:00

Seems like we are currently not explicity closing the file streams after reading the file.

I think we should do that, or would we need the individual file streams after reading the contents in the beginning?

@icinga-migration
Copy link
Author

Updated by mfrosch on 2015-08-24 07:58:28 +00:00

From my understanding the lexer gets direct access to the streams.

I suggest we read the files into memory before handing a stream to the lexer. Similar to CompileText

@icinga-migration
Copy link
Author

Updated by Anonymous on 2015-08-24 09:08:22 +00:00

  • Status changed from New to Resolved
  • Done % changed from 0 to 100

Applied in changeset 6a8f890.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-08-24 09:08:49 +00:00

  • Assigned to set to gbeutner
  • Target Version set to 2.4.0

Fixed in the master branch. Please test this so we can backport this into 2.3.x.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-08-26 06:25:38 +00:00

  • Target Version changed from 2.4.0 to 2.3.9
  • Backport? changed from TBD to Yes

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-10-26 12:04:38 +00:00

  • Relates set to 10461

@icinga-migration icinga-migration added bug Something isn't working area/configuration DSL, parser, compiler, error handling labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.3.9 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration DSL, parser, compiler, error handling bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant