Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9894] missing "close-Button" in pnp4nagios Module (Icinga Web 2 Frame) #14

Closed
icinga-migration opened this issue Aug 13, 2015 · 8 comments
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9894

Created by smadmin on 2015-08-13 08:57:58 +00:00

Assignee: tgelf
Status: Resolved (closed on 2017-01-02 16:10:03 +00:00)
Target Version: 1.1.0
Last Update: 2017-01-02 16:10:03 +00:00 (in Redmine)


Hello guys,

in the pnp4nagios Icinga Web 2 module, i missed the closed-Button (X) in Icinga Web 2 Frame on the right site.
Can you put in in pnp4nagios?

See picture.

Sascha

Attachments

Changesets

2017-01-02 16:04:40 +00:00 by (unknown) 7927284

Add default controls

fixes #9894

Relations:

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-08-13 09:03:46 +00:00

  • Project changed from Icinga Web 2 to 58
  • Category deleted 133

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-11-20 12:32:37 +00:00

  • Project changed from 58 to PNP

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-12-16 19:15:23 +00:00

  • Blocked set to 10871

@icinga-migration
Copy link
Author

Updated by tgelf on 2015-12-16 19:16:34 +00:00

The fix would be pretty simple, just add

<?= $this->tabs ?>

to application/views/scripts/index/index.phtml. However this would result in ugly doubled scroll bars right now. Waiting for the related web2 bug before continuing here.

Cheers,
Thomas

@icinga-migration
Copy link
Author

Updated by Konne on 2016-04-21 20:58:47 +00:00

Its time to put this line in the next release. Bug #10871 is already resolved.
Today we tested it with icinga web 2.2.0 and it works just fine. No ugly scrollbars.

@icinga-migration
Copy link
Author

Updated by mnardin on 2017-01-02 15:57:54 +00:00

Hi,
I've created a pull request for this issue: #3

If only I would have seen the hint from tgelf earlier :)

Cheers
Mirko

@icinga-migration
Copy link
Author

Updated by tgelf on 2017-01-02 16:05:45 +00:00

  • Status changed from New to Assigned
  • Assigned to set to tgelf
  • Target Version set to 1.1.0

@icinga-migration
Copy link
Author

Updated by Anonymous on 2017-01-02 16:10:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 7927284.

@icinga-migration icinga-migration added this to the 1.1.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant