Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9859] Implement global modified attributes #3238

Closed
icinga-migration opened this issue Aug 6, 2015 · 8 comments
Closed
Labels
area/api REST API enhancement New feature or request
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9859

Created by mfriedrich on 2015-08-06 20:21:14 +00:00

Assignee: mfriedrich
Status: Resolved (closed on 2015-09-23 13:05:04 +00:00)
Target Version: 2.4.0
Last Update: 2015-09-24 20:09:59 +00:00 (in Redmine)

Backport?: No
Include in Changelog: 1

We must find a way similar to object modified attributes as alternative to ScriptGlobal::Set().

Changes

Enable* and Vars as global constant are deprecated/removed. Use the IcingaApplication object attributes instead.

Changesets

2015-09-22 16:18:29 +00:00 by mfriedrich 21dff5e

Implement global modified attributes for the IcingaApplication class (WIP)

refs #9859

2015-09-23 13:02:53 +00:00 by mfriedrich 84536da

Implement global modified attributes for the IcingaApplication class

fixes #9859

Parent Task: #9081

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-08-11 06:27:49 +00:00

We could just add attributes to the IcingaApplication class (enable_event_handlers, enable_host_checks, ...) and implement support for making the existing variables aliases for those attributes.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-04 12:04:56 +00:00

  • Assigned to set to mfriedrich

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-04 12:05:07 +00:00

  • Status changed from New to Assigned

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-22 16:21:01 +00:00

There's a couple of benefits we would get from that:

  • IcingaApplication attributes visible through the API
  • these objects can be just modified through the API
  • IcingaApplication inherits from Object, therefore we'll have the On*Changed signals available, similar to OnVersionChanged which would allow special updates for DB IDO

There's only one exception we need to keep in mind - NodeName needs to be set inside the StaticInitialize() method in order having it available in constants.conf

I've pushed a test branch to feature/global-mod-attr-9859

Maybe we should also consider deprecating the Enable* constants, and let users set the Icingaapplicakion object attributes (which is always loaded currently).

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-23 13:05:04 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 84536da.

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-23 13:05:47 +00:00

  • Description updated

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-24 20:09:33 +00:00

  • Backport? changed from TBD to No

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-09-24 20:09:59 +00:00

  • Include in Changelog changed from 0 to 1

@icinga-migration icinga-migration added enhancement New feature or request area/api REST API labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.4.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api REST API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant