New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #9777] Make Comments and Downtime types available as ConfigObject type in the API #3197
Comments
Updated by gbeutner on 2015-07-30 06:05:18 +00:00
|
Updated by gbeutner on 2015-08-15 18:14:35 +00:00
|
Updated by mfriedrich on 2015-08-17 08:53:12 +00:00
|
Updated by mfriedrich on 2015-09-04 11:58:17 +00:00
|
Updated by mfriedrich on 2015-09-12 09:08:37 +00:00
|
Updated by mfriedrich on 2015-09-14 12:37:58 +00:00 Apart from the scheduled downtime object DB IDO currently tries to insert additional downtimes, which make little sense. DELETE FROM icinga\_scheduleddowntime WHERE object\_id = 108; INSERT INTO icinga\_scheduleddowntime (author\_name, comment\_data, downtime\_type, duration, endpoint\_object\_id, entry\_time, instance\_id, internal\_downtime\_id, is\_fixed, is\_in\_effect, object\_id, was\_started) VALUES ('', '', '1', '0', 96, FROM\_UNIXTIME(1442233761), 1, '0', '0', '0', 108, '0'); INSERT INTO icinga\_scheduleddowntime (author\_name, comment\_data, downtime\_type, duration, endpoint\_object\_id, entry\_time, instance\_id, internal\_downtime\_id, is\_fixed, is\_in\_effect, object\_id, was\_started) VALUES ('', '', '1', '0', 96, FROM\_UNIXTIME(1442233761), 1, '0', '0', '0', 108, '0'); INSERT INTO icinga\_scheduleddowntime (author\_name, comment\_data, downtime\_type, duration, endpoint\_object\_id, entry\_time, instance\_id, internal\_downtime\_id, is\_fixed, is\_in\_effect, object\_id, was\_started) VALUES ('', '', '1', '0', 96, FROM\_UNIXTIME(1442233761), 1, '0', '0', '0', 108, '0'); INSERT INTO icinga\_scheduleddowntime (author\_name, comment\_data, downtime\_type, duration, endpoint\_object\_id, entry\_time, instance\_id, internal\_downtime\_id, is\_fixed, is\_in\_effect, object\_id, scheduled\_end\_time, scheduled\_start\_time, was\_started) VALUES ('icingaadmin', 'Scheduled downtime for backup', '1', '0', 96, FROM\_UNIXTIME(1442233761), 1, '1', '1', '0', 108, FROM\_UNIXTIME(1442278800), FROM\_UNIXTIME(1442275200), '0'); </pre |
Updated by mfriedrich on 2015-09-14 12:40:58 +00:00 Ok nvm, I had to delete the state file containing faulty downtimes from previous tests. |
Updated by mfriedrich on 2015-09-14 12:53:14 +00:00 Ok, found it: While adding downtimes during runtime, they are not persisted on disk. The state file only stores [state] attributes and stores/restores invalid Downtime and Comments.
|
Updated by mfriedrich on 2015-09-14 12:56:45 +00:00
Not sure how we should proceed here further, that depends on the object config sync branch. |
Updated by mfriedrich on 2015-09-17 12:03:21 +00:00
|
Updated by mfriedrich on 2015-09-28 12:57:07 +00:00
|
Updated by mfriedrich on 2015-10-19 09:42:00 +00:00
|
Updated by gbeutner on 2015-10-22 08:56:16 +00:00
|
Updated by gbeutner on 2015-10-27 08:35:57 +00:00 TODO:
|
Updated by mfriedrich on 2015-10-27 11:26:29 +00:00
|
Updated by mfriedrich on 2015-10-27 11:35:02 +00:00
|
Updated by mfriedrich on 2015-10-27 14:45:24 +00:00
|
Updated by mfriedrich on 2015-10-27 15:08:35 +00:00 TODO
|
Updated by mfriedrich on 2015-10-27 16:50:38 +00:00 Changed the code for comments similar to downtimes and tested those changes. TODO for 28.10.+
|
Updated by mfriedrich on 2015-10-28 09:15:56 +00:00
|
Updated by gbeutner on 2015-10-28 09:59:25 +00:00 TODO:
|
Updated by mfriedrich on 2015-10-28 14:05:29 +00:00
|
Updated by mfriedrich on 2015-10-28 14:15:06 +00:00
|
Updated by mfriedrich on 2015-10-28 15:19:01 +00:00 Changing the parameter for Remove* from String to a pointer does not make sense. Done
TODO
Tests
|
Updated by mfriedrich on 2015-10-28 15:19:14 +00:00
|
Updated by mfriedrich on 2015-10-28 15:19:46 +00:00
Remaining tasks for tomorrow. |
Updated by mfriedrich on 2015-10-28 15:55:48 +00:00 Downtimes are triggered
|
Updated by mfriedrich on 2015-10-28 16:26:31 +00:00
|
Updated by mfriedrich on 2015-10-28 16:48:21 +00:00 Done
|
Updated by mfriedrich on 2015-10-28 16:49:51 +00:00 I'm not sure if we really need a default value for ignore_on_error anymore since we are now passing that value via the API create object method. The inner defaults inside Add* and Remove* are set to true where they belong to. |
Updated by mfriedrich on 2015-10-28 16:51:58 +00:00 Further TODOs:
|
Updated by Anonymous on 2015-10-28 17:00:05 +00:00
Applied in changeset 050c520. |
Updated by mfriedrich on 2015-11-12 15:34:38 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/9777
Created by gbeutner on 2015-07-30 06:03:10 +00:00
Assignee: mfriedrich
Status: Resolved (closed on 2015-10-28 17:00:05 +00:00)
Target Version: 2.4.0
Last Update: 2015-11-12 15:34:38 +00:00 (in Redmine)
That way we wouldn't have to add special cases for these object types in the API.
Changesets
2015-10-28 16:56:29 +00:00 by (unknown) 050c520
2015-10-29 07:14:55 +00:00 by (unknown) 0013d26
Relations:
The text was updated successfully, but these errors were encountered: