Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9619] Acknowledge: Persistent Comment is removed on status change or acknowledgement remove #3146

Closed
icinga-migration opened this issue Jul 14, 2015 · 8 comments
Labels
bug Something isn't working

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9619

Created by Foxeronie on 2015-07-14 18:51:35 +00:00

Assignee: (none)
Status: New
Target Version: Backlog
Last Update: 2016-12-07 22:23:44 +00:00 (in Redmine)

Icinga Version: v2.3.4

Hi!

I checked the "Persistent Comment" box for some acknowledgement's, but the comment is always gone when the status changes or someone removes the acknowledgement.

I'm using Icinga Web 2
commit 8b4c2c459a92d1bebc6114a13cc4690e95491223
Author: Johannes Meyer <johannes.meyer@netways.de>
Date: Mon Jul 13 12:51:50 2015 +0200

Cheers,
Patrick


Relations:

@icinga-migration
Copy link
Author

Updated by jmeyer on 2015-07-15 07:20:25 +00:00

  • Project changed from Icinga Web 2 to Icinga 2
  • Icinga Version set to v2.3.4

Hi Foxeronie,

I was able to reproduce this, but this is an issue in Icinga 2, not Icinga Web 2. Thanks for the report though.

Moved to the Icinga 2 project.

Best regards,
Johannes

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-07-24 18:10:18 +00:00

  • Target Version set to Backlog

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-08-06 20:33:18 +00:00

  • Category set to libicinga

@icinga-migration
Copy link
Author

Updated by seferovic on 2015-12-03 11:22:40 +00:00

I just ran into this bug when my coworker asked me, why are there no acknowledgement comments in the web interface... We reproduced this behavior. Every time Icinga2 after a reload, the table "icinga_comments" is truncated (empty). Also a non persistent comment is marked as persistent ..

MariaDB [icinga]> select comment_data, is_persistent from icinga_comments;
+-----------------------------------+---------------+
| comment_data                      | is_persistent |
+-----------------------------------+---------------+
| Non persistant acknowledgement... |             1 |
+-----------------------------------+---------------+
1 row in set (0.00 sec)

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-01-28 13:32:45 +00:00

  • Relates set to 11035

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-12-07 22:05:05 +00:00

  • Relates set to 13377

@icinga-migration
Copy link
Author

Updated by TheFlyingCorpse on 2016-12-07 22:23:44 +00:00

Note: the persistent is flagged as persistent in the database, regardless of what you set in IcingaWeb2.
I have submitted a patch in #13377 that doesnt fix the data in IDO but it does fix that comments are removed when you flag the comment in the ack as persistent, now they stay even when the ack expires or the service/host returns ok/up.

@icinga-migration icinga-migration added bug Something isn't working libicinga labels Jan 17, 2017
@icinga-migration icinga-migration added this to the Backlog milestone Jan 17, 2017
@dnsmichi
Copy link
Contributor

dnsmichi commented Aug 2, 2017

That's fixed in v2.7.0

@dnsmichi dnsmichi closed this as completed Aug 2, 2017
@dnsmichi dnsmichi removed this from the Backlog milestone Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants