[dev.icinga.com #9615] Hardcoded PHP and gettext tools path

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9615

Created by xert on 2015-07-14 10:06:50 +00:00

Assignee: elippmann
Status: Resolved (closed on 2015-07-31 09:35:04 +00:00)
Target Version: 2.0.0
Last Update: 2015-07-31 09:35:04 +00:00 (in Redmine)

---

There is hard coded path to php in bin/icingacli and to gettext tools (msgmerge, xgettext, msgfmt) in modules/translation/library/Translation/Util/GettextTranslationHelper.php.

On some systems (FreeBSD for example) the hard coded paths are not valid.

I've created a pull request for the shebang (using env).

Related (rejected) issue: https://dev.icinga.org/issues/7789

Changesets

2015-07-30 13:47:35 +00:00 by elippmann 219dcdd

translation: Set config on the translation helper

Installations from package will provide a config for the translation module which defines the appropriate gettext tools paths.

refs #9615

2015-07-30 13:51:41 +00:00 by elippmann 7160eb6

translation: Load msgmerge path from config or default to /usr/bin/env msgmerge

refs #9615

2015-07-30 13:53:13 +00:00 by elippmann c9c97f3

translation: Load xgettext path from config or default to /usr/bin/env xgettext

refs #9615

2015-07-30 13:53:39 +00:00 by elippmann d4c7261

translation: Fix msgmerge default

refs #9615

2015-07-30 13:55:05 +00:00 by elippmann 8d137aa

translation: Load msgfmt path from config or default to /usr/bin/env msgfmt

refs #9615

2015-07-30 13:57:21 +00:00 by elippmann b9f16b8

translation: Add config file for packages

refs #9615

2015-07-30 14:32:00 +00:00 by elippmann cc0dfed

RPM: Install translation config

refs #9615

2015-07-31 09:30:26 +00:00 by elippmann 834017f

translation: Always use the correct path to the Icinga library in the translation helper

refs #9615

2015-07-31 09:31:54 +00:00 by elippmann f4c7fd5

Merge branch 'bugfix/env-in-source-9615'

fixes #9615

---

Relations:

• relates #9615

[icinga-migration]

Updated by elippmann on 2015-07-16 09:35:52 +00:00

• Subject changed from Hardcoded paths to Hardcoded PHP path
• Target Version set to 2.0.0

We had a discussion before where I disapproved the use of env in our git too. But for those who run Icinga Web 2 from a git clone using env is ok for me now. In addition we must provide the scripts for packagers w/ the correct path to the interpreter.

[icinga-migration]

Updated by xert on 2015-07-16 09:49:39 +00:00

Just a little notice - as I mentioned in the description - the issue is not only php path but also gettext tools. Please let me know if I should create separate issue for this.

[icinga-migration]

Updated by elippmann on 2015-07-16 09:55:29 +00:00

• Subject changed from Hardcoded PHP path to Hardcoded PHP and gettext tools path

Ooops. Sorry, fixed the subject.

xert wrote:

Just a little notice - as I mentioned in the description - the issue is not only php path but also gettext tools. Please let me know if I should create separate issue for this.

[icinga-migration]

Updated by elippmann on 2015-07-20 08:07:17 +00:00

• Estimated Hours set to 2

[icinga-migration]

Updated by elippmann on 2015-07-20 08:10:55 +00:00

• Priority changed from Normal to High

[icinga-migration]

Updated by elippmann on 2015-07-30 13:08:18 +00:00

• Status changed from New to Assigned
• Assigned to set to elippmann

[icinga-migration]

Updated by icinga-kanban on 2015-07-31 09:32:53 +00:00

Build !#857 triggered by commit 834017f passed successfully.

Branch: origin/bugfix/env-in-source-9615
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2015-07-31 09:34:43 +00:00

Build !#906 triggered by the commits f4c7fd5, 834017f, cc0dfed, b9f16b8, 8d137aa, d4c7261, c9c97f3, 7160eb6, 219dcdd, cf91478 passed successfully.

Branch: origin/master
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2015-07-31 09:34:52 +00:00

• Relates set to 9800

[icinga-migration]

Updated by elippmann on 2015-07-31 09:35:04 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset f4c7fd5.