New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #9527] CheckCommand for check_interfaces #3111
Comments
Updated by gbeutner on 2015-06-30 06:23:52 +00:00
Please attach a patch which is in the same format that's used by 'git format-patch'. |
Updated by lbetz on 2015-07-06 09:32:21 +00:00
git format-patch -1 83f6e3764a74dd7d11675c0670cedab195a84d1f |
Updated by mfriedrich on 2015-07-06 15:05:59 +00:00 Please fix the indent -> 1 tab instead of 2 spaces. |
Updated by lbetz on 2015-07-06 16:20:19 +00:00 I added it to a file named itl/plugins-contrib.d/network-components.conf with to more check command. This to also have an ident of two spaces? So should I correct all of them? |
Updated by mfriedrich on 2015-07-07 07:50:13 +00:00
The indent is totally fine in this file. I'd say your editor cannot handle the indent properly and always saves 2 spaces. Aside from that, please create an issue and git patch for each new CheckCommand and kindly ask Dirk for the final review. |
Updated by lbetz on 2015-07-07 12:30:43 +00:00
Sorry Michi, had to be the temperature yesterday. Copy'n'paste is a worst thing.... now, next try with set tabs manually. |
Updated by mfriedrich on 2015-07-24 18:27:53 +00:00
|
Updated by lbetz on 2015-07-27 08:56:25 +00:00
next run... |
Updated by lbetz on 2015-07-27 14:19:03 +00:00 damn again.It's in a wrong category, too. I will correct this. |
Updated by lbetz on 2015-08-02 05:37:45 +00:00
correct ident and doc section. |
Updated by mfriedrich on 2015-08-03 16:05:55 +00:00
Merged, thanks. |
Updated by lbetz on 2015-08-03 16:10:03 +00:00
Applied in changeset 8d11b74. |
Updated by gbeutner on 2015-08-17 06:58:56 +00:00
|
This issue has been migrated from Redmine: https://dev.icinga.com/issues/9527
Created by lbetz on 2015-06-29 15:08:38 +00:00
Assignee: lbetz
Status: Resolved (closed on 2015-08-03 16:10:03 +00:00)
Target Version: 2.3.9
Last Update: 2015-08-17 06:58:56 +00:00 (in Redmine)
Contrib plugin from https://www.netways.org/projects/check-interfaces
Attachments
Changesets
2015-08-03 16:05:09 +00:00 by lbetz 8d11b74
2015-08-17 06:58:14 +00:00 by lbetz 49cf0bb
The text was updated successfully, but these errors were encountered: