New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #9211] Empty filters are being rendered to SQL which leads to syntax errors #1634
Comments
Updated by jamesweakley on 2015-05-01 06:32:02 +00:00 Pull request: #26 |
Updated by tgelf on 2015-05-01 10:09:05 +00:00
Good catch, thank you. May I ask whether you used the available Puppet modules for installation? I'd like to find the root cause for this and similar issues. I guess you have something like...
...in your roles.ini. While Icinga Web should be able to cope with this I do not really want such useless config to be generated at all. Best, |
Updated by jamesweakley on 2015-05-01 21:45:25 +00:00 Yep, nailed it, that's exactly what I have due to using puppet for installation. I spent a while digging around the code base trying to find where the empty filter was finding its way into the clause, being completely new to icinga I didn't even think of those files and didn't realise that: In the end I gave up and worked around it downstream as you can see. I'll look at wrapping the host and service filter stuff in: In future, I'll also include a unit test case with the icingaweb2 pull requests. |
Updated by jamesweakley on 2015-05-03 03:46:16 +00:00 Pull request for puppet fix: |
Updated by elippmann on 2015-05-22 11:53:32 +00:00
Hi, I changed the subject because it's bug in our framework. We're rendering empty filters which leads to syntax errors. I'll fix it in a second. Cheers, |
Updated by elippmann on 2015-05-22 14:55:04 +00:00
Applied in changeset 83a6e85. |
This issue has been migrated from Redmine: https://dev.icinga.com/issues/9211
Created by jamesweakley on 2015-05-01 06:13:31 +00:00
Assignee: elippmann
Status: Resolved (closed on 2015-05-22 14:55:04 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-05-22 14:55:04 +00:00 (in Redmine)
Did a fresh installation with a Postgres backend, using the following packages:
postgresql93-server.x86_64 9.3.6-1PGDG.rhel6
yum.postgresql.org icinga2.x86_64 2.3.4-1.el6
icinga2_yum_repoicinga2-bin.x86_64 2.3.4-1.el6
icinga2_yum_repo icinga2-common.x86_64 2.3.4-1.el6
icinga2_yum_repoicinga2-ido-pgsql.x86_64 2.3.4-1.el6
icinga2_yum_repo icingaweb2.noarch 2.0.0-3.beta3.el6
icinga2_yum_repoicingaweb2-common.noarch 2.0.0-3.beta3.el6
icinga2_yum_repo icingaweb2-vendor-HTMLPurifier.noarch 4.6.0-1.el6
icinga2_yum_repoicingaweb2-vendor-JShrink.noarch 1.0.1-1.el6
icinga2_yum_repo icingaweb2-vendor-Parsedown.noarch 1.0.0-1.el6
icinga2_yum_repoicingaweb2-vendor-dompdf.noarch 0.6.1-1.el6
icinga2_yum_repo icingaweb2-vendor-lessphp.noarch 0.4.0-1.el6
icinga2_yum_repophp-Icinga.noarch 2.0.0-3.beta3.el6 @icinga2_yum_repo
Received an error, see attached.
I have created a fix and will send a pull request shortly.
Attachments
Changesets
2015-05-22 11:53:57 +00:00 by elippmann 83a6e85
The text was updated successfully, but these errors were encountered: