[dev.icinga.com #9203] Wizard: Validate that a resource is actually an IDO instance

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9203

Created by gbeutner on 2015-04-30 06:54:25 +00:00

Assignee: afuhr
Status: Resolved (closed on 2015-05-15 14:00:45 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-05-15 14:00:45 +00:00 (in Redmine)

---

The monitoring wizard does currently only validate that the connection, such as with any resource, is possible. This should be extended with the following checks:

• Check whether the IDO schema has been applied (Result: Error, skip possible)
  • Can possibly be combined with the next check (It's not required to check whether every single table of the schema exists)
• Check whether the IDO's instances table contains at least one instance (Result: Error, skip possible)
• Check whether the IDO's instances table does not contain multiple instances (Result: Warning, skip possible)

Please implement this as part of the Icinga\Module\Monitoring\Forms\Config\BackendConfigForm with a descriptive message for each result.

// Please use a static method to allow reuse in the wizard
public static function validateIdoResource(Form $form, ConfigObject $resourceConfig);

You'll need to rethink the message handling of Zend_Form, as Zend_Form only knows about errors, not warnings etc. Adapt the internal error handling (Zend_Form::markAsError), but allow to register different types of messages (Error, Warning, Info => Maybe: Form::error, Form::warning, Form::info). A custom form decorator is also required, I'll leave it up to you how it's going to be called and implemented.

Please also consider adding the addSkipValidationCheckbox as a generic form feature, with also a generic message (such as "Proceed without any further (custom) validation" or the like), so that most of the handling required for processing this checkbox is done by the form base class. (There will still be a need for something like Form::ShouldWeRunACustomValidationOrNot() I suppose)

Changesets

2015-05-11 08:32:34 +00:00 by afuhr c3b4ea7

Add ido schema and instance availability validation

refs #9203

2015-05-15 11:02:54 +00:00 by afuhr 1eb1162

Add new FormNotification Decorator to render form notifications

refs #9203

2015-05-15 11:04:01 +00:00 by afuhr 9f35db7

Form: Add typed notifications to the form

refs #9203

2015-05-15 11:05:24 +00:00 by afuhr 93470db

Add css styling for form notifications

refs #9203

2015-05-15 11:06:33 +00:00 by afuhr df7b568

Add IDO instance validation

refs #9203

2015-05-15 13:49:57 +00:00 by afuhr e6ba3d6

Add descriptive message to custom validations

refs #9203

2015-05-15 13:59:18 +00:00 by afuhr 2cbcea2

Merge branch 'feature/ido-resource-validation-9203'

fixes #9214
resolves #9203

---

Subtasks:

• Bug 9214 - Detect multitple icinga_instances entries and warn the user

[icinga-migration]

Updated by jmeyer on 2015-05-05 11:07:17 +00:00

• Subject changed from Check whether the IDO's instances table is empty to Wizard: Validate that a resource is actually an IDO instance
• Description updated
• Category changed from Installation to Configuration
• Status changed from New to Assigned
• Assigned to set to afuhr
• Target Version set to 2.0.0-rc1

[icinga-migration]

Updated by jmeyer on 2015-05-07 09:00:04 +00:00

• Description updated

[icinga-migration]

Updated by icinga-kanban on 2015-05-15 11:27:44 +00:00

Build !#640 triggered by commit 19243e6 passed successfully.

Branch: origin/feature/ido-resource-validation-9203
Author: Alexander Fuhr

[icinga-migration]

Updated by icinga-kanban on 2015-05-15 13:54:04 +00:00

Build !#641 triggered by commit e6ba3d6 passed successfully.

Branch: origin/feature/ido-resource-validation-9203
Author: Alexander Fuhr

[icinga-migration]

Updated by afuhr on 2015-05-15 14:00:45 +00:00

• Status changed from Assigned to Resolved

Applied in changeset 2cbcea2.