Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #9184] Add timestamp support for GelfWriter #2970

Closed
icinga-migration opened this issue Apr 27, 2015 · 9 comments
Closed

[dev.icinga.com #9184] Add timestamp support for GelfWriter #2970

icinga-migration opened this issue Apr 27, 2015 · 9 comments
Labels
area/metrics General metrics handling enhancement New feature or request
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/9184

Created by mfriedrich on 2015-04-27 09:22:17 +00:00

Assignee: mariussturm
Status: Resolved (closed on 2016-04-11 13:40:03 +00:00)
Target Version: 2.5.0
Last Update: 2016-04-13 10:25:50 +00:00 (in Redmine)

Backport?: Not yet backported
Include in Changelog: 1

Similar to GraphiteWriter in #8374 supporting the actual timestamp provided by the check result when available.

Changesets

2016-04-11 12:48:16 +00:00 by (unknown) 15cb9c1

Use check_result timestamp for GELF log messages

fixes #9184

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

2016-04-15 19:17:11 +00:00 by gbeutner e673909

Update .mailmap for Marius Sturm

refs #9184

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-04-27 09:22:22 +00:00

  • Relates set to 8374

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-04-27 09:22:37 +00:00

  • Relates set to 9055

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-10-27 20:55:23 +00:00

  • Status changed from New to Assigned
  • Assigned to set to mariussturm

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-04-07 10:45:26 +00:00

Any news? :)

@icinga-migration
Copy link
Author

Updated by mariussturm on 2016-04-11 06:57:34 +00:00

@dnsmichi could you please review and merge branch `9184-gelf-timestamp`?

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2016-04-11 13:32:24 +00:00

  • Target Version set to 2.5.0

Hi Marius,

I've seen that you've also pushed that fix into the git master - please don't do that, we'll take care about that when reviewing your branch. It is now resetted/removed.

Those commits should always contain a "refs #" in the commit message. The subject would start with a capital letter too.

The rest looks good, merged, thanks.

Kind regards,
Michael

@icinga-migration
Copy link
Author

Updated by mariussturm on 2016-04-11 13:36:17 +00:00

Urgs, sorry that was not the intention. Tried to push to a new branch, guess something went wrong there.

@icinga-migration
Copy link
Author

Updated by Anonymous on 2016-04-11 13:40:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 15cb9c1.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2016-04-13 10:25:50 +00:00

Please remove your branches once they've been merged into the master branch.

@icinga-migration icinga-migration added enhancement New feature or request area/metrics General metrics handling labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.5.0 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics General metrics handling enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant