[dev.icinga.com #8706] INI files should end with a newline character and should not contain superfluous newlines

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/8706

Created by tgelf on 2015-03-12 09:49:02 +00:00

Assignee: mjentsch
Status: Resolved (closed on 2015-06-08 11:29:09 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-06-11 08:29:00 +00:00 (in Redmine)

---

They look otherwise ugly when you cat them on your cli. Right now there is also one useless newline before each section (and therefore also on top of the file) - please fix this too.

Best,
Thomas

Changesets

2015-06-01 14:12:02 +00:00 by mjentsch 1901f0a

Improve .ini file formatting

End every file with a newline, and only display 1 empty line between each section, to improve readabillity.

fixes #8706

2015-06-01 14:46:52 +00:00 by mjentsch 4c6a2b4

Fix ini writer unit tests

refs #8706

2015-06-01 15:00:43 +00:00 by mjentsch 6661d49

Use ltrim instead of a manual loop to remove trailing lines in ini writer

refs #8706

2015-06-08 11:11:40 +00:00 by mjentsch ddba1d8

Fix spacing in ini files

refs #8706

[icinga-migration]

Updated by elippmann on 2015-04-02 11:04:07 +00:00

• Subject changed from INI files should finish with a newline character to INI files should end with a newline character and should not contain superfluous newlines
• Category set to Configuration
• Target Version set to 2.0.0-rc1

[icinga-migration]

Updated by mjentsch on 2015-06-01 13:03:02 +00:00

• Assigned to set to mjentsch

[icinga-migration]

Updated by icinga-kanban on 2015-06-01 14:39:44 +00:00

Build !#786 triggered by commit 1901f0a failed.

Branch: origin/master
Author: Matthias Jentsch

[icinga-migration]

Updated by mjentsch on 2015-06-01 14:40:07 +00:00

• Status changed from New to Resolved
• Done % changed from 0 to 100

Applied in changeset 1901f0a.

[icinga-migration]

Updated by jmeyer on 2015-06-05 14:24:41 +00:00

• Status changed from Resolved to New
• Assigned to deleted mjentsch
• Target Version changed from 2.0.0-rc1 to 261
• Done % changed from 100 to 80

I'm reopening this, as any last section of a INI file, which gets a new key inserted, causes the INI file not to end with a newline anymore due to the new key being inserted after any ending new lines.

[icinga-migration]

Updated by mjentsch on 2015-06-08 11:29:01 +00:00

• Status changed from New to Assigned
• Assigned to set to mjentsch
• Done % changed from 80 to 100

[icinga-migration]

Updated by mjentsch on 2015-06-08 11:29:09 +00:00

• Status changed from Assigned to Resolved

[icinga-migration]

Updated by jmeyer on 2015-06-11 08:29:00 +00:00

• Target Version changed from 261 to 2.0.0-rc1