[dev.icinga.com #8696] Can't search for Icinga 2 custom variables

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/8696

Created by tgelf on 2015-03-12 08:17:06 +00:00

Assignee: mhein
Status: Resolved (closed on 2015-05-21 14:55:03 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-05-21 14:55:03 +00:00 (in Redmine)

---

When searching for custom variables we upcase varnames as Icinga 1.x stores them that way. This means that _HOST_community will be COMMUNITY in the IDO. Custom vars in Icinga 2 are case sensitive, configuring vars.community AND vars.Community is perfectly valid.

So our upcase strategy fails here. Casting the column to case insensitive would not help either, for ovious reasons. We could introduce dot-separated varnames as virtual filter columns, that would be even better as they would look like in your config: vars.Community and vars.community. We should then of course also support vars.host.Community etc.

Cheers,
Thomas

Changesets

2015-05-21 12:34:43 +00:00 by mhein b9085c6

Use CustomVariable names case insensitive

refs #8696

2015-05-21 12:42:09 +00:00 by mhein e8e3b94

Use CustomVariable names case insensitive

refs #8696

2015-05-21 14:09:03 +00:00 by mhein 7c04664

Make MySQL collation syntax default

Overwrite customVarsJoinTemplate for Postgres and Oracle.

refs #8696

2015-05-21 14:51:31 +00:00 by mhein dd65498

Merge branch 'bugfix/customvars-case-insensitive-8696'

fixes #8696

---

Relations:

• relates #8980

[icinga-migration]

Updated by elippmann on 2015-04-02 10:53:03 +00:00

• Relates set to 8980

[icinga-migration]

Updated by elippmann on 2015-04-02 10:53:37 +00:00

• Subject changed from Custom variable name search for Icinga 2 to Can't search for Icinga 2 custom variables
• Category set to Monitoring
• Target Version set to 2.0.0-rc1

Why would casting the column to be case insensitive not help? If someone configures community and Community it's perfectly ok for me to list both results when searching for community. Turning custom var keys to be case sensitive is pain in the ass.
Supporting dot notation is a good idea as feature but not for resolving this issue.

[icinga-migration]

Updated by mhein on 2015-05-21 08:39:17 +00:00

• Status changed from New to Assigned
• Assigned to set to mhein

[icinga-migration]

Updated by icinga-kanban on 2015-05-21 12:45:08 +00:00

Build !#673 triggered by commit e8e3b94 passed successfully.

Branch: origin/bugfix/customvars-case-insensitive-8696
Author: Marius Hein

[icinga-migration]

Updated by mhein on 2015-05-21 13:29:54 +00:00

• Status changed from Assigned to Feedback

[icinga-migration]

Updated by mhein on 2015-05-21 14:11:08 +00:00

• Status changed from Feedback to Assigned

[icinga-migration]

Updated by icinga-kanban on 2015-05-21 14:13:10 +00:00

Build !#674 triggered by commit 7c04664 passed successfully.

Branch: origin/bugfix/customvars-case-insensitive-8696
Author: Marius Hein

[icinga-migration]

Updated by icinga-kanban on 2015-05-21 14:54:25 +00:00

Build !#771 triggered by the commits dd65498, 57abafd, 7c04664, e8e3b94 passed successfully.

Branch: origin/master
Author: Marius Hein

[icinga-migration]

Updated by mhein on 2015-05-21 14:55:03 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset dd65498.