Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #7658] MenuItemRenderer is not so easy to extend #1133

Closed
icinga-migration opened this issue Nov 13, 2014 · 3 comments
Closed
Labels
area/framework Affects third party integration/development bug Something isn't working
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/7658

Created by tgelf on 2014-11-13 14:28:02 +00:00

Assignee: afuhr
Status: Resolved (closed on 2015-04-20 15:16:07 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-04-20 15:16:07 +00:00 (in Redmine)


We see this in MonitoringMenuItemRenderer, it duplicates code for link generation.

Changesets

2015-04-20 15:02:42 +00:00 by afuhr f543321

Replace MenuItemRenderer interface with a base class MenuItemRenderer

refs #7658

2015-04-20 15:04:46 +00:00 by afuhr 4eb5f75

Use default MenuItemRenderer as renderer if no custom renderer is set

refs #7658

2015-04-20 15:07:34 +00:00 by afuhr 9ebf474

Use the MenuItemRenderer render() implemnetations

refs #7658

2015-04-20 15:15:21 +00:00 by afuhr 5f3aafd

Merge branch 'bugfix/menu-item-renderer-deduplication-7658'

fixes #7658

2015-04-20 19:49:45 +00:00 by tgelf d3964a3

MenuItemRenderer: add missing use clause

Otherwise this completely broke Icinga Web as soon as a single module
used a legacy icon.

refs #7658
@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-31 09:55:14 +00:00

  • Category set to Framework
  • Priority changed from Low to Normal
  • Target Version set to 2.0.0-rc1

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-04-20 08:47:39 +00:00

  • Status changed from New to Assigned
  • Assigned to set to afuhr

@icinga-migration
Copy link
Author

Updated by afuhr on 2015-04-20 15:16:07 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 5f3aafd.

@icinga-migration icinga-migration added bug Something isn't working area/framework Affects third party integration/development labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.0-rc1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Affects third party integration/development bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant