Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #7051] Url class should work also on CLI #952

Closed
icinga-migration opened this issue Sep 2, 2014 · 5 comments
Closed

[dev.icinga.com #7051] Url class should work also on CLI #952

icinga-migration opened this issue Sep 2, 2014 · 5 comments
Assignees
Labels
area/framework Affects third party integration/development bug Something isn't working wontfix Deprecated, not supported or not worth any effort

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/7051

Created by tgelf on 2014-09-02 07:57:00 +00:00

Assignee: elippmann
Status: Feedback (closed on 2015-03-31 08:37:34 +00:00)
Target Version: Backlog
Last Update: 2016-12-20 13:33:23 +00:00 (in Redmine)


Fails because of depending on a Request. I'd suggest to solve this in two steps:

  • quickfix, provide a Cli\FakeRequest and teach the Url class to get that one when running on CLI
  • in the long run, try to make Cli\Params compatible to Url\Params and create a "real" Request object for the CLI

Best,
Thomas

Changesets

2016-10-28 09:47:45 +00:00 by jmeyer d207dcb

Url: Throw ProgrammingError when trying to use Url::from* on the CLI

refs #7051

2016-12-20 13:32:10 +00:00 by (unknown) 66e4813

Make Url class working on CLI

refs #7051
@icinga-migration
Copy link
Author

Updated by tgelf on 2014-09-02 07:59:36 +00:00

Another approach: the original problem is, that the CLI fails badly once a module loads it's configuration.php. This was introduced by latest changes providing menu entries and dashboards. We could also add wrapper objects collecting all required information without instantiating Web objects from configuration.php.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-31 08:37:34 +00:00

  • Status changed from New to Closed

I think this is obsolete.

@icinga-migration
Copy link
Author

Updated by jmeyer on 2016-10-28 09:37:36 +00:00

  • Category set to Framework
  • Status changed from Closed to New
  • Target Version set to Backlog

I'll re-open this now since it's still an issue when using the Url class as part of any CLI operation.

@icinga-migration
Copy link
Author

Updated by aklimov on 2016-12-20 13:33:23 +00:00

  • Status changed from New to Feedback
  • Assigned to set to elippmann

@icinga-migration icinga-migration added feedback bug Something isn't working area/framework Affects third party integration/development labels Jan 17, 2017
@icinga-migration icinga-migration added this to the Backlog milestone Jan 17, 2017
@lippserd
Copy link
Member

@nilmerg Please open a new issue and clarify which parts of the Url class you want to use in the CLI. Since we have no real requirements specified here, I'll close this issue.

@lippserd lippserd added wontfix Deprecated, not supported or not worth any effort and removed feedback labels Feb 10, 2017
@lippserd lippserd removed this from the Backlog milestone Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Affects third party integration/development bug Something isn't working wontfix Deprecated, not supported or not worth any effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants