You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Assignee: (none)
Status: Rejected (closed on 2015-01-12 09:43:39 +00:00)
Target Version: (none)
Last Update: 2015-01-12 09:43:39 +00:00 (in Redmine)
Icinga Version: 2.0.1
As far as I can see in the code, string cleanup is made by SanitizeMetric function. While there are some useful replacements, I would like the "-" replacement to be removed. It is a valid character for graphite metrics and used very often in common naming-patterns for hosts or services. This leads to a naming-mismatch between icinga and graphite.
I would also suggest to remove some other characters in order to have a resilient system, preventing bad metrics from being sent.
We should remove: "!\"#$%&'()*+,./:;<=>?@[\]^`{|}~".
@dnsmichi, thats true, it's two changes at all. I wasn't sure whether I should create one or two issues for it.
What do you think about the update path. Shall we supply a script to do so or is it enough to give a note on that?
In my case we run a huge graphite cluster with a very special distributed setup on different machines than our icinga instances. Building a migration script for all purposes (and there will be many different ones) might be a bit overblown.
Updated by mfriedrich on 2014-11-09 15:21:02 +00:00
Status changed from New to Assigned
Assigned to set to mhoyer
Data integrity must be provided at all cost. Therefore your commit has not been merged or reviewed, sorry about that. Since graphite is written in Python, it should be an exception to provide a script being Python 2.4 compatible at least. Can you do that?
This issue has been migrated from Redmine: https://dev.icinga.com/issues/6799
Created by mhoyer on 2014-07-27 18:38:45 +00:00
Assignee: (none)
Status: Rejected (closed on 2015-01-12 09:43:39 +00:00)
Target Version: (none)
Last Update: 2015-01-12 09:43:39 +00:00 (in Redmine)
As far as I can see in the code, string cleanup is made by SanitizeMetric function. While there are some useful replacements, I would like the "-" replacement to be removed. It is a valid character for graphite metrics and used very often in common naming-patterns for hosts or services. This leads to a naming-mismatch between icinga and graphite.
I would also suggest to remove some other characters in order to have a resilient system, preventing bad metrics from being sent.
We should remove: "!\"#$%&'()*+,./:;<=>?@[\]^`{|}~".
Current implementation:
void GraphiteWriter::SanitizeMetric(String& str)
{
boost::replace_all(str, " ", "_");
boost::replace_all(str, ".", "_");
boost::replace_all(str, "-", "_");
boost::replace_all(str, "\\", "_");
boost::replace_all(str, "/", "_");
}
Relations:
The text was updated successfully, but these errors were encountered: