Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev.icinga.com #6778] Duration and history time formatting isn't correct #875

Closed
icinga-migration opened this issue Jul 22, 2014 · 40 comments
Closed

[dev.icinga.com #6778] Duration and history time formatting isn't correct #875

icinga-migration opened this issue Jul 22, 2014 · 40 comments
Labels
area/framework Affects third party integration/development bug Something isn't working queue/important Blocks a release or needs immediate attention
Milestone
2.0.0-rc1

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6778

Created by gbeutner on 2014-07-22 08:57:14 +00:00

Assignee: elippmann
Status: Resolved (closed on 2015-05-22 09:40:03 +00:00)
Target Version: 2.0.0-rc1
Last Update: 2015-05-22 09:40:03 +00:00 (in Redmine)

There's at least one more case where the duration formatting is wrong (which is probably my fault :p):

A notication has been sent for this issue 06.07. ago

In this case "06.07." is a date (6th of July).

Attachments

Changesets

2014-11-27 12:28:34 +00:00 by aklimov eb9327d

Deduplicate DateTimeRenderer::detectType()'s logic

refs #6778

2014-11-27 12:34:57 +00:00 by aklimov d091aed

Deduplicate DateTimeRenderer::__toString()'s logic

refs #6778

2014-11-27 12:59:12 +00:00 by aklimov cfc98c4

Clean up notifications detail view

refs #6778

2014-11-27 13:15:02 +00:00 by aklimov ecc4ea0

Use `dateTimeRenderer' helper in notifications detail view

refs #6778

2014-11-27 13:50:53 +00:00 by aklimov 6be72a5

ToggleInstanceFeaturesCommandForm: use `dateTimeRenderer' helper

refs #6778

2014-11-27 14:01:03 +00:00 by aklimov d91b31c

Use `dateTimeRenderer' helper in disable notifications view

refs #6778

2014-11-27 14:29:20 +00:00 by aklimov 1116614

Use `dateTimeRenderer' helper in process info view

refs #6778

2014-11-27 14:57:35 +00:00 by aklimov 50a97be

Use `dateTimeRenderer' helper in checkstatistics view

refs #6778

2014-11-27 15:26:43 +00:00 by aklimov 609800a

Clean up downtime components view's logic

refs #6778

2014-11-27 16:48:29 +00:00 by aklimov 7d7663a

Deduplicate hostgroups list view's logic

refs #6778

2014-11-27 17:04:30 +00:00 by aklimov 47f96ff

Deduplicate servicegroups list view's logic

refs #6778

2014-11-27 17:14:39 +00:00 by aklimov 86d36c1

Use `dateTimeRenderer' helper in hostgroups list view

refs #6778

2014-11-27 17:16:27 +00:00 by aklimov 8ff7710

Use `dateTimeRenderer' helper in servicegroups list view

refs #6778

2014-11-27 17:23:56 +00:00 by aklimov eaf3347

Icinga Web view helpers: add TODO

refs #6778

2014-12-02 14:01:40 +00:00 by aklimov c02fd41

Work only w/ timestamps in DateTimeRenderer

refs #6778

2014-12-02 14:01:40 +00:00 by aklimov 4bef8f7

DateTimeRenderer: add 4 shortcuts

refs #6778

2014-12-02 14:01:40 +00:00 by aklimov de222de

Add DateTimeRenderer's shortcuts as format helpers

refs #6778

2014-12-02 14:07:11 +00:00 by aklimov 50d185f

Icingacli: use DateTimeRenderer

refs #6778

2014-12-02 14:15:37 +00:00 by aklimov 0321014

ToggleInstanceFeaturesCommandForm: use new DateTimeRenderer helper

refs #6778

2014-12-02 14:45:40 +00:00 by aklimov 50e5a8c

Use new DateTimeRenderer helper while displaying comments

refs #6778

2014-12-02 14:53:56 +00:00 by aklimov a5b28d1

Use new DateTimeRenderer helpers while displaying downtimes

refs #6778

2014-12-02 15:07:33 +00:00 by aklimov f3173d9

Use new DateTimeRenderer helpers while displaying notifications

refs #6778

2014-12-02 15:12:22 +00:00 by aklimov 020c6c1

Use new DateTimeRenderer helper while listing hostgroups

refs #6778

2014-12-02 15:16:36 +00:00 by aklimov 9848549

Use new DateTimeRenderer helper while listing servicegroups

refs #6778

2014-12-02 15:21:12 +00:00 by aklimov 2189b6a

Use new DateTimeRenderer helper while listing hosts

refs #6778

2014-12-02 15:22:15 +00:00 by aklimov 5b6d0e5

Use new DateTimeRenderer helper while listing services

refs #6778

2014-12-02 15:33:35 +00:00 by aklimov 7c5db4a

Use new DateTimeRenderer helpers while showing checkstatistics

refs #6778

2014-12-02 15:35:53 +00:00 by aklimov 6794d37

Use new DateTimeRenderer helper while showing headers

refs #6778

2014-12-02 15:38:06 +00:00 by aklimov 4ff1070

Use new DateTimeRenderer helpers in process views

refs #6778

2014-12-02 15:41:55 +00:00 by aklimov 13a698c

Drop obsolete helpers

refs #6778

2014-12-02 16:22:00 +00:00 by aklimov 5835379

Move DateTimeRenderer from Icinga\Web\View to Icinga\Util

refs #6778

2014-12-03 09:58:47 +00:00 by aklimov 5c6f591

Implement DateTimeRenderer::isAbsolute()

refs #6778

2014-12-03 10:47:10 +00:00 by aklimov 5c8df02

Make DateTimeRenderer::render() shortcuts non-static

refs #6778

2014-12-03 10:47:10 +00:00 by aklimov 2415be3

Format helpers: don't use <span> if DateTimeRenderer instance is absolute

refs #6778

2014-12-03 15:30:30 +00:00 by aklimov 4d26842

Downtimes list: correct date/time display

refs #6778

2014-12-03 16:42:12 +00:00 by aklimov 766f596

Drop helper `timeSpanFuture'

refs #6778

2014-12-03 16:45:57 +00:00 by aklimov ff07cd2

Drop DateTimeRenderer::timeSpanFuture()

refs #6778

2014-12-03 17:00:21 +00:00 by aklimov d136c3b

Rename DateTimeRenderer::timePointFuture() -> ...::timeUntil()

refs #6778

2014-12-03 17:05:47 +00:00 by aklimov dab83d6

Rename DateTimeRenderer::timePointPast() -> ...::timeAgo()

refs #6778

2014-12-03 17:09:47 +00:00 by aklimov b683bca

Rename DateTimeRenderer::timeSpanPast() -> ...::timeSince()

refs #6778

2014-12-09 11:46:24 +00:00 by aklimov 1ff2d13

Add 3 helpers for DateTimeRenderer::format()

refs #6778

2014-12-09 11:52:46 +00:00 by aklimov 0acd975

Use `formatDateTime' helper in downtimes list

refs #6778

2014-12-09 12:03:03 +00:00 by aklimov 0d179da

Use DateTimeRenderer::format() in ...::render()

refs #6778

2014-12-09 12:56:11 +00:00 by aklimov d3f2c0b

Use DateTimeRenderer helpers rather than date()

refs #6778

2014-12-09 13:17:59 +00:00 by aklimov 2abb41c

DateTimeRenderer: use DateTime::setTimestamp() for timestamp validation

refs #6778

2014-12-09 13:54:38 +00:00 by aklimov a0c9fea

Translate DateTimeRenderer::render()'s output

refs #6778

2014-12-09 14:09:43 +00:00 by aklimov 74cc3e0

DateTimeRenderer::format(): throw UnexpectedValueException rather than IcingaException

refs #6778

2014-12-09 14:22:07 +00:00 by aklimov 3e49db3

Make DateTimeRenderer's methods' documentation more precise

refs #6778

2014-12-09 15:33:45 +00:00 by aklimov 3bbde5f

DateTimeRenderer::render(): add param $formatStr

refs #6778

2014-12-18 09:18:17 +00:00 by aklimov 10b501f

DateTimeRenderer::render(): add param $forceAbs

refs #6778

2014-12-18 09:26:28 +00:00 by aklimov aac4f33

DateTimeRenderer: add params $formatStr and $forceAbs to timeUntil(), timeAgo() and timeSince()

refs #6778

2014-12-18 09:41:00 +00:00 by aklimov b315f97

DateTimeRenderer helpers: add params $formatStr and $forceAbs

refs #6778

2014-12-18 12:59:12 +00:00 by aklimov 5aa0072

Downtimes list: improve date/time translation

refs #6778

2015-04-08 13:19:51 +00:00 by elippmann 3f2d877

Use IntlDateFormatter in Format::timeUntil()

refs #6778

2015-04-08 13:23:00 +00:00 by elippmann 0de2dbd

Temporary disable timeuntil ui counter

refs #6778

2015-04-09 10:05:45 +00:00 by elippmann 0baeb32

Temporary disable timesince ui counter

refs #6778

2015-04-10 07:29:46 +00:00 by elippmann 06830e0

Set default locale for the intl extension upon locale detection

refs #6778

2015-04-10 07:44:38 +00:00 by elippmann f2e5066

lib: Add DateFormatter for ICU date formatting

The DateFormatter class is supposed to handle locale-dependent date, time, and time diff (ago, since, until) formatting.

refs #6778

2015-04-10 07:51:15 +00:00 by elippmann 7f73c6a

Use DateFormatter in our Format util for time ago, since and until

Note that time diff formatting now always includes the prefix using the functions timeAgo, timeSince and timeUntil.
I'll remove the related prefixed* functions later on and implement it as parameter to the functions listed above.

refs #6778

2015-04-10 07:56:39 +00:00 by elippmann 3ec6caa

lib: Add timeAgo to views

refs #6778

2015-04-10 08:14:22 +00:00 by elippmann 44ee4cd

Use timeAgo() instead of timeSince() in the monitoring health view

refs #6778

2015-04-10 08:19:10 +00:00 by elippmann a84b3ac

Fix "since since" in the monitoring health view

Because timeSince() now includes the prefix, the prefix has to be removed from the format string.

refs #6778

2015-04-10 08:20:10 +00:00 by elippmann e6f070d

Use timeAgo() instead of timeSince() when displaying object notifications

refs #6778

2015-04-10 08:27:57 +00:00 by elippmann d6374d4

Use timeAgo() instead of timeSince() for an object's last check

refs #6778

2015-04-10 08:28:17 +00:00 by elippmann 5efc343

Add full stop to sentences in the notifications view component for objects

refs #6778

2015-04-10 10:56:49 +00:00 by elippmann dc757e3

Use timeAgo() for the comment creation date and time instead of prefixedTimeSince()

refs #6778

2015-04-10 11:20:41 +00:00 by elippmann 1dcb3b3

Use timeUntil() for the comment expiration date and time

refs #6778

2015-04-10 12:19:08 +00:00 by elippmann 5a46821

Rename timeago, timesince and timeuntil CSS classes to time-ago, time-since and time-until

refs #6778

2015-04-10 12:22:06 +00:00 by elippmann d5427f0

Use timeSince() for displaying status changes of hosts instead of prefixedTimeSince()

refs #6778

2015-04-10 12:27:34 +00:00 by elippmann 2854859

Use timeSince() for displaying status changes of services instead of prefixedTimeSince()

Note that only the services view excluded the prefix from time diffs when being displayed in the dashboard. I'll readd that for both hosts and services later on.
Further, note that only the hosts view excludes the date of the status change when in state pending. I'll add that for the services view too.

refs #6778

2015-04-15 13:02:27 +00:00 by elippmann b844521

Use timeSince() for the last status change in the host's detail view

Instead of using prefixedTimeSince() which will be removed.

refs #6778

2015-04-15 13:06:15 +00:00 by elippmann a6a9bd2

Use timeSince() for the last status change in the service's detail view

Instead of using prefixedTimeSince() which will be removed.

refs #6778

2015-04-15 13:21:19 +00:00 by elippmann 9b9975b

Use timeSince() in the service groups view

Instead of prefixedTimeSince() which will be removed.

refs #6778

2015-04-15 13:22:26 +00:00 by elippmann 2440308

Use timeSince() in the host groups view

Instead of prefixedTimeSince() which will be removed.

refs #6778

2015-04-15 13:26:25 +00:00 by elippmann ae1962a

Let DateFormatter format dates like Format::smartTimeDiff()

Date diffs which are bigger than 3 days are now displayed w/o time again.

refs #6778

2015-04-15 13:28:34 +00:00 by elippmann eb77fff

Capitalize status change information in tables via CSS

refs #6778

2015-04-15 13:33:44 +00:00 by elippmann e500715

Use timeAgo() when displaying comments in the detail views

refs #6778

2015-04-15 13:40:40 +00:00 by elippmann 229e266

Add new line between comment author and creation time in the detail views

refs #6778

2015-04-15 13:46:12 +00:00 by elippmann 0f70701

Use timeSince() in the monitoring list command

refs #6778

2015-04-15 13:47:10 +00:00 by elippmann 44c8d37

lib: Remove prefixedTimeSince()

refs #6778

2015-04-15 13:47:58 +00:00 by elippmann ff45faf

lib: Remove prefixedTimeUntil()

refs #6778

2015-05-18 12:17:48 +00:00 by elippmann e1f6aee

Use timeAgo in the notifications overview

refs #6778

2015-05-18 12:18:22 +00:00 by elippmann bd51bed

Use timeSince and timeUntil in the dowtimes overview

refs #6778

2015-05-18 12:33:49 +00:00 by elippmann e49f938

Use timeSince and timeUntil when displaying object downtimes

refs #6778

2015-05-18 12:39:36 +00:00 by elippmann 9ffeffd

Show when an object's dowtime was added

refs #6778

2015-05-18 12:40:55 +00:00 by elippmann aaa8e4b

Don't render time information when the timestamp evaluates to false

refs #6778

2015-05-19 07:55:21 +00:00 by elippmann bf8c4f1

Replace DateFormatter format constants w/ format functions

refs #6778

2015-05-19 07:56:20 +00:00 by elippmann 9477fdc

Use DateFormatter's format functions in the format view helper

refs #6778

2015-05-19 07:56:48 +00:00 by elippmann 2eb93d0

Remove time formatting functions from the format util

The DateFormatter class now has these functions.

refs #6778

2015-05-19 07:57:46 +00:00 by elippmann 3fdf1d2

Use timeAgo in the event history overview

refs #6778

2015-05-19 08:00:27 +00:00 by elippmann 7212c03

Don't show ago, since, ... for monitoring list views in the dashboard

refs #6778

2015-05-19 08:06:19 +00:00 by elippmann a66cb90

Remove dateTimeRenderer view helper

The helper is no longer used anywhere.

refs #6778

2015-05-19 08:10:23 +00:00 by elippmann d53c3d7

Add view helper functions for formatting, date, date and time, and time

refs #6778

2015-05-19 08:11:12 +00:00 by elippmann 8f40d76

Use date format view helper function in the event grid

I'm about to drop the DateFormat view helper class.

refs #6778

2015-05-19 08:13:58 +00:00 by elippmann 979f16e

Use date and time format view helper function in the monitoring health view

I'm about to drop the DateFormat view helper class.

refs #6778

2015-05-19 08:14:35 +00:00 by elippmann e46af79

Drop the DateFormat view helper class

The view helper class is no longer in use.

refs #6778

2015-05-19 09:10:35 +00:00 by elippmann e87067d

lib/chart: Use PHP's DateTime instead of our DateTimeFactory

I'm about to drop the DateTimeFactory because date_default_timezone_set() in combination w/ PHP's DateTime is sufficient.

refs #6778

2015-05-19 09:14:41 +00:00 by elippmann 5cf8e25

lib/grid: Use PHP's DateTime instead of our DateTimeFactory

I'm about to drop the DateTimeFactory because date_default_timezone_set() in combination w/ PHP's DateTime is sufficient.

refs #6778

2015-05-19 09:17:00 +00:00 by elippmann b5a0f79

Use PHP's DateTime instead of our DateTimeFactory in the TimeLineController

I'm about to drop the DateTimeFactory because date_default_timezone_set() in combination w/ PHP's DateTime is sufficient.

refs #6778

2015-05-19 09:22:23 +00:00 by elippmann ab7c529

Show the expected input format if a date-and-time input is not valid

refs #6778

2015-05-19 09:23:50 +00:00 by elippmann ba25852

Don't setup the DateTimeFactory when bootstrapping Icinga Web 2

DateTimeFactory will be removed soon.

refs #6778

2015-05-19 09:25:06 +00:00 by elippmann 1d6ef5e

Don't setup the DateTimeFactory in our tests

DateTimeFactory will be removed soon.

refs #6778

2015-05-19 09:25:32 +00:00 by elippmann 603dcbd

Drop the DateTimeFactory

refs #6778

2015-05-19 09:25:54 +00:00 by elippmann f028c74

Improve parameter names for the date formatting functions

refs #6778

2015-05-19 09:27:56 +00:00 by elippmann 15b2e87

Drop the DateTimeFactoryTest

refs #6778

2015-05-19 10:46:08 +00:00 by elippmann f968984

Drop the DateTimeRenderer

refs #6778

2015-05-19 10:46:33 +00:00 by elippmann 5b3957b

Drop the DateTimeRendererTest

refs #6778

2015-05-19 11:25:57 +00:00 by elippmann 9edc4a1

Fix date-and-time tooltips not showing the time

refs #6778

2015-05-19 11:26:46 +00:00 by elippmann 14b24ff

Use international standard date and time notation ...

... instead of depending on the locale.
We hardcode date and time formats all over the place anyway.

refs #6778

2015-05-19 14:21:57 +00:00 by elippmann 2715e8e

Revert "Set default locale for the intl extension upon locale detection"

This reverts commit 06830e035e7227e1fe48eaac66ce2d3f2d86913d.

We don't use the intl extension at the moment.

refs #6778

2015-05-21 08:16:54 +00:00 by elippmann 1e93378

ui: Fix refreshing partial time counters

refs #6778

2015-05-21 08:19:07 +00:00 by elippmann 970d4d7

Fix that time-until doesn't show negative partial time in the dashboard

refs #6778

2015-05-22 07:29:33 +00:00 by elippmann d187d77

monitoring: Use timeAgo in the comment-description partial

refs #6778

2015-05-22 07:33:30 +00:00 by elippmann d17842b

monitoring: Fix usage of the dropped DateTimeRenderer

refs #6778

2015-05-22 07:33:51 +00:00 by elippmann dd298ed

lib: Only invert relative partial times if necessary

refs #6778

2015-05-22 07:49:06 +00:00 by elippmann edd386e

lib: Add DateFormatter::formatDuration()

refs #6778

2015-05-22 08:04:00 +00:00 by elippmann de9be04

lib: Provide formatDuration() in our views

refs #6778

2015-05-22 08:06:55 +00:00 by elippmann da97523

monitoring: Fix duration, date and time formatting for downtimes

refs #6778

2015-05-22 08:22:14 +00:00 by elippmann 873bc22

monitoring: Fix date and time formatting for comments

refs #6778

2015-05-22 08:27:50 +00:00 by elippmann 3fced84

lib: Remove unused function from our format util

refs #6778

2015-05-22 08:59:17 +00:00 by elippmann 8d6d52f

monitoring: Fix date and time formatting in the timeline

refs #6778

2015-05-22 09:34:43 +00:00 by elippmann 53ca689

Merge branch 'bugfix/time-formatting-6778'

fixes #6778

Relations:
@icinga-migration
Copy link
Author

Updated by elippmann on 2014-10-28 09:35:34 +00:00

  • Category changed from 140 to Monitoring
  • Target Version set to 2.0-16

@icinga-migration
Copy link
Author

Updated by elippmann on 2014-11-21 15:39:10 +00:00

  • Target Version changed from 2.0-16 to Backlog

@icinga-migration
Copy link
Author

Updated by aklimov on 2014-11-27 12:28:39 +00:00

  • Status changed from New to Assigned
  • Assigned to set to aklimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-11-27 14:36:39 +00:00

Build !#324 triggered by commit 1116614 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-11-27 17:31:28 +00:00

Build !#325 triggered by the commits eaf3347, 8ff7710, 86d36c1, 47f96ff, 7d7663a, 609800a, 50a97be failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-02 15:52:48 +00:00

Build !#326 triggered by the commits 13a698c, 4ff1070, 6794d37, 7c5db4a, 5b6d0e5, 2189b6a, 9848549, 020c6c1, f3173d9, a5b28d1, 50e5a8c, 0321014, 50d185f, 8d96d2a, 594a7fe, 43c966e, 25eac14, de222de, 4bef8f7, c02fd41 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-02 16:10:33 +00:00

Build !#327 triggered by the commits ee164cc, faab895, 21743e4, e0b3dce, b1db18b, 7ccaaf3, 72160aa, 2e42d24, e617177, 8973ead, 648ef8d, 4b1aa4b failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-02 16:31:05 +00:00

Build !#328 triggered by commit 5835379 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-03 10:56:13 +00:00

Build !#329 triggered by the commits 2415be3, 5c8df02, 5c6f591 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-03 15:41:08 +00:00

Build !#331 triggered by commit 4d26842 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-03 17:19:31 +00:00

Build !#332 triggered by the commits b683bca, dab83d6, d136c3b, ff07cd2, 766f596 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-08 15:24:04 +00:00

Build !#337 triggered by commit eea2233 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-08 15:32:22 +00:00

Build !#338 triggered by commit 50b479a failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-09 13:04:06 +00:00

Build !#339 triggered by the commits d3f2c0b, 0d179da, 0acd975, 1ff2d13 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-09 14:26:23 +00:00

Build !#340 triggered by the commits 3e49db3, 74cc3e0, a0c9fea, 2abb41c failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-09 15:39:42 +00:00

Build !#341 triggered by commit 3bbde5f failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-18 13:04:26 +00:00

Build !#348 triggered by the commits 5aa0072, b315f97, aac4f33, 10b501f failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2014-12-18 14:22:05 +00:00

Build !#350 triggered by the commits b453edb, 08473ff, 87c5af7, 594d4d5, 56830cb, 8dc61fc, 928bf63, 379da5e, 3fde78f, bca28a5, ea69b3f, 37b9aa3, 31a05c9, 575b677, 60b8529, 57fdee3, 11111b0, 02044d6, 3a3c573, 6cb6054, 44d662c, ca24699, 2e8f30d, 5cc5122, d835fe6, 50e23a3, 00d3110, e1c35c4, ada0b8c, c54ab12, 3d54087, dcbf8c5, 37ad4f7, f8c4685, b58607c, fb32fba, efe7044, 088455a, cfe2242, e786a7a, ec06239, 6974b18, 33e25fd, 15d2414, 4ea178e, efa7909, b7c555a, 099fefd, cdbb7e2, cee5fb5, 581e009, 023b3c5, 275976c, b307fe2, 1721936, 7987fb3, 87664ff, e63252c, 3a2fb03, cee6887, abfef2c, ddc121d, 60feed5, 8779e80, 73f9328, 9b6c90b, 4e8595f, 89c4bb4, dc0f396, e0bec56, 429b16b, a087bc8, cccab1d, bf68ecf, 513fbe6, 9446117, 06fe3bc, 83b1cde, 8b59276, aea29fb, 9d7f3bd, 196b6a4, b214ed5, de0653e, 550bb7d, f94646e, 571df0a, f0b4708, b099c28, 09e59ba, cddb68b, 8d8b654, 8150cd7, f3df8db, a2a9753, eab5422, ec6850a, bb0073e, 2a3d7b8, b6ee903, ebf908b, 2b14dba, 7a243a0, 2b2b289, 625fa4d, fb6b2a7, 003567f, 9e23ca0, 0bec429, ef27581, 777ced3, 13059aa, 94869bf, 2cf7563, 8959fa3, dbf8527, 31a49a7, c737f18, fbe603c, edd8ece, 1ce99d2, ba7fa85, de8dc64, a1ccd01, c982ef4, 607b0fc, 30ee6c9, 64445ae, 38c9758, 9471ced, a7ab667, ba368f0, a4c4f50, 8222606, 81d49db, 3c10d47, 570b31f, 7c6672f, 97a2e84, d87058c, eef13ea, 8135cca, 72d74c1, 616a955, 5b1377e, fbdeb77, 8fd3b94, b6de74b, d7a0be7, b6671c8, d45f729, 6a2dfb4, 99f2abe, c573123, d09e65b, f5a232f, 1f547aa, ec9c174, 17db985, 24c3a30, 4a5acce, fa85840, c29eb0d, eea9ee8, bb716e8, 0a2fbf4, 6db2e4e, 8c00c6d, 22d155b, ab71049, a6c7fe2, e7fad2c, b0b18d0, 8ad9c7f, 97f88fb, b82ed3d, 6b8c477, cad539a, 6b03f58, a4384b6, d22e251, 8881d96, d892ae5, dc28f53, 0b1f318, e5ca8eb, d5bfb3d, 03100d0, 4136342, de4380e, a82bafc, 4a2259a, a5b3601, 4008b86, e124a42, a99dbab, 203dddb, 2576a3b, 65a65ae, d61e883, 5e3f60d, a33042b, 260ec95, 930416b, 406f3ba, 9bb68c4, 645a2ec, 01807c2, 924a511, 07c4591, 0fbe072, 858e7c2, 1e511a0, 7e4feb7, 6aa2dcd, 77719be, be7bae8, 4484a31, 2c0d71a, 4d32685, 7b45e5c, 65f3051, 96e98c8, d3d64e3, 2de3af2, d602f82, 62def40, e31e6a8, 1b3c42f, f3d2347, e8dfbe6, 809b714, bec1b65, 26132c4, 4114e73, 58c854d, 9ebf011, 6c52b52, f1d18c1, cc4907b, 3d75d2e, 3e5a0af, f2fd9f1, 146f315, 4dc1541, 5f97732, 5c0f998, f6a9c67, 75ea243, 42a564d, 9913382, ee9f87b, aa03011, 5a6995f, 114a648, 96dcc79, 67efe52, 0677105, 2245989, 26205a7, 392e725, 05afbee, a110b25, 73a29ab, 2e1afd7, 920a784, 538088d, ee71167, 9a50cb8, ccbc1f5, e42f400, fe11ca4, 82fa6e6, 8f23f61, 261a5dd, 8806583 failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-02-02 10:36:45 +00:00

Build !#476 triggered by commit 2ed0d1e failed.

Branch: origin/bugfix/correct-duration-formatting-6778
Author: Alexander Klimov

@icinga-migration
Copy link
Author

Updated by purplecarrot on 2015-03-19 01:58:23 +00:00

  • File added 0001-Fix-formatting-of-ago-durations.patch

Hi, I attempted to fix this issue by editing the format functions and adding a new helper named timeAgo.
Please let me know what you think of this patch and whether it should be amended.
Here are a few things I'm not too sure of:

  • is $includePrefix still a good variable name since the function now also uses suffixes?
  • should I also edit the translation files that contain strings like msgid "%s ago" or even remove them?
  • am I missing anything else in terms of translations?

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 09:09:39 +00:00

  • Duplicated set to 7171

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 09:09:51 +00:00

  • Duplicated set to 6980

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 09:11:01 +00:00

  • Subject changed from Duration formatting still isn't quite correct to Duration and history time formatting isn't correct
  • Category changed from Monitoring to Framework
  • Status changed from Assigned to New
  • Assigned to deleted aklimov
  • Target Version changed from Backlog to 2.0.0-rc1

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 10:17:14 +00:00

  • Duplicates set to 7923

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 10:17:22 +00:00

  • Status changed from New to Closed

We'll fix this with #6778.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-03-30 11:14:36 +00:00

  • Status changed from Closed to New

Accidentally closed this issue.

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-04-02 09:42:29 +00:00

  • Status changed from New to Assigned
  • Assigned to set to elippmann

Hi purplecarrot,

Thanks for the patch. I'll have a look at it asap.

Cheers,
Eric

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-04-04 08:57:36 +00:00

  • Priority changed from Normal to High

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-04-15 13:36:13 +00:00

Build !#589 triggered by commit e500715 failed.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-04-15 13:41:31 +00:00

Build !#590 triggered by commit 229e266 failed.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-04-15 13:48:44 +00:00

Build !#591 triggered by the commits ff45faf, 44c8d37, 0f70701, 796cbff, a4d8150, a8ce3ab, 9d4460d, b8849c0, d882ea1, d02c078, 923bc11, 2618d4a, 9ef414c, 1f0940c, f4c0b35, 16b9c73, 36fed03, 67ad575, 46296dc, 638c00d, 9cc5469, 29f05bf, 3653ec8, 644a386, 15399d7, 96954ea, 24e06e5, edaa51c, a21d544, e0891ae, d038a27, 5c61405, c10617d, c59d5ac, e7c1e55, ea16d45, 42e93ff, 8b2c019, 904e91b, 629becf, 4bc3afa, fdd6a4d, 055cd61, a17c2ed, 26f0b46, f61370f, 69e520a, 9f075e0, 1f4b3aa, 92634a1, 5ccf6a7, 0f07274, 1c32d8e, fda261b, b8efe01, 0628efb, 638eda7, 0fe59aa, 03c8de5, 31a05a3, a51b93e, 5ec4919, 71c0131, 6536878, 1dc16a1, a817d90, 8477859, 3d7e418, 6d03b2f, 0ec1a18, 52dcecf, f00adc2, 3c47ba1, 3d09615, ea874f8, 51bf5cf, 9e79419, ec67c28, b7e1c2d, ae10e01, 044a15d, 2c38ccd, 84a2727, bc6a086, 5372dfb, 21c7601, 8ed1c8e, 002b820, 480f551, cb95f53, 1e6f292, e5eca97, f7550f5, 7d98466, cee189a, b9aee47, 09ab601, b93d18a, 13596ec, 20b09d3, 55e9407, e94c99e, c56c565, 9557585, c476ee6, 98c76a6, b449127 failed.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-19 11:31:53 +00:00

Build !#649 triggered by the commits 14b24ff, 9edc4a1, 5b3957b, f968984, 15b2e87, f028c74, 603dcbd, 1d6ef5e, ba25852, ab7c529, b5a0f79, 5cf8e25, e87067d, e46af79, 979f16e, 8f40d76, d53c3d7, a66cb90, 1301b77, 7212c03, 3fdf1d2, 2eb93d0, 9477fdc, bf8c4f1, aaa8e4b, 9ffeffd, 13a38c9, e49f938, bd51bed, e1f6aee failed.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-19 14:24:18 +00:00

Build !#656 triggered by commit 2715e8e passed successfully.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-21 08:21:23 +00:00

Build !#667 triggered by commit 1e93378 passed successfully.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-21 08:23:22 +00:00

Build !#668 triggered by commit 970d4d7 passed successfully.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-22 08:25:26 +00:00

Build !#679 triggered by the commits 873bc22, da97523, de9be04, edd386e, dd298ed, d17842b, d187d77, 54577d0, 47f21ee, c47465a, 57328aa, 0c72686, ad5ab16, e0c6ce5, 0db7cfc, 1a1f93d, e7396ea, 89bac33, 73eb8cc, 4b9f7eb, 58b3192, 195275a, 82f9425, 87a46ea, ee6c669, a52264a, 37abc72, bbed2cf, ce463d1, cfb819e, b9a6e10, 80b174f, f9952cf, a9d6a94, 2dc6d54, d379b27, 5efbad3, 41e7239, 2493535, a524b14, 9b4f08e, 902c00e, bd54784, 5a69c26, 338fad5, ccaebd1, 3d1c360, 3a2238f, 0b937c8, 93db1d1, 6ba07b0, c0cf6e4, 2ed1d6c, cc050ed, 36713fb, 3243f9a, b1b2e3f, 54207d3, 94bdb8b, 0a8c9ad, 75b004d, a2b262e, 85dd496, bd7c7f9, 4cedfce, a629adb, 73e8c51, afe07f4, 3296522, 4f4d7cc, 1ce9900, d539a0e, 94555d7, 0bde465, 52d1cb8, 7caba93, 592d5ea, 1f20ba1, c312989, 0d48ddc, 342a8a3, 729fb9a, e84491d, 4fbadae, ca37226, f4d25a7, 00bbb76, fe2ee36, 4ff7d7a, 2f98733, 82ee1d6, 62d8c44, 533c980, 58434d9, 2cbcea2, e6ba3d6, d0cc2ae, 99c511e, 9a04338, fbf0ad4, 5faebb4, ed5f646, 3770741, e04655e, 3b7f27f, ad89036, 19243e6, df7b568, 93470db, 9f35db7, 1eb1162, 8b08473, c7d1a72, 386d4db, 149e893, e879ba4, ead0a64, 7e1f9f6, 0fe15d6, ab2f8e0, 43d8968, 59753ac, ca79b02, 9e3d65e, 9e4c005, 3c73f28, d43513d, 7353c0d, 4bda1cf, afa0dc0, dd58f14, e1c3d23, 3265964, 17ebe07, 6658415, 295254d, 152c6a8, 25f3970, c3b4ea7, cf8376f, 8c5f266, fff2d5c, 83efc3a, 891ce0f, 9936df5, c6c7898, 1fa5508, 7cf2cb0, ac599e6, b314c07, 4463f16, ffd12e3, b35dd4d, f2d89ae, 7c8ff44, 11c9cde, 3187975, 1586275, e5e3e80, 5477a2f, e6740c5, c71786a, 6ff903c, 0c7d8ab, ca839d5, cab198e, 32da02c, dedc175, 2ade247, d316b31, a46dece, be56674, 6ddb004, b186ce2, 400f351, 07c5e67, a87e1f9, 20b25e6, 9114a34, ab0720f, bb7afd9, ff47b89, 7b6641d, 6df031d, defda53, d1f1f5d, 0e4201a, be696e5, 612fefb, 993cb31, ab0b478, ffe23a1, d43f472, 32f657b, 15b86e5, 8484a27, 880b1eb, 5075ccd, 7f28c0a, 034421d, d27b94d, f3ca80f, 9917e63, c839cc0, 6f0fd7d, 7c0be30, ec82b3b, 3d53e6f, 5ba539b, a429617, 39042ab, a976d77, e4a9843, 6ba6cb7, 9cd7765, 1daecbb, 9393d11, d3964a3, d6e7061, 5f3aafd, 9ebf474, 4eb5f75, f543321, 1e064a5, f11ea04, 894457a, 96fb037, 9bbb23a, cc573c1, da7aa23, b68fd93, a3eb6e3, 48f9cf6, a4f0806, 41222fd, 4e27ff9, 48df225, 1ff9449, 0997eaf, 6b3dd63, 0be8b89, e812bed, 7bc07c4, 7630526, 8b18c5a, c43947d, a981990, 5196f16, c76e4e3, 4b43fbe, 593ea7a, 423b92f, ce6be0c, 54a370c, 8dba575, dbf471f, 14a5556, c099b7d, 78e4df2, b9f9ea6, b2246c2, 58b9310, 7be0079, faa29e3, 7ae7bf3, 2190e55, b9249da, d725b2f, a09e41e, 5f19ec1, 2964819, 74cf3cf, 073dc31, 3f092ff, 9388944, 5f4a61f, 57d519b, d5cc340, 2bd31ee, 7735e5d, b52b507, 6d0870a, ae7d679, 6898a4e, 0974b70, f07c0d8, 168577f, 3015028, 3672656, aa409bd, 675d070, 32e8b60, 5e92171, 17262ae, ed2de3c, be05d3a, 2efea21, f4c6939, f2eb209, 0312d8d, 878ef05, 06a4411, 45d1230, 09acddb, a185107, 6e6aabe, 9ac89ed, 028c3ba, eeb5a38, 46da404, 1c5a091, 6c0f9cf, 45a0982, 5619ac9, 9fbd782, b0b0ae1, 95a83a4, 266e781, 1cfcb93, 9c45e99, 2591f05, 5c71f5a, c2c9e49, 4724eb9, f91ce0c, a077472, 0623404, 9fc80ec, 7153436, f425704, cb0ca6d, ef16ba5, 860cc59 passed successfully.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-22 08:29:56 +00:00

Build !#680 triggered by commit 3fced84 passed successfully.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-22 09:01:18 +00:00

Build !#681 triggered by commit 8d6d52f passed successfully.

Branch: origin/bugfix/time-formatting-6778
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by icinga-kanban on 2015-05-22 09:37:39 +00:00

Build !#773 triggered by the commits 53ca689, 8d6d52f, 3fced84, 873bc22, da97523, de9be04, edd386e, dd298ed, d17842b, d187d77, 54577d0, 970d4d7, 1e93378, 2715e8e, 14b24ff, 9edc4a1, 5b3957b, f968984, 15b2e87, f028c74, 603dcbd, 1d6ef5e, ba25852, ab7c529, b5a0f79, 5cf8e25, e87067d, e46af79, 979f16e, 8f40d76, d53c3d7, a66cb90, 1301b77, 7212c03, 3fdf1d2, 2eb93d0, 9477fdc, bf8c4f1, aaa8e4b, 9ffeffd, 13a38c9, e49f938, bd51bed, e1f6aee, ff45faf, 44c8d37, 0f70701, 796cbff, 229e266, e500715, eb77fff, ae1962a, 2440308, 9b9975b, a6a9bd2, b844521, 291c6bf, 19cae4b, 2854859, d5427f0, 5a46821, 1dcb3b3, dc757e3, df3caa6, 5efc343, d6374d4, 613de61, 80ab64e, e6f070d, a84b3ac, 44ee4cd, 3ec6caa, 7f73c6a, f2e5066, 06830e0, 0baeb32, 0de2dbd, 3f2d877 passed successfully.

Branch: origin/master
Author: Eric Lippmann

@icinga-migration
Copy link
Author

Updated by elippmann on 2015-05-22 09:40:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset 53ca689.

@icinga-migration icinga-migration added queue/important Blocks a release or needs immediate attention bug Something isn't working area/framework Affects third party integration/development labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.0.0-rc1 milestone Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/framework Affects third party integration/development bug Something isn't working queue/important Blocks a release or needs immediate attention
Projects
None yet
Milestone
2.0.0-rc1
Development

No branches or pull requests
1 participant
@icinga-migration