Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev.icinga.com #6697] Plugin Check Commands: add check_vmware_esx #1783

Closed
icinga-migration opened this issue Jul 10, 2014 · 24 comments
Closed
Labels
area/windows Windows agent and plugins enhancement New feature or request
Milestone

Comments

@icinga-migration
Copy link

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6697

Created by ccesario on 2014-07-10 20:39:39 +00:00

Assignee: ccesario
Status: Resolved (closed on 2015-03-05 17:15:02 +00:00)
Target Version: 2.3.0
Last Update: 2015-03-05 17:15:02 +00:00 (in Redmine)


https://github.com/BaldMansMojo/check\_vmware\_esx

Attachments

Changesets

2015-02-25 12:32:22 +00:00 by (unknown) a63c59e

Add VMware check command plugin

Add VMware check command plugin file.

refs #6697

2015-03-02 10:54:36 +00:00 by (unknown) f226dfe

Add VMware check command plugin

Add VMware check command plugin file.

refs #6697

2015-03-02 11:08:42 +00:00 by (unknown) a9bd5c5

Move command to plugins-contrib.d directory

Move check vmware command to plugins-contrib.d directory.

refs #6697

2015-03-02 18:03:30 +00:00 by (unknown) 9db5243

Remove trailing whitespaces

Remove trailing whitespaces

refs #6697

2015-03-04 11:05:55 +00:00 by (unknown) 1227824

Add missing params in vmware-esx-soap-vm-cpu command

Add warning and critical params in vmware-esx-soap-vm-cpu command

refs #6697

2015-03-04 11:12:46 +00:00 by (unknown) 96404de

Add threshold values in vmware-esx-soap-vm-cpu command

Add threshold values in vmware-esx-soap-vm-cpu command.

refs #6697

2015-03-04 12:09:07 +00:00 by (unknown) 92f61af

Remove wrong params in previous commit.

Remove wrong params in previous commit regarding vmware-esx-soap-vm-cpu command.

refs #6697

2015-03-04 13:51:09 +00:00 by (unknown) b5d4739

Add check-vmware-ex commands documentation

Add check-vmware-ex commands documentation.

refs #6697

2015-03-05 07:02:32 +00:00 by (unknown) a0fe7e1

Add check command definitions for the check_vmware_esx plugin

fixes #6697

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>

2015-03-05 07:05:27 +00:00 by (unknown) 31c2b89

Add check command definitions for the check_vmware_esx plugin

fixes #6697

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>

2015-03-05 11:35:16 +00:00 by (unknown) cc988ff

Fix a typo in documentation section

Change vmware_name var to vmware_vmname var in a check_vmware_esx plugin documentation.

refs #6697

2015-03-05 17:10:44 +00:00 by (unknown) d0ca16c

Add check command definitions for the check_vmware_esx plugin

fixes #6697

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>

Relations:

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-07-12 15:19:30 +00:00

  • Subject changed from Add check commands for check_vmware_esx script to Plugin Check Commands: add check_vmware_esx

@icinga-migration
Copy link
Author

Updated by olaf on 2014-07-31 15:05:24 +00:00

  • File added check-vmware-esx.conf

Please review this code. I need complex set_if statements to exclude certain combinations of arguments. The code passes the icinga2 -c -C check. However not all code does what it was intended for. Please suggest improvements so I can commit the total project to github.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2014-08-01 09:43:31 +00:00

( len("$vmware_exclude$") > 0 ) && ( len("$vmware_include") == 0 )

This will always be false because config expressions are evaluated when the configuration files are parsed, i.e. len("$vmware_exclude$") will always be 16. The same problem exists for virtually all of your set_ifs.

@icinga-migration
Copy link
Author

Updated by olaf on 2014-08-01 12:48:06 +00:00

Gunnar, thank you for reviewing my code and spotting a problem.
This leads for me to two different things: the SSL check code example (which is now altered and simplified) was the only source which provided an example of more complex set_if coding including the len() function. If this is only evaluated at configfile parsetime I wonder what the len() function does as it seems in that case mostly to be used on constants which is a limited functionality imho.
But far more important: my code needs dynamic variable evaluation to ensure proper plugin execution. If this can not be achieved by using set_if, is there an alternative? If not, would it be an option to file for a feature request (and will it be likely that it will be taken into consideration)?
If there is no option for live evaluation of variables more complex plugins like this one can be tricky as the only option left configurationfile-wise would be to allow all potential (and potential conflicting) arguments to be passed on/through.
That is of course considering that it is not ideal to rewrite the config file and to split every possible argument combination into separate commands, which would make this config file into an even bigger monster, not to mention overwhelming for users and leading to a huge documentation file.
To sum up: how to commence?

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-08-22 13:59:04 +00:00

Required changes:

  • additional 'set_if' functionality

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-09-16 09:12:53 +00:00

  • Project changed from 37 to Icinga 2
  • Category set to Plugins

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2014-12-09 11:14:45 +00:00

  • Relates set to 8030

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-01-25 07:31:12 +00:00

  • Relates set to 7564

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-01-27 09:36:41 +00:00

  • Target Version set to 2.3.0

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-01-27 09:52:11 +00:00

The required `set_if` conditions will be implemented in #7564

Once done, please proceed with the CheckCommand implementation ccesario, olaf

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-01-29 09:16:40 +00:00

  • Status changed from New to Assigned
  • Assigned to set to ccesario

ccesario: Can you please update this for 2.3?

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-02-07 21:12:01 +00:00

As well as give us a heads-up if you can make it happen until the end of March.

@icinga-migration
Copy link
Author

Updated by ccesario on 2015-02-25 12:50:51 +00:00

@dnsmichi Please, look there https://git.icinga.org/?p=icinga2.git;a=shortlog;h=refs/heads/feature/check-vmware-ex-6697;js=1 and verify if it is ok. I still need write the documentation. Tests are welcome!

Carlos

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-03-02 08:11:16 +00:00

Could you please use the existing plugins-contrib directory tree? There's already an existing file for that.

https://github.com/Icinga/icinga2/blob/master/itl/plugins-contrib.d/virtualization.conf

Please check #7209 for reference.

@icinga-migration
Copy link
Author

Updated by ccesario on 2015-03-02 11:22:36 +00:00

@dnsmichi Changed to use plugins-contrib dir as you suggested. Pls check if is Ok.

Thank you.

Carlos

@icinga-migration
Copy link
Author

Updated by mfriedrich on 2015-03-02 15:30:29 +00:00

Please fix the trailing white spaces inside your commit.
http://www.legendiary.at/2013/06/24/detect-trailing-whitespaces-in-vim-revisited/

Other than that, please continue to write the documentation, and give us a heads-up if you can make it happen til Friday.

@icinga-migration
Copy link
Author

Updated by ccesario on 2015-03-02 20:03:17 +00:00

@dnsmichi done!

@icinga-migration
Copy link
Author

Updated by ccesario on 2015-03-04 14:01:57 +00:00

gunnarbeutner could you please verify if is it Ok ? I've upload the documentation into contrib section, as dnsmichi suggested me.

Thanks

Carlos

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-03-05 07:04:35 +00:00

I've rebased your branch and updated it with a number of other smaller fixes. However, in their current state the commands fail even the simplest of tests:

Non-optional macro 'vmware_vmname' used in argument '--name' is missing while executing command 'vmware-esx-soap-vm-runtime-issues' for object 'acheron.beutner.name!vmware-test'

object Service "vmware-test" {
  host_name = NodeName
  check_command = "vmware-esx-soap-vm-runtime-issues"
}

The vmware_vmname argument isn't documented.

@icinga-migration
Copy link
Author

Updated by Anonymous on 2015-03-05 07:05:03 +00:00

  • Status changed from Assigned to Resolved
  • Done % changed from 0 to 100

Applied in changeset a0fe7e1.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-03-05 07:08:29 +00:00

  • Status changed from Resolved to Assigned

@icinga-migration
Copy link
Author

Updated by Anonymous on 2015-03-05 07:10:02 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset 31c2b89.

@icinga-migration
Copy link
Author

Updated by gbeutner on 2015-03-05 17:08:36 +00:00

  • Status changed from Resolved to Assigned

@icinga-migration
Copy link
Author

Updated by Anonymous on 2015-03-05 17:15:02 +00:00

  • Status changed from Assigned to Resolved

Applied in changeset d0ca16c.

@icinga-migration icinga-migration added enhancement New feature or request Plugins labels Jan 17, 2017
@icinga-migration icinga-migration added this to the 2.3.0 milestone Jan 17, 2017
@dnsmichi dnsmichi added the area/windows Windows agent and plugins label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows Windows agent and plugins enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants