New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev.icinga.com #6697] Plugin Check Commands: add check_vmware_esx #1783
Comments
Updated by mfriedrich on 2014-07-12 15:19:30 +00:00
|
Updated by olaf on 2014-07-31 15:05:24 +00:00
Please review this code. I need complex set_if statements to exclude certain combinations of arguments. The code passes the icinga2 -c -C check. However not all code does what it was intended for. Please suggest improvements so I can commit the total project to github. |
Updated by gbeutner on 2014-08-01 09:43:31 +00:00
This will always be false because config expressions are evaluated when the configuration files are parsed, i.e. len("$vmware_exclude$") will always be 16. The same problem exists for virtually all of your set_ifs. |
Updated by olaf on 2014-08-01 12:48:06 +00:00 Gunnar, thank you for reviewing my code and spotting a problem. |
Updated by mfriedrich on 2014-08-22 13:59:04 +00:00 Required changes:
|
Updated by mfriedrich on 2014-09-16 09:12:53 +00:00
|
Updated by mfriedrich on 2014-12-09 11:14:45 +00:00
|
Updated by mfriedrich on 2015-01-25 07:31:12 +00:00
|
Updated by gbeutner on 2015-01-27 09:36:41 +00:00
|
Updated by mfriedrich on 2015-01-27 09:52:11 +00:00 The required `set_if` conditions will be implemented in #7564 Once done, please proceed with the CheckCommand implementation |
Updated by gbeutner on 2015-01-29 09:16:40 +00:00
ccesario: Can you please update this for 2.3? |
Updated by mfriedrich on 2015-02-07 21:12:01 +00:00 As well as give us a heads-up if you can make it happen until the end of March. |
Updated by ccesario on 2015-02-25 12:50:51 +00:00 @dnsmichi Please, look there https://git.icinga.org/?p=icinga2.git;a=shortlog;h=refs/heads/feature/check-vmware-ex-6697;js=1 and verify if it is ok. I still need write the documentation. Tests are welcome! Carlos |
Updated by mfriedrich on 2015-03-02 08:11:16 +00:00 Could you please use the existing plugins-contrib directory tree? There's already an existing file for that. https://github.com/Icinga/icinga2/blob/master/itl/plugins-contrib.d/virtualization.conf Please check #7209 for reference. |
Updated by ccesario on 2015-03-02 11:22:36 +00:00 @dnsmichi Changed to use plugins-contrib dir as you suggested. Pls check if is Ok. Thank you. Carlos |
Updated by mfriedrich on 2015-03-02 15:30:29 +00:00 Please fix the trailing white spaces inside your commit. Other than that, please continue to write the documentation, and give us a heads-up if you can make it happen til Friday. |
Updated by ccesario on 2015-03-02 20:03:17 +00:00 @dnsmichi done! |
Updated by ccesario on 2015-03-04 14:01:57 +00:00
Thanks Carlos |
Updated by gbeutner on 2015-03-05 07:04:35 +00:00 I've rebased your branch and updated it with a number of other smaller fixes. However, in their current state the commands fail even the simplest of tests:
The vmware_vmname argument isn't documented. |
Updated by Anonymous on 2015-03-05 07:05:03 +00:00
Applied in changeset a0fe7e1. |
Updated by gbeutner on 2015-03-05 07:08:29 +00:00
|
Updated by Anonymous on 2015-03-05 07:10:02 +00:00
Applied in changeset 31c2b89. |
Updated by gbeutner on 2015-03-05 17:08:36 +00:00
|
Updated by Anonymous on 2015-03-05 17:15:02 +00:00
Applied in changeset d0ca16c. |
This issue has been migrated from Redmine: https://dev.icinga.com/issues/6697
Created by ccesario on 2014-07-10 20:39:39 +00:00
Assignee: ccesario
Status: Resolved (closed on 2015-03-05 17:15:02 +00:00)
Target Version: 2.3.0
Last Update: 2015-03-05 17:15:02 +00:00 (in Redmine)
https://github.com/BaldMansMojo/check\_vmware\_esx
Attachments
Changesets
2015-02-25 12:32:22 +00:00 by (unknown) a63c59e
2015-03-02 10:54:36 +00:00 by (unknown) f226dfe
2015-03-02 11:08:42 +00:00 by (unknown) a9bd5c5
2015-03-02 18:03:30 +00:00 by (unknown) 9db5243
2015-03-04 11:05:55 +00:00 by (unknown) 1227824
2015-03-04 11:12:46 +00:00 by (unknown) 96404de
2015-03-04 12:09:07 +00:00 by (unknown) 92f61af
2015-03-04 13:51:09 +00:00 by (unknown) b5d4739
2015-03-05 07:02:32 +00:00 by (unknown) a0fe7e1
2015-03-05 07:05:27 +00:00 by (unknown) 31c2b89
2015-03-05 11:35:16 +00:00 by (unknown) cc988ff
2015-03-05 17:10:44 +00:00 by (unknown) d0ca16c
Relations:
The text was updated successfully, but these errors were encountered: