[dev.icinga.com #6593] Command Pipe implementation

[icinga-migration]

This issue has been migrated from Redmine: https://dev.icinga.com/issues/6593

Created by tgelf on 2014-06-27 10:33:32 +00:00

Assignee: (none)
Status: Closed (closed on 2015-03-27 08:22:17 +00:00)
Target Version: (none)
Last Update: 2015-03-27 08:22:17 +00:00 (in Redmine)

---

For a customer I'm working on a special custom command pipe transport right now, it should just forward the command to another Icinga Web 2 instance in another firewall zone. There it should target a custom web module doing custom voodoo:

• find out which satellite is responsible for this object
• send commands like "reschedule" to the satellite
• send commands like "schedule downtime" to that satellites master
• and more

So all I needed was "a new simple HTTP transport". While trying to do so, I stumbled over a couple of implementation details that felt, well... suboptimal. Here a few things:

• Transport type is not part of the configuration but "autodetected" - this hardly allows adding more transports (e.g. livestatus, future Icinga2 public API)
• constructs like if ($command->provideGlobalCommand) shows that method naming is often not really helpful
• there is no central logic taking care of command encoding, this is left to single command - and mostly just not happening at all
• there is no central logic doing safety checks (e.g. whether we really get a host)
• command string logic is distributed over module and main library and even worse also controllers and forms in a non-intuitive way
• this makes it hard to track issues down and nearly impossible to enforce permissions in a secure way
• grep for ACKNOWLEGEMENT in the source tree, compare how "add/remove comment" are implemented to get an idea of what I mean
• send() is expecting a string instead of an object. No chance to do further checks in a transport without duplicating command string logic again
• the comment object instead of making things easy adds even more complexity

Suggestions for improvement are welcome, we REALLY need them.

Regards,
Thomas

Changesets

2014-08-26 14:35:30 +00:00 by elippmann 6b88f1c

Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module

refs #6593

2014-08-29 12:34:16 +00:00 by elippmann 0e2e1bc

monitoring/commands: Add `CommandTransportInterface'

All concrete Icinga command transport classes should implement the `CommandTransportInterface' .

refs #6593

2014-08-29 12:38:52 +00:00 by elippmann e7eae87

monitoring/commands: Replace `Command' with `IcingaCommand'

Since there's already a `Cli\Command', `Command' is now named `IcingaCommand'.
All concrete Icinga commands should extend `IcingaCommand' which handles
command encoding. All other "features" of the `Command' object have been removed
because theses "features" should be handled by upcoming concrete command classes.

refs #6593

2014-08-29 12:44:49 +00:00 by elippmann 2ac4a85

monitoring/commands: Remove the `Transport' interface

The `Transport' interface is superseded by the `CommandTransportInterface'.

refs #6593

2014-08-29 13:04:48 +00:00 by elippmann ec46b36

monitoring/commands: Replace `LocalPipe' with `LocalCommandFile'

`LocalCommandFile' is configured via property setters instead of the too general `setEndpoint' function.

refs #6593

2014-08-29 13:08:58 +00:00 by elippmann 2490993

monitoring/commands: Replace `SecureShell' with `RemoteCommandFile'

`RemoteCommandFile' is configured via property setters instead of the too general `setEndpoint' function.
The ssh command to be executed only has the option 'BatchMode' set to 'yes' as this is enough to disable
interactive authentication methods. Further, all arguments become espaced.

refs #6593

2014-08-29 13:14:53 +00:00 by elippmann 6fdc436

monitoring/commands: Add `TransportException'

`TransportException' should be thrown if a command was not sent.

refs #6593

2014-08-29 13:36:11 +00:00 by elippmann 6324192

monitoring/commands: Throw `LogicException' if the remote host is not set in `RemoteCommandFile'

refs #6593

2014-08-29 13:36:55 +00:00 by elippmann 4d353ac

monitoring/commands: Add `CommandTransport' factory

Instead of auto-detecting which transport class to use, the instances configuration
now supports a new setting named `transport' with the possible values 'local' and 'remote'.

refs #6593

2014-08-29 13:45:35 +00:00 by elippmann 8c82f1a

monitoring/commands: Add common `ToggleFeature' command

`ToggleFeature' should be used for enabling/disabling concrete features of the monitoring host.

refs #6593

2014-09-01 08:29:34 +00:00 by elippmann 57dd9a6

monitoring/commands: ToggleFeature: Use 'return $this' for documenting fluent interfaces

refs #6593

2014-09-01 13:00:20 +00:00 by elippmann 8cacd2f

monitoring/commands: Add `InstanceCommandForm'

The `InstanceCommandForm' should be the base class for forms that handle program-wide commands.

refs #6593

2014-09-01 13:01:32 +00:00 by elippmann dae2967

monitoring/commands: Add `ToggleFeatureCommandForm'

`ToggleFeatureCommandForm' should be the base class for forms enabling/disabling features of an Icinga instance.

refs #6593

2014-09-01 13:13:59 +00:00 by elippmann d2d69b9

monitoring/commands: Add (START|STOP)_EXECUTING_HOST_CHECKS commands

`ToggleActiveHostChecks' is the command object for enableing/disabling active host checks on an Icinga instance.

refs #6593

2014-09-01 13:14:15 +00:00 by elippmann fda4878

monitoring/commands: Add (START|STOP)_EXECUTING_SVC_CHECKS commands

`ToggleActiveServiceChecks' is the command object for enabling/disabling active service checks on an Icinga instance.

refs #6593

2014-09-01 13:14:23 +00:00 by elippmann 010c5b4

monitoring/commands: Add (ENABLE|DISABLE)_EVENT_HANDLERS commands

`ToggleEventHandlers' is the command object for enabling/disabling host and service event handlers on an Icinga instance.

refs #6593

2014-09-01 13:14:31 +00:00 by elippmann 5474c66

monitoring/commands: Add (ENABLE|DISABLE)_FLAP_DETECTION commands

`ToggleFlapDetection' is the command object for enabling/disabling host and service flap detection on an Icinga instance.

refs #6593

2014-09-01 13:14:39 +00:00 by elippmann cdbd24e

monitoring/commands: Add (ENABLE|DISABLE)_NOTIFICATIONS/DISABLE_NOTIFICATIONS_EXPIRE_TIME commands

`ToggleNotifications' is the command object for enabling/disabling host and service notifications on an Icinga instance with an optional expire time for disabling notifications.

refs #6593

2014-09-01 13:14:49 +00:00 by elippmann cd29adc

monitoring/commands: Add (START|STOP)_OBSESSING_OVER_HOST_CHECKS commands

`ToggleObsessingOverHostChecks' is the command object for enabling/disabling processing of host checks via the OCHP command on an Icinga instance.

refs #6593

2014-09-01 13:15:11 +00:00 by elippmann c5e35c9

monitoring/commands: Add (START|STOP)_OBSESSING_OVER_SERVICE_CHECKS commands

`ToggleObsessingOverServiceChecks' is the command object for enabling/disabling processing of service checks via the OCHP command on an Icinga instance.

refs #6593

2014-09-01 13:18:31 +00:00 by elippmann efd16ba

monitoring/commands: Add (ENABLE|DISABLE)_PASSIVE_HOST_CHECKS commands

`TogglePassiveHostChecks' is the command object for enabling/disabling passive host checks on an Icinga instance.

refs #6593

2014-09-01 13:18:40 +00:00 by elippmann 0edd145

monitoring/commands: Add (ENABLE|DISABLE)_PASSIVE_SERVICE_CHECKS commands

`TogglePassiveServiceChecks' is the command object for enabling/disabling passive service checks on an Icinga instance.

refs #6593

2014-09-01 13:20:14 +00:00 by elippmann 920c0b9

monitoring/commands: Add (ENABLE|DISABLE)_PERFORMANCE_DATA commands

`TogglePerformanceData' is the command object for enabling/disabling the processing of host and service performance data on an Icinga instance.

refs #6593

2014-09-01 14:16:47 +00:00 by elippmann e2cdff6

monitoring/commands: Add form for enabling/disabling active host checks on an Icinga instance

refs #6593

2014-09-01 14:17:13 +00:00 by elippmann e8b70ff

monitoring/commands: Add form for enabling/disabling active service checks on an Icinga instance

refs #6593

2014-09-01 14:19:12 +00:00 by elippmann 939f8b8

monitoring/commands: Add form enabling/disabling host and service event handlers on an Icinga instance

refs #6593

2014-09-01 14:19:37 +00:00 by elippmann 5a100ea

monitoring/commands: Add form for enabling/disabling host and service flap detection on an Icinga instance

refs #6593

2014-09-01 14:20:07 +00:00 by elippmann ff10cda

monitoring/commands: Add form for enabling/disabling processing of host checks via the OCHP command on an Icinga instance

refs #6593

2014-09-01 14:20:31 +00:00 by elippmann 176a1a7

monitoring/commands: Add form for enabling/disabling processing of service checks via the OCHP command on an Icinga instance

refs #6593

2014-09-01 14:20:56 +00:00 by elippmann 8686074

monitoring/commands: Add form for enabling/disabling passive host checks on an Icinga instance

refs #6593

2014-09-01 14:21:23 +00:00 by elippmann d47951f

monitoring/commands: Add form for enabling/disabling passive service checks on an Icinga instance

refs #6593

2014-09-01 14:21:49 +00:00 by elippmann c005ef4

monitoring/commands: Add form for enabling/disabling the processing of host and service performance data on an Icinga instance

refs #6593

2014-09-02 07:51:40 +00:00 by elippmann 4b210f9

monitoring/commands: Remove `CommandForm' which will be replaced

Remove the rubbish.

refs #6593

2014-09-02 07:55:38 +00:00 by elippmann c27c569

monitoring/commands: Rename `InstanceCommandForm' to `CommandForm'

Since the old `CommandForm' is removed, `InstanceCommandForm' is now the new base class for all command forms.

refs #6593

2014-09-03 12:36:18 +00:00 by elippmann 1a4e908

lib: Let `DateTimeValidator' validate values as defined in HTML5

See http://www.w3.org/TR/html-markup/datatypes.html#common.data.datetime for the specification.

refs #6593

2014-09-03 12:37:33 +00:00 by elippmann 774db9a

lib: Add function `isUnixTimestamp' to the `DateTimeFactory'

Before, the `DateTimeValidator' defined this function.

refs #6593

2014-09-03 12:38:32 +00:00 by elippmann de11131

lib: Fix `DateFormat's `isUnixTimestamp' usage

refs #6593

2014-09-03 12:39:42 +00:00 by elippmann 906de4e

lib: Add the HTML5 attributes 'min', 'max' and 'step' to the number input control

refs #6593

2014-09-03 12:40:58 +00:00 by elippmann 2025fb3

lib: Let the date-and-time input control behave as defined in HTML5

refs #6593

2014-09-03 12:42:49 +00:00 by elippmann 5d1f2ad

monitoring/commands: Fix `ToggleFeatureCommandForm::onSucces()'s PHPDoc

refs #6593

2014-09-04 10:54:52 +00:00 by elippmann a45b17f

monitoring/lib: Add methods `Service::getHostName()' and `Service::getName()'

The upcoming service command objects will require a service object.
In order to build the command string, the service command objects require
retrieval of the service's host name and the service's name.

The actual implementation of the methods is subject to change

refs #6593

2014-09-04 11:01:42 +00:00 by elippmann 8d10913

monitoring/commands: Add common `ScheduleDowntimeCommandForm'

`ScheduleDowntimeCommandForm' should be the base class for forms scheduling downtimes.

refs #6593

2014-09-04 11:02:38 +00:00 by elippmann bc1d00f

monitoring/commands: Fix `ToggleFeatureCommandForm::createElements()'

`Icinga\Web\Form::createElements()' no longer requires to return an array of elements
because elements should be created directly.

refs #6593

2014-09-04 11:04:54 +00:00 by elippmann 3d0a74b

monitoring/commands: Add `ToggleNotificationsCommandForm'

`ToggleNotificationsCommandForm' is the form for enabling/disabling host and service notifications on an Icinga instance.

refs #6593

2014-09-04 11:06:47 +00:00 by elippmann cb23ef3

monitoring/commands: Add `DisableNotificationsCommandForm'

`DisableNotificationsCommandForm' is the form for disabling host and service notifications w/ an optional expire date and time on an Icinga instance.

refs #6593

2014-09-04 11:29:12 +00:00 by elippmann ed645b1

monitoring/commands: Fix `CommandForm::getTransport()'s PHPDoc

refs #6593

2014-09-04 13:30:54 +00:00 by elippmann 6f8fc3e

modules/command: Add command description to `DisableNotificationsCommandForm'

refs #6593

2014-09-04 13:37:30 +00:00 by elippmann f57bb0f

modules/commands: Add common `ScheduleDowntimeCommand'

`ScheduleDowntimeCommand' is the base class for commands scheduling downtimes.

refs #6593

2014-09-04 13:38:48 +00:00 by elippmann 1c8f880

modules/command: Remove old `ScheduleDowntimeCommand'

refs #6593

2014-09-04 13:42:11 +00:00 by elippmann fe47441

monitoring/commands: Add command to schedule a service downtime

refs #6593

2014-09-04 13:42:46 +00:00 by elippmann 1358a5d

monitoring/commands: Add command form for scheduling a service downtime

refs #6593

2014-09-04 13:43:37 +00:00 by elippmann 9cfd74d

monitoring: Introduce `ServiceController'

In the long term, `ServiceController' and the upcmoing `HostController' should replace `ShowController'.

refs #6593

2014-09-04 13:51:41 +00:00 by elippmann a94e84f

monitoring/commands: Add common `AddCommentCommand'

refs #6593

2014-09-04 13:52:20 +00:00 by elippmann a83ddb9

monitoring/commands: Let `ScheduleDowntimeCommand' extend `AddCommentCommand'

refs #6593

2014-09-09 14:35:06 +00:00 by elippmann a841b09

monitoring/commands: Do not require command objects to return the command string

There will be command renderer instead.

refs #6593

2014-09-09 14:39:22 +00:00 by elippmann d9fbbca

monitoring/commands: Move `AddCommentCommand' to `WithCommentCommand'

`AddCommentCommand' will be the command for adding both host and service comments.

refs #6593

2014-09-09 14:40:09 +00:00 by elippmann 28a66c8

monitoring/commands: Introduce `ObjectCommand' for commands that involve a Icinga object

refs #6593

2014-09-09 14:41:41 +00:00 by elippmann 171b366

monitoring/commands: Let `AddCommentCommand' be the command object for adding both host and service commands

refs #6593

2014-09-11 15:10:20 +00:00 by elippmann 1247fdc

monitoring/commands: Move toggle instance feature commands into a single command

refs #6593

2014-09-11 15:11:32 +00:00 by elippmann c40ac6f

monitoring/commands: Add `DisableNotificationsExpireCommand'

refs #6593

2014-09-11 15:13:57 +00:00 by elippmann 22771e6

monitoring/commands: Rename `DisableNotificationsCommandForm' to `DisableNotificationsExpireCommandForm'

The associated command also has 'Expired' in its name.

refs #6593

2014-09-11 15:16:13 +00:00 by elippmann 9257159

monitoring/commands: Move toggle instance feature command forms into a single form

refs #6593

2014-09-11 15:18:07 +00:00 by elippmann 3845301

monitoring/commands: Add object command classes

refs #6593

2014-09-11 15:19:00 +00:00 by elippmann 746e75e

monitroing/commands: Remove method `CommandForm::inline()'

Inline forms will set themselves as inline.

refs #6593

2014-09-11 15:20:20 +00:00 by elippmann b4faa01

monitoring/commands: Add object command forms

refs #6593

2014-09-11 15:39:13 +00:00 by elippmann 1df8076

monitoring/commands: Add command renderer for the Icinga command file

refs #6593

2014-09-11 15:39:59 +00:00 by elippmann b6ac31d

monitoring/commands: Let transports use the Icinga command file command renderer

refs #6593

2014-09-12 08:20:38 +00:00 by elippmann 3f216f2

monitoring/commands: Remove superseded command forms and command objects

refs #6593

2014-09-12 08:42:48 +00:00 by elippmann 1d54c7f

monitoring/commands: Support 'DISABLE_NOTIFICATIONS_EXPIRE_TIME'

refs #6593

2014-09-12 11:29:23 +00:00 by elippmann 16bc0e5

monitoring/commands: Add icon to the check now command form

refs #6593

2014-09-12 13:02:31 +00:00 by elippmann e5e806a

monitoring/commands: Fix instance command forms code compliance

refs #6593

2014-09-12 13:03:03 +00:00 by elippmann 442f956

monitoring/commands: Fix object command forms code compliance

refs #6593

2014-09-12 14:42:00 +00:00 by elippmann 4d784c6

monitoring/commands: Re-add the changed identifier to object features

refs #6593

2014-09-12 14:43:18 +00:00 by elippmann 3a9774e

monitoring/commands: Support toggling instance features

refs #6593

2014-09-12 14:46:07 +00:00 by elippmann 5f13db7

monitoring/commands: Use the toggle instance features command form in the process controller

refs #6593

2014-09-12 14:50:42 +00:00 by elippmann 5d07b04

monitoring/commands: Introduce `ServiceController'

refs #6593

2014-09-12 14:51:18 +00:00 by elippmann 17e04e9

monitoring: Point service's detail to the new `ServiceController' in the services list view

refs #6593

2014-09-12 14:52:45 +00:00 by elippmann 9b5c1f0

monitoring/commands: Let detail snippets use the new command forms

refs #6593

2014-09-12 14:53:48 +00:00 by elippmann 33e0fbb

monitoring/commands: Fix code compliance

refs #6593

2014-09-13 18:33:45 +00:00 by elippmann 6bfab25

monitoring/commands: Remove the `CommandForm' view helper

All command forms will be renderered using their real classes.

refs #6593

2014-09-13 18:34:51 +00:00 by elippmann a18287d

monitoring/commands: Rename `PropagateHostDowntime' to `PropagateHostDowntimeCommand'

refs #6593

2014-09-16 15:28:00 +00:00 by elippmann 0e6e371

monitoring/commands: Add 'command-form' partial

refs #6593

2014-09-16 16:44:44 +00:00 by elippmann cc2d06e

monitoring/`Service': Add `getStateText()', let `getHost()' return the host object

refs #6593

2014-09-16 16:45:31 +00:00 by elippmann 0577665

modules/commands: Fix `IcingaCommandFileCommandRenderer's `getHost()' and `getService()' calls

refs #6593

2014-09-16 16:48:07 +00:00 by elippmann 4d8b6dd

monitoring/commands: Add schedule host downtime command form

refs #6593

2014-09-16 16:48:36 +00:00 by elippmann 71ffd0e

monitoring/commands: Add schedule host check command form

refs #6593

2014-09-19 12:25:49 +00:00 by elippmann 72a9a53

monitoring/commands: Use translate plurar in the object command forms

refs #6593

2014-09-19 12:34:42 +00:00 by elippmann 274f2e7

monitoring/commands: Fix remove commands in the list comments and list downtimes views

refs #6593

2014-09-19 12:41:51 +00:00 by elippmann 27650be

monitoring/commands: Add missing `ListController' change from the last commit

refs #6593

2014-09-24 00:36:15 +00:00 by elippmann b107370

monitoring/commands: Default 'reschedule all service checks on the hosts' to false

refs #6593

2014-09-24 00:39:32 +00:00 by elippmann 9601942

monitoring/commands: Default 'schedule downtime for all services on the hosts' to false

refs #6593

2014-09-24 00:40:13 +00:00 by elippmann 70500be

monitoring/commands: Fix the delete comment and delete downtime commands

They included the involved object's name which is wrong.

refs #6593

2014-09-24 05:19:35 +00:00 by elippmann e847770

monitoring/commands: Remove false property from the schedule service check command

refs #6593

2014-09-24 05:21:23 +00:00 by elippmann 4258b13

monitoring/commands: Remove `MonitoringCommands' view helper

The helper is not used anywhere.

refs #6593

2014-09-24 05:23:56 +00:00 by elippmann c8f00be

monitoring/commands: Fix that removing a comment from the comment list opens and closes the detail area

This extends to removing a downtime from the downtime list.

refs #6593

2014-09-24 05:34:19 +00:00 by elippmann 3034ac5

monitoring/commands: Show affected objects in command forms

refs #6593

2014-09-24 06:03:06 +00:00 by elippmann 0ac7574

Merge branch 'bugfix/commands-6593'

fixes #6593
fixes #6961
fixes #4588
resolves #6666

---

Relations:

• relates #8876
• blocks #6593

[icinga-migration]

Updated by tgelf on 2014-06-27 10:54:25 +00:00

One more thing, I have multiple master instances here. And there is instances.ini, where we are going to configure instances. Any idea of how this should be distinguished with our current implementation?

[icinga-migration]

Updated by elippmann on 2014-08-25 14:50:44 +00:00

• Category set to Monitoring
• Status changed from Feedback to New
• Assigned to deleted elippmann
• Target Version set to 2.0-13

[icinga-migration]

Updated by elippmann on 2014-08-26 10:22:34 +00:00

• Status changed from New to Assigned
• Assigned to set to elippmann

[icinga-migration]

Updated by icinga-kanban on 2014-08-28 11:44:02 +00:00

Build !#1865 triggered by commit 6b88f1c failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-08-29 13:12:21 +00:00

Build !#1878 triggered by the commits 2490993, ec46b36, 2ac4a85, e7eae87, 0e2e1bc, 4ca1eaa, 6783d51, 0ff79b0, d3c2fc8, 65dd3f9, 98b2bce, 45cbd3f, 5c7999f, 52534a2, c93ab79, 7b221e2, 403f745, 5028ec7, a0b2c0b, 75a0c17, 2b879b3, bc05d2e, d1b1bc3, b81e965, 1106349, bb7972a, 7311ab9, e7da9c0, fe63ce6, e6bcda2, 4b1169c, f23bf91, eea43e9, be14844, a627571, f0a9927, 5203f82, a37e65b, d260c3f, c36e30a, e07f2a2, 4e1e845, 5e6ef57, 5a73811, d7ed6bd, a78d113, 02c3223, b743cf8, ed10e49, 488ea46, 644b3a1, c06db74, 50de21e, af5a326, 26d42da, a6bd802, 5f76521, af898cc, 26a78dc, c3731fa, 1902b4f, 0964316, 9c434fe, edf49d0, d8b468c, 235c4a8, 4fe46a2, fd912da, 936f65e, c8d61f7, 9cdd891, 8b2cc3a, 0bf0213, 25c9ee5, 75e09f2, a73e2ee, a9f0b95, f5ac592, 6ed3d5f, 7157b11, 5da14d3, f4ff2c9, 6ac471c, 8f0b989, 78a6175, 37fd3de, 58188c5, 802c095, 21cd503, 47ae4d7, 1de2d0c, 6690410, 630b36e, 0dce204, 1a1263d failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-08-29 13:39:06 +00:00

Build !#1880 triggered by the commits 4d353ac, 6324192, 6fdc436 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-08-29 13:46:27 +00:00

Build !#1881 triggered by commit 8c82f1a failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 12:50:35 +00:00

Build !#1893 triggered by the commits 57dd9a6, a01ee00, fb5685b, ae35650, 364c7c0, e020dd3, 79b0ed6, 055a107, bf23688, 486104d, 3642b7b, a26370b, e799d65, 648debf, 00a2d22, c5cface, 98809a1, a9eec0d, f77cd9c, 573a4ea, 0da16e4, 0a2b504, c4c5bcd, dea7caa, 4e83bb0, e345aa2, 436a4d2, 9d0037a, 35d11bd, 9b83074, 22e17e9, c194c02, fdef695, 66062c8, 947cd0c, 6a32c3a, e342035, 5e84ff4, 9465c3f, 70fdd58, 8b0df6c, e6612fe, afd0c20, 45638b2, 7ff51ca, 968fa36, 66031ed, 236d384, 4a59ff6, e132905, 1dea195, 24983c3, 88698cb, b7ae66b, e0d7c38, 87a5967, 5abf41e, 89541f5, 7e5b5a0, 1aa95b0, 1ff63db, ff1d2e4, 746f53f, 23aa57a, 2575634, 376e9aa failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 12:50:47 +00:00

Build !#1894 triggered by the commits 30965c2, 0822aff, f3e74f0 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 13:21:20 +00:00

Build !#1897 triggered by the commits 920c0b9, 0edd145, efd16ba, c5e35c9, cd29adc, cdbd24e, 5474c66, 010c5b4, fda4878, d2d69b9, dae2967, 8cacd2f failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-01 14:24:22 +00:00

Build !#1902 triggered by the commits c005ef4, d47951f, 8686074, 176a1a7, ff10cda, 5a100ea, 939f8b8, e8b70ff, e2cdff6 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 13:27:23 +00:00

Build !#1923 triggered by the commits ae18016, c27c569, 4b210f9 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-02 13:28:00 +00:00

Build !#1924 triggered by the commits 9bcd861, d4c4ab7, 8478ef3, 7143837, deebb64, 0e63e36, cd8015f failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2014-09-02 14:33:48 +00:00

• Target Version changed from 2.0-13 to 2.0-14

[icinga-migration]

Updated by icinga-kanban on 2014-09-03 12:45:43 +00:00

Build !#1956 triggered by the commits 5d1f2ad, 2025fb3, 906de4e, de11131, 774db9a, 1a4e908, 0b1d2bf, dd3901e, 5ce9bef, c7a4098, 5485ca8, 95c839a, 5464321, 1ba3df3, 2d86e6b, 5b14d8f, 539ab91, 338f549, aedc8cc, 39bb01b failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-03 21:23:31 +00:00

Build !#1967 triggered by the commits a4da3b6, 54a8342 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-03 21:27:30 +00:00

Build !#1968 triggered by the commits c3c0043, 3125f5d, 2eccc61, 8fdf20f, ede5b8f, 510e383, 64b9c89, da85112, cd8416b, 5931342, 37b1689, e45f504, b10b1ea, 88dde47, 1d81211, 65fb246, af3f33d, acbd2bd, 7cfc051, 33669f8, f4b820a, 3b8fcb8, 1e06c20, 6aeab59, 70cf14f, 3ade6da, c4d17a3, 06c7c4b, 07151d0, 3f9cb00, 8e5deb8, ef84780, 3d352ba, f12a574, 1734f01, b60b811, 6faedf5, 8577940, 4cef333, e4687a6, f0d6cf9, ff6483c, a58b2aa, d8e71d3, 19136b5, 8a5e274, 62c0f0b, 26339b1, e75de8c, 8823db4, 307787c, 6be31f4, 4a95b9d, 153013b, 4b55bcf, 8f12405, bb0e1dc, a47c376, 5d52a54, ee6145a, baf7680, 1c24273, 63cb357, 6b6826f, 160fc90, 7bb5ff2, f47bc46, 21f0b4c, 30f3910, b4e9bad, e46dd4b, 751d2e6, 62f502d failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-08 07:13:09 +00:00

Build !#4 triggered by commit a83ddb9 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-09 14:36:15 +00:00

Build !#10 triggered by the commits a841b09, 0e7ca59, e39dd64, 39688ec, c304c23, 7d623fd, 6095e44, 4a89c2e, ccb8f51, cbaa2d8, adab58e, 22b3b0e, d1dae46, fe6a1b1, 9ea377f, 48f49c5, 38c6d6a, 949ea1c, 51d14af, 3fbf172, 6689fab, 66dba8b, 4da3f55, 19eca5f, 596800b, 315c2a6, d4d3c77, 65b2a25, c312139, caab729, 4bb065d, e0dc972, c041bcc, 6e33061, 5a73f4b, b034028, 975985d, 7b73adb, f2df8d9, a300877, 3ce4248, 0b53f30, e205ca4, 52c1d98, 982cda6, 33d2175, 51366e2, a2710ea, d48f0ec, baa775d, 1c2207f, 4c8407e, b14e7f5, ab71b1c, ba623d0, 0f7f2f2, 0f8d5bd, dd943c3, 7b35741, 05a64ce, f91892c, 201c241, 97cfeaa, 3d170f9, 0cc024a, 5314e57, dccc57b, e4d1143, 4513ab2, 3441733, 5a29315, 70146c4, 3c4a719, 876b94c, b6b16e2, f0969e0, fcd1207, 36a3c36, 3a0e2b4, 70ac807, 1eacde0, d11240d, 0935a8e, 6fcf5ec, 6739034, f694b16, 4c88abc, c4ce120, c8eaf66, f8b3ffb, 4fb47ef, eeed030, e5be8d4, 868e8b2 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-11 15:38:33 +00:00

Build !#39 triggered by the commits b4faa01, 746e75e, 3845301, 9257159, 22771e6, c40ac6f, 1247fdc, 5757a6f, 171b366, 28a66c8, d9fbbca failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-11 15:40:30 +00:00

Build !#40 triggered by the commits b6ac31d, 1df8076 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-12 14:47:09 +00:00

Build !#46 triggered by the commits 5f13db7, 3a9774e, 4d784c6, 442f956, e5e806a, 16bc0e5, 1d54c7f, 3f216f2, beecf16, c0e3447, aca5a2e failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-12 14:53:30 +00:00

Build !#47 triggered by the commits 9b5c1f0, 17e04e9, 5d07b04 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-12 14:54:07 +00:00

Build !#48 triggered by commit 33e0fbb failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-15 07:26:52 +00:00

Build !#50 triggered by the commits a18287d, 6bfab25 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-15 07:27:55 +00:00

Build !#51 triggered by the commits 9e0d665, 83772c6, 7d45384, 71f55e3, b7c207a, e7c0218, 157818c, ceeb3a9, 6bde740, 0693e7c, 9d8f810, 40947ac, 7dbc83e, e4fccdd, 31978e1, cee3c32, a5c027b, d6377ca, c947ba3, 6525d69, f7f6bcc, c8ce108, 34bbe65, c8bdb70, 1137c01, 56b779a, 28f5ef2, a352131, 4061165, 0fd5619, 545db94, f53519c, e8d526f, 7386ae5, 2112d45, e8164c6, 12b4865, 930e6e7, 7215e27, ae9e5a4, fc72ddf, 7d21265, d021747, 8846f17, 439d189, 9d66cc9, 49562e7 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-15 07:28:51 +00:00

Build !#52 triggered by the commits 8bf6642, e50221f, 7f0a2d5, 1932a91, 6c3c466, e42b7b3, 8ceef96, 93777ac, ad53f7a, 3a5415f, 0e926ba, 3615b96, 65564cd, 6cf8307, 8ba86a3, 3e41fd6, 9376cee, 2e0bef5, 095f110, 0ec97eb, e216ba6, 7aadad9, cb9c9c7, c0908e3, f58da73, 5d2e849, d99d50b, ea63dad, 631b3d9, c2fe023, 27960fc, 9c2cf0b, da7e599 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2014-09-15 07:41:31 +00:00

• Target Version changed from 2.0-14 to 2.0-15

[icinga-migration]

Updated by elippmann on 2014-09-15 07:52:29 +00:00

• Blocked set to 5525

[icinga-migration]

Updated by icinga-kanban on 2014-09-16 07:29:53 +00:00

Build !#58 triggered by the commits 5c64771, f8edb4f failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-16 16:48:04 +00:00

Build !#61 triggered by the commits a2a6458, 0084fed, 0577665, cc2d06e, d091e21, 88b3b5d, c04768e, 44c4ec7, 0a81aee, 92d855e, 0e6e371, c21d7d1 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-16 16:49:46 +00:00

Build !#62 triggered by the commits 71ffd0e, 4d8b6dd failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-17 07:49:15 +00:00

Build !#63 triggered by the commits 8afdc3d, 5cdcf36 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-17 10:41:30 +00:00

Build !#64 triggered by commit f640874 failed.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-18 14:37:58 +00:00

Build !#70 triggered by commit d10afa1 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 11:00:08 +00:00

Build !#71 triggered by commit 7eb51f6 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 11:03:06 +00:00

Build !#72 triggered by the commits 3c9859a, 5ba96c3 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 12:34:49 +00:00

Build !#73 triggered by the commits 90dbcdb, 4b7096b, bea110d, 72a9a53, 5b5f553, c13823d, c51b052, f1d3b72, 854e284, 7949102, af58732, 18aad56, b8d2429, 0be8b97, b38ef9c, e2b5e05, f48094f, 583fd46 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 12:39:41 +00:00

Build !#74 triggered by commit 274f2e7 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 12:43:51 +00:00

Build !#75 triggered by commit 27650be passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 12:45:07 +00:00

Build !#76 triggered by commit 119e23e passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-19 13:02:56 +00:00

Build !#77 triggered by commit 264d818 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-24 05:52:25 +00:00

Build !#78 triggered by the commits 3229e5e, 1710a50, 0b723bb, 3034ac5, c8f00be, 4258b13, e847770, 051c969, df18eab, 6625e8d, 70500be, 9601942, b107370, 2dd81d1 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-24 05:55:55 +00:00

Build !#79 triggered by the commits cde3ec6, 085102e, 07a4b25, e784aa3, 2ff932f, 6c8f324, 4ce71ef, dc6562b, 44e5fe7, 7385be0, 6f1cb6f, 65203fd, dc05b2e, ef2f332 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-24 06:02:51 +00:00

Build !#80 triggered by commit c4d13a7 passed successfully.

Branch: origin/bugfix/commands-6593
Author: Eric Lippmann

[icinga-migration]

Updated by icinga-kanban on 2014-09-24 06:12:31 +00:00

Build !#69 triggered by the commits 0ac7574, c4d13a7, cde3ec6, 3229e5e, 1710a50, 0b723bb, 3034ac5, c8f00be, 4258b13, e847770, 051c969, df18eab, 6625e8d, 70500be, 9601942, b107370, 2dd81d1, 264d818, 119e23e, 27650be, 274f2e7, 90dbcdb, 4b7096b, bea110d, 72a9a53, 5b5f553, c13823d, c51b052, 3c9859a, 5ba96c3, 7eb51f6, d10afa1, f640874, 8afdc3d, 5cdcf36, 71ffd0e, 4d8b6dd, a2a6458, 0084fed, 0577665, cc2d06e, d091e21, 88b3b5d, c04768e, 44c4ec7, 0a81aee, 92d855e, 0e6e371, c21d7d1, 5c64771, f8edb4f, 8bf6642, 9e0d665, a18287d, 6bfab25, 33e0fbb, 9b5c1f0, 17e04e9, 5d07b04, 5f13db7, 3a9774e, 4d784c6, 442f956, e5e806a, 16bc0e5, 1d54c7f, 3f216f2, beecf16, c0e3447, aca5a2e, b6ac31d, 1df8076, b4faa01, 746e75e, 3845301, 9257159, 22771e6, c40ac6f, 1247fdc, 5757a6f, 171b366, 28a66c8, d9fbbca, a841b09, 83772c6, e7c0218, ceeb3a9, 6bde740, 0693e7c, 9d8f810, 40947ac, 7dbc83e, e4fccdd, 31978e1, cee3c32, a5c027b, d6377ca, c947ba3, 6525d69, f7f6bcc, c8ce108, 34bbe65, c8bdb70, 1137c01, f53519c, 0e7ca59, 12b4865, 930e6e7, 7215e27, ae9e5a4, fc72ddf, 7d21265, d021747, 8846f17, a83ddb9, a94e84f, 9cfd74d, 1358a5d, fe47441, 1c8f880, f57bb0f, 6f8fc3e, ed645b1, cb23ef3, 3d0a74b, bc1d00f, 8d10913, a45b17f, 439d189, 9d66cc9, c3c0043, a4da3b6, 49562e7, 5d1f2ad, 2025fb3, 906de4e, de11131, 774db9a, 1a4e908, 54a8342, 0b1d2bf, dd3901e, 5ce9bef, c7a4098, 5485ca8, 95c839a, 5464321, 1ba3df3, 2d86e6b, 5b14d8f, 539ab91, 338f549, aedc8cc, 39bb01b, 9bcd861, d4c4ab7, 8478ef3, 7143837, ae18016, c27c569, 4b210f9, c005ef4, d47951f, 8686074, 176a1a7, ff10cda, 5a100ea, 939f8b8, e8b70ff, deebb64, e2cdff6, 920c0b9, 0edd145, efd16ba, c5e35c9, cd29adc, cdbd24e, 5474c66, 010c5b4, fda4878, d2d69b9, 0e63e36, dae2967, 8cacd2f, cd8015f, 30965c2, 0822aff, 57dd9a6, f3e74f0, a01ee00, fb5685b, 8c82f1a, 4d353ac, 6324192, ae35650, 6fdc436, 2490993, ec46b36, 2ac4a85, e7eae87, 0e2e1bc, 364c7c0, e020dd3, 79b0ed6, bf23688, 486104d, 4ca1eaa, e132905, 6783d51, 0ff79b0, d3c2fc8, 65dd3f9, 98b2bce, 6b88f1c, 45cbd3f, 5c7999f, 52534a2, c93ab79, 7b221e2, 403f745, 5028ec7, a0b2c0b, 75a0c17, 2b879b3, bc05d2e, d1b1bc3, b81e965, 1106349, bb7972a, 7311ab9, e7da9c0, fe63ce6, e6bcda2, 4b1169c, f23bf91, eea43e9, be14844, a627571, f0a9927, 5203f82, a37e65b, d260c3f, c36e30a, e07f2a2, 4e1e845, 5e6ef57, 5a73811, d7ed6bd, a78d113, 02c3223, b743cf8, ed10e49, 488ea46, 644b3a1, c06db74, 50de21e, af5a326, 26d42da, a6bd802, 5f76521, af898cc, 26a78dc, c3731fa, 1902b4f, 0964316, 9c434fe, edf49d0, d8b468c, 235c4a8, 4fe46a2, fd912da, 936f65e, c8d61f7, 9cdd891, 8b2cc3a, 0bf0213, 25c9ee5, 75e09f2, a73e2ee, a9f0b95, f5ac592, 6ed3d5f, 7157b11, 5da14d3, f4ff2c9, 6ac471c, 8f0b989, 78a6175, 37fd3de, 58188c5, 802c095, 21cd503, 47ae4d7, 1de2d0c, 6690410, 630b36e, 0dce204, 1a1263d passed successfully.

Branch: origin/master
Author: Eric Lippmann

[icinga-migration]

Updated by elippmann on 2014-09-24 06:15:04 +00:00

• Status changed from Assigned to Resolved
• Done % changed from 0 to 100

Applied in changeset 0ac7574.

[icinga-migration]

Updated by tgelf on 2015-03-18 17:21:54 +00:00

• Status changed from Resolved to New
• Assigned to deleted elippmann
• Target Version deleted 2.0-15
• Done % changed from 100 to 0

I have to reopen this issue, unfortunately this has not been solved. Good work has been done, and many mentioned details have been addressed. However, the motivation of all this was the desire to add a new custom command transport, eventually in a custom module. This is still not possible.

As our factory class CommandTransport hardcodes available implementation names there is no way to add new ones without changing the factory class again and again. We are using similar anti-patterns in various places, with Authentication being the most excessive and prominent place.

Cheers,
Thomas

[icinga-migration]

Updated by elippmann on 2015-03-27 08:21:42 +00:00

• Relates set to 8876

[icinga-migration]

Updated by elippmann on 2015-03-27 08:22:17 +00:00

• Status changed from New to Closed

Please don't reopen tickets from closed version. I'll add a related issue.